Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1653054imm; Wed, 10 Oct 2018 19:40:44 -0700 (PDT) X-Google-Smtp-Source: ACcGV62ilSec+CdxYMdHH5YiflGZpr6AmmYJMRoZkMAEdnE3IgcbYx8CMemom6rcvi/93sFHmDSq X-Received: by 2002:a63:1f0a:: with SMTP id f10-v6mr31877434pgf.313.1539225644581; Wed, 10 Oct 2018 19:40:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539225644; cv=none; d=google.com; s=arc-20160816; b=FRTaX1jpQKbGf0PZAcfeOHTE3xw3hWFhgabAPuen0VW6M5rm4qTQA7OjoLZy8M76LD BrCbZ+n4jSo2BCCRuIVJ3dsSZnHiJ7Ka32SMUogNP4SF8kzTiGZ1i41FdOEwFI9Jw/Xh k5PTr/vEhW/Qd9KvFoFrTF3z0YNEjnnBYgbb5uiiM2z6OCmrcCnuojjIG7jPR4d2+w2h gqIRVEaP+H6FUfiV+PUV/89/M2uNNe+dUTtrECT4uq+5k5Ge0Cd2nXf2tya+Kf68qoDB wadguhG+mrFRjkiApm6fpaYsFn+SCCV5sZRJm1O8CL38M545ZoAeJ/eUFWe0P+3rqo31 nJVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=tf7NkfKrH48e2kFu04yEKxEYj6d+2rO23TWBDgAE/9Y=; b=I4zsUOkKUwRJ0pCykcogIqAusipa9AAnyioQFknt2VLjIkDtG7DLfeJRmDJrqxRdOg Y412Oh+8Y8Smwn3QlGf8iUCRf5rDylifO+qEn/z+KaarSM+G2/dW7+N1WTNvTIawuZls lHk8/oOprnZBPGgWpJjfayYB2XnzgLQ2BZqEvrQZANKj+P8wEjFhjHZYZwe53L47Lkk3 TsH6bNb6X/xt956n6aL1em11Zi0dh4IT7jTsrnmeZqE/NuROLsP+189L81M3YWmzP+yr g4QXjRikxnc7RUqBbd83kmmKPPq11rfLMSovNemygfgtaqoe8Mkgm14b9Mwm33IHLGhF Mt0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=QM0+N7Tv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z1-v6si26096676plo.59.2018.10.10.19.40.27; Wed, 10 Oct 2018 19:40:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=QM0+N7Tv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726970AbeJKKCs (ORCPT + 99 others); Thu, 11 Oct 2018 06:02:48 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:34442 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726701AbeJKKCs (ORCPT ); Thu, 11 Oct 2018 06:02:48 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9B2Y3xs038976; Thu, 11 Oct 2018 02:37:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=tf7NkfKrH48e2kFu04yEKxEYj6d+2rO23TWBDgAE/9Y=; b=QM0+N7TvWXVEqe6xZuaJ89cJOeKBIX358NRuM9ZnstQ/jDLv6tGBfX8at+kb+I6Eecob y1ZNWHa6l452rpSEi9EzZaN3J6T1LyyoI1p5L/9DSqGv5KZrYO8nVpAAVGkIYneZN9o2 Lhbv3t9dA5eJhKXzd07n5msYyGfjJ7Qg9LMEaq6qBsgel2tmHicFcZK4uYgRkJzBz/5R y6y8IaqGbCo5TyoUv2I9sNlA60sMKt6uwThuEoFqlsrUT7YifYQP0uqskU/pdRZ7LRpM xhqA47+u5vpB7jDqy5DjxSdvPS0UN8lBq7I9lFUx1CpcFvIdyg6zBGjhRiXyFraxU9Gv iQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2mxmftypd7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Oct 2018 02:37:40 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9B2bcEJ025948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Oct 2018 02:37:39 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9B2bbGE020948; Thu, 11 Oct 2018 02:37:38 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 11 Oct 2018 02:37:37 +0000 To: Lance Roy Cc: linux-kernel@vger.kernel.org, "Paul E. McKenney" , Karan Tilak Kumar , Sesidhar Baddela , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: Re: [PATCH 09/16] scsi: Replace spin_is_locked() with lockdep From: "Martin K. Petersen" Organization: Oracle Corporation References: <20181003053902.6910-1-ldr709@gmail.com> <20181003053902.6910-10-ldr709@gmail.com> Date: Wed, 10 Oct 2018 22:37:34 -0400 In-Reply-To: <20181003053902.6910-10-ldr709@gmail.com> (Lance Roy's message of "Tue, 2 Oct 2018 22:38:55 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9042 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=448 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810110023 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lance, > lockdep_assert_held() is better suited to checking locking > requirements, since it won't get confused when someone else holds the > lock. This is also a step towards possibly removing spin_is_locked(). Applied to 4.20/scsi-queue, thank you! -- Martin K. Petersen Oracle Linux Engineering