Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1781008imm; Wed, 10 Oct 2018 22:55:03 -0700 (PDT) X-Google-Smtp-Source: ACcGV61NSP5QrgffbF06wtOq/K5dPnbtA4/MEXyS7QtIiwDTqdNRZOYXjuwLpKCosIf6NmBTF9FS X-Received: by 2002:a63:6054:: with SMTP id u81-v6mr189812pgb.74.1539237303436; Wed, 10 Oct 2018 22:55:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539237303; cv=none; d=google.com; s=arc-20160816; b=fzq9UioSTEbpUTdEGi1ODaX/g1iuAXVLHS6xXrGmNHMvBWKh3kSTYhOr5AQ4v/LfXR 7si0vmvjy++fYuFF4KCGhO6FAs2USsANL0/UMC7TXemmUt0oyq6zTpQSI81l6s+WCypP 4SivnkvpdpnTQrttZKWkyZGmCQOL4qirBg95Ep3gIdaI1xBh4bJZVtkN2F4rEbMYkVl+ oSjkMHV7BXi6pXP6OOSRfOHkfqNjYgnkerKd0/KgDUPUGORIJtil5M62hd0KDZkLlVNG 1fuYqDpLfzzrgV3WKM+2WYdYuyEpXQapjJMueWMlaAWFREXEG2YeGMi8s/qBA5VKTmpq QRXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=bbU5fEcB+zmc+SivxsKLtyKGsjc4aq5tUz9cZ8eEnEQ=; b=M+pYcVUOIw86ZmigG+FCalXT5VVRvIIN5ZHXTCQbt177TQHs7ELkIDuINOc1E0oeAq lvJPDUrH34W8i7OmzRcA8/ih4iiznVSX6OZVzb20oFPfhoIaW0bf8VHHzIZxP2B69G2B MJxDZQLODnWoBvdwF7JVzYT952FFjtO3mncecyU3YmGNk4+DoRYEBRGJS+xiqgE9YY4u ywlk0YTO0akNGFvflWLSMd5J2cxGIukkSDUf2Yl1pjatlHspiygxict5doJx22TN6Av9 E+zIIoH000FPHL580wlhY4qwHWtCYaayonFrKqs5gi6YcRVQpiy7Z4mX/CFWTk5TdXpo baUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1-v6si27167402plo.165.2018.10.10.22.54.48; Wed, 10 Oct 2018 22:55:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728083AbeJKNSs (ORCPT + 99 others); Thu, 11 Oct 2018 09:18:48 -0400 Received: from out1.zte.com.cn ([202.103.147.172]:57810 "EHLO mxct.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727065AbeJKNSs (ORCPT ); Thu, 11 Oct 2018 09:18:48 -0400 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id CE45F1E727696511D213; Thu, 11 Oct 2018 13:53:00 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id w9B5qrrk049030; Thu, 11 Oct 2018 13:52:53 +0800 (GMT-8) (envelope-from zhang.xianwei8@zte.com.cn) Received: from localhost.localdomain ([10.75.9.60]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2018101113532264-3776416 ; Thu, 11 Oct 2018 13:53:22 +0800 From: Zhang Xianwei To: ibm-acpi@hmh.eng.br, dvhart@infradead.org, andy@infradead.org Cc: ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn, zhang.xianwei8@zte.com.cn Subject: [PATCH] platform/x86: thinkpad_acpi: Change the keymap for Favorites hotkey Date: Thu, 11 Oct 2018 13:59:31 +0800 Message-Id: <1539237571-28926-1-git-send-email-zhang.xianwei8@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2018-10-11 13:53:22, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2018-10-11 13:52:41, Serialize complete at 2018-10-11 13:52:41 X-MAIL: mse01.zte.com.cn w9B5qrrk049030 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The keycode KEY_FAVORITES(0x16c) used in thinkpad_acpi driver is too big (out of range > 255) for xorg to handle. xkeyboard-config has already mapped KEY_BOOKMARKS(156) to XF86Favorites: keycodes/evdev: = 164; // #define KEY_BOOKMARKS 156 symbols/inet: key { [ XF86Favorites ] }; So change the keymap to KEY_BOOKMARKS for Favorites hotkey. Signed-off-by: Zhang Xianwei --- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index fde08a9..a86cf47 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -3457,7 +3457,7 @@ static int __init hotkey_init(struct ibm_init_struct *iibm) KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, - KEY_FAVORITES, /* Favorite app, 0x311 */ + KEY_BOOKMARKS, /* Favorite app, 0x311 */ KEY_RESERVED, /* Clipping tool */ KEY_CALC, /* Calculator (above numpad, P52) */ KEY_BLUETOOTH, /* Bluetooth */ -- 2.9.5