Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1782146imm; Wed, 10 Oct 2018 22:56:41 -0700 (PDT) X-Google-Smtp-Source: ACcGV618EqlpxuSh8LdyJJIJr4IsZClcmdHahmVm32sDlCo7+JOMvEivzgpyG7Hpsf0Xe1nHwSq5 X-Received: by 2002:a63:2a11:: with SMTP id q17-v6mr176895pgq.374.1539237401616; Wed, 10 Oct 2018 22:56:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539237401; cv=none; d=google.com; s=arc-20160816; b=Jf2wMTpkPx0/P+r/YHdiWFAnxfu+C9Yhuj2W9rlvsu29Uxa7Kz1BxV3WYUFYRTY7zY ubDFxQ3AGL0psMHvxSPPFqvRnuNViJzix1uQ+x1SEc1YMxMdshm65vgAefTojdgL77AI LdU1MKPKBCOJNm/AT3GW/4RRKuiUe5EFUK90bNCFzLH5bJoECavqcDwW2VXwSt/mT8VX ZkyO1TfnbHB2356D24TqyZcKlq+h3bbfT5iAMNNXHyB9AyTYWgyeKwZ8N77ktRlxX2Ga 7T4Jy8wZ1w+a2SnaOsn4CvqtTK2dVqGVHj7OWULAVQgF9XyasO66JQPYWl+b/RM7VzTw OUQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=NS8/tWqtABRF6loNo1/x/9VVJG02LtXcfZwKDi6gHEk=; b=hgg47A6esRNgCCUfPijvz+QHQliI+NVJpv70+3Xwv3YLwP/cZzUj6iXRRsH8rUNMjy HtNgSIn7KCCCIGi5NTTxnoq8729a1+9zWgE6ydSMq/a6wTBLho9RFk532x3OGEfQIHcP /t0Gfrrje7o0NnmDGfzwJgS/wDNQiS37PvSl3nqlgm2XJU49iRQ7q26tkWUc5FTf9QPY RiOOUnsgqBqKkAeIRhyy2sRn6OhiKwltD1nf62Of5iifOlFXjBJXxYmbDcUPqsFtAAT3 rF+R4b+BcXnZdkZUfufQwM/GQWvWea2oIEkSfduiEfKy6iEalaFRAjTgI4RJGxwqrrro alKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h32-v6si26225344pgm.126.2018.10.10.22.56.26; Wed, 10 Oct 2018 22:56:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728099AbeJKNU3 (ORCPT + 99 others); Thu, 11 Oct 2018 09:20:29 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49230 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727065AbeJKNU3 (ORCPT ); Thu, 11 Oct 2018 09:20:29 -0400 Received: from localhost (c-67-183-145-105.hsd1.wa.comcast.net [67.183.145.105]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 570D412139FF0; Wed, 10 Oct 2018 22:54:48 -0700 (PDT) Date: Wed, 10 Oct 2018 22:54:47 -0700 (PDT) Message-Id: <20181010.225447.2264091665828087261.davem@davemloft.net> To: weiyongjun1@huawei.com Cc: kishon@ti.com, quentin.schulz@bootlin.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH -next] phy: phy-ocelot-serdes: fix return value check in serdes_probe() From: David Miller In-Reply-To: <1539136824-44940-1-git-send-email-weiyongjun1@huawei.com> References: <1539136824-44940-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 10 Oct 2018 22:54:48 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun Date: Wed, 10 Oct 2018 02:00:24 +0000 > In case of error, the function syscon_node_to_regmap() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 51f6b410fc22 ("phy: add driver for Microsemi Ocelot SerDes muxing") > Signed-off-by: Wei Yongjun Applied.