Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1959465imm; Thu, 11 Oct 2018 02:44:16 -0700 (PDT) X-Google-Smtp-Source: ACcGV63THb+XveDQFT8ms60pGEp/qvjDTuyjipNgwQMNlTlvJar6PIBSFVaeVwxkvFVkHhFk3IBx X-Received: by 2002:a63:fc46:: with SMTP id r6-v6mr749037pgk.345.1539251056585; Thu, 11 Oct 2018 02:44:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539251056; cv=none; d=google.com; s=arc-20160816; b=Az2VOeaFTCULBYKRdMQ9iXkqG6ivuANvOWtwqJoWlDeXVejV6xRUdlALANruANKmzP eNijJUgUMNR27afsGtMyd/iKIEaDLAO9Mc1l/+eRENWq6Hor23zS68s0UVYy2rA3Gjr7 fy6JBBNaNCKGZ+vU7jsoVsflgT5BBKdULP7RSavF+YsqkA42j/pIUcTQubfqmiZLZMBi UVP0AdCRx9KM3vr/7hG9QaDlJXMypMO5M4tR5WomNRF7L7Pn7EwSv+IX7rmBKJHbUvfJ HjLp9XYf4u9BqRtFYk18egQM94rhT31fYfGpdY2aG+URjW7zKPfdiSULsbCixNZHnmBE f/vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:reply-to:references:cc:to:subject :dkim-signature; bh=NFy46GbEQidubModh4Z4XDCH8Kfq/lK81JwEcNG3icU=; b=ce2v282/5+yX48ApEFLsTxMTwTwObABAX85BpNfXuli7jQh1yzvixR+GyAkvpzv7zY 3UpZTFDK/Nn505zJqUM/IGKK/Gn2xTffyl0+UvpJcT/liE4jClJ+rmHeuozJU1XoQjIW uEIuNJMhTIuyHTvQshgw0/51zfm3EWMGjXKzInU6kfd7hqmwdiekOZhlVng7UrROFPE9 RGNnV7OWlmE08HcWGc72F+IE2QpLl47Iu+scMKEodkt8NPlQq5xjYjW9VjKKBhqvRnZy BDKndRjDfMWM9XVyquMFB2PKFg5rMf6NJdOjl69CQzYNxjfqnWqYKSLbNoNCG7s3ML65 bbqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=eI+A+WwD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v20-v6si27065222plo.147.2018.10.11.02.44.01; Thu, 11 Oct 2018 02:44:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=eI+A+WwD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728330AbeJKQ7y (ORCPT + 99 others); Thu, 11 Oct 2018 12:59:54 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:44922 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726960AbeJKQ7y (ORCPT ); Thu, 11 Oct 2018 12:59:54 -0400 Received: from [192.168.0.21] (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CBA26F; Thu, 11 Oct 2018 11:33:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1539250404; bh=o/Aw8VlWCshtwprbAKc/lUBh+6RvbmCd00PIeHTGnKY=; h=Subject:To:Cc:References:Reply-To:From:Date:In-Reply-To:From; b=eI+A+WwDTw4cg1hLGCE2Zbr4Co7HiRsLBOpcqI9u4FQPiPq0cmDjQ7LghW63Ti6Ip J6msKryUER9esMh7keAQpATfhNCiK6XoF+JvsIqE6EJmkSubPY1LSnyo8+p/g+9J71 Qw8DjYSP8pMOXPHy1ujU5ewh5jtiLgz5BsBy8+1M= Subject: Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions To: Rajmohan Mani , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sakari Ailus , Mauro Carvalho Chehab , Yong Zhi , Bingbu Cao , Tian Shu Qiu , Jian Xu Zheng Cc: tfiga@chromium.org References: <20181009234245.25830-1-rajmohan.mani@intel.com> Reply-To: kieran.bingham+renesas@ideasonboard.com From: Kieran Bingham Organization: Ideas on Board Message-ID: <33c53caf-633a-f359-4312-9c2dc317efc5@ideasonboard.com> Date: Thu, 11 Oct 2018 10:33:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181009234245.25830-1-rajmohan.mani@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rajmohan Thank you for the patch, On 10/10/18 00:42, Rajmohan Mani wrote: > Removed redundant CIO2_IMAGE_MAX_* definitions > > Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") > > Signed-off-by: Rajmohan Mani Reviewed-by: Kieran Bingham Looks like this {sh,c}ould be bundled in with "[PATCH 0/2] Trivial CIO2 patches" from Sakari at integration. -- Regards Kieran Bingham > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h > index 240635be7a31..7caab9b8c2b9 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h > @@ -10,8 +10,6 @@ > #define CIO2_PCI_ID 0x9d32 > #define CIO2_PCI_BAR 0 > #define CIO2_DMA_MASK DMA_BIT_MASK(39) > -#define CIO2_IMAGE_MAX_WIDTH 4224 > -#define CIO2_IMAGE_MAX_LENGTH 3136 > > #define CIO2_IMAGE_MAX_WIDTH 4224 > #define CIO2_IMAGE_MAX_LENGTH 3136 >