Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Scott Wood <oss@buserror.net>, Rob Herring <robh+dt@kernel.org>,
        Vabhav Sharma <vabhav.sharma@nxp.com>
CC:     Mark Rutland <mark.rutland@arm.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Will Deacon <will.deacon@arm.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Sriram Dash <sriram.dash@nxp.com>,
        linux-clk <linux-clk@vger.kernel.org>,
        "open list:THERMAL" <linux-pm@vger.kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "linux-kernel-owner@vger.kernel.org" 
        <linux-kernel-owner@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Udit Kumar <udit.kumar@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Priyanka Jain <priyanka.jain@nxp.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 5/5] arm64: dts: add LX2160ARDB board support
Thread-Topic: [PATCH 5/5] arm64: dts: add LX2160ARDB board support
Thread-Index: AQHUOLcWZbySF20JhkCNMnXgzjY1nw==
Date:   Thu, 11 Oct 2018 10:04:31 +0000
Message-ID: <VI1PR0402MB34852BFA7E8E44E9B867D76F98E10@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1534747636-20064-1-git-send-email-vabhav.sharma@nxp.com>
 <1534747636-20064-6-git-send-email-vabhav.sharma@nxp.com>
 <CAL_JsqKH4haGy2F2_2EP=evC8ip7DmGR8J4wzrO0wWnOLsaZqA@mail.gmail.com>
 <1dd3074eabb496155c4d1abb83c82c52529a656a.camel@buserror.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b58e972-3246-4e47-5780-08d62f60f0c1
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2018 10:04:31.9570
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3455
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/29/2018 3:31 AM, Scott Wood wrote:=0A=
> On Tue, 2018-08-21 at 15:45 -0500, Rob Herring wrote:=0A=
>> On Mon, Aug 20, 2018 at 1:52 PM Vabhav Sharma <vabhav.sharma@nxp.com> wr=
ote:=0A=
>>> +/ {=0A=
>>> +       model =3D "NXP Layerscape LX2160ARDB";=0A=
>>> +       compatible =3D "fsl,lx2160a-rdb", "fsl,lx2160a";=0A=
>>> +=0A=
>>> +       aliases {=0A=
>>> +               crypto =3D &crypto;=0A=
>>=0A=
>> Drop this. Aliases should be numbered, and this is not a standard=0A=
>> alias name either.=0A=
> =0A=
> Is this a new rule?  In any case, U-Boot looks for a "crypto" alias.=0A=
> =0A=
(Replying here, I did not see a follow-up).=0A=
=0A=
Indeed, U-boot relies on the "crypto" alias.=0A=
This is true for all SoCs with CAAM crypto engine, a pretty lengthy list.=
=0A=
=0A=
Could you please clarify?=0A=
Also: Is numbering needed even when there is a single instance of the block=
?=0A=
=0A=
Looking at a recent discussion=0A=
https://lore.kernel.org/patchwork/patch/991718=0A=
I see the proposal is for the ID to be optional:=0A=
> Alias names are often suffixed with a numeric ID, especially when there m=
ay=0A=
> be multiple instances of the same type. The ID typically corresponds to t=
he=0A=
[...]=0A=
=0A=
Thanks,=0A=
Horia=0A=