Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2044997imm; Thu, 11 Oct 2018 04:20:43 -0700 (PDT) X-Google-Smtp-Source: ACcGV61RW9NqNireXTz2WGgYpnx/8c51j0KI+oFgq2VMhorQn4XdKb2Rsghji1j+3UMaJbwCh62R X-Received: by 2002:a62:8a91:: with SMTP id o17-v6mr1167092pfk.184.1539256843419; Thu, 11 Oct 2018 04:20:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539256843; cv=none; d=google.com; s=arc-20160816; b=jI68pH3PCoQfx54bIpQgJCuR7P4PB+YaS6HFBIyuCnz9gNgTmJodOWcbAioT7gp6Kv mNHoH18YQnjiV/l2XhYEV4MKL55qmX8EFusuvXf9BAPlNQDeObOxN1NRG3K1uzw8u7dE lONBVpZMtb9KTjhnV+GxpEa5RyJsCCzTb4HOaClhQE1ODBOZxbOhjdqyleGghIP0NOQ0 2mgCGMQoU+gTQgHGXppqRQRfcisdmPafma+LLCPguoZqKrW2Ggcg7itC85tFOL/+OvZ9 5C/6iPt1/dmjxxSNRpYhEl+R3+CNYiGt4GnyMyQxBTbsYUhMqHsmd1Np+PVOxr/vOO/R 9Rng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=/ibgMSyj1HCcQTQArgPjEnXVkQou6esZ4S8uNRZQ+Vo=; b=JMP3IVzYjH6zB9xHaxGUx2hnceXqhX/Dgfq6F9b1RqMdm+ViaU9Ic8D5epqeoZGaXS zap5kPXNV0cp3J8ZpQu88m12syt5j0vbUOlroyQUav0knARAXK2ClHfXcaXfZnGmwMNx yDX6fFX0zu9J5Kc/KkF+kgrSMauVGOF7st1qTiaICxikNCWlgG478bxuidqHz1ok/v4Y 1NWcZ0UUuah9VIDkanY2cO7WfoM7r3KT7Q+6QZNwR3PZxjUrjRltp1PJQc2KzohJgBGi m6GaWidg4tIjYvTDNH9m7Xw8MdVe67B3a4W7NemTyeV0LObr4xEXMoc8S1eyrYHwptF2 a0oQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=M8bx2Kf8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33-v6si29439909plv.241.2018.10.11.04.20.28; Thu, 11 Oct 2018 04:20:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=M8bx2Kf8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728084AbeJKRiP (ORCPT + 99 others); Thu, 11 Oct 2018 13:38:15 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:34182 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726035AbeJKRiO (ORCPT ); Thu, 11 Oct 2018 13:38:14 -0400 Received: by mail-lj1-f193.google.com with SMTP id j17-v6so7693860lja.1 for ; Thu, 11 Oct 2018 03:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/ibgMSyj1HCcQTQArgPjEnXVkQou6esZ4S8uNRZQ+Vo=; b=M8bx2Kf8FKA9CcBeWS2aSlX+Ry63UxUL35cotq7fGBqaOK9TmxBSNOxGw4aZFkWULX dk5v7uk23IadjOm85VnYR0tky60K+oxUlLuUO+Ycm+5F0i2J9bmFSDZWmeG6eY6XtuF2 hlFA3iQ2TI9vVNgmURFDFpptBzNmLFlbbd1rs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/ibgMSyj1HCcQTQArgPjEnXVkQou6esZ4S8uNRZQ+Vo=; b=ERR0FnToVvAePGrhUpEpnhjjh0QhlSm45MV4GnzbHpuviEUtjA2ZnD82N8Vhb+oQLV YCi1Eznf2OZQG7AIlfeH6IB9b+1ohyvJHM2uuLTKoOxce9WnygJ6sIJ2WZnv1zk0qbgW 6a9CmKasWncSWhFTEKktieJQqRavJF/GT/p3VQs+QEHT1u84MHCwuC/SC6EfSwDwOorr p4wpaXH9a8iRgix/6csKQ8wQhvxru/FXGCiCImZnDB0b5Ck1x5Z3fHoUs+dJkIyKs4Fp YaydnZzxI9WhPZk+1FPPNHO55Hw6RvLKZOd9d28eyYKcI4oRVPegOp7oyuV5Ys1xahwi VgrA== X-Gm-Message-State: ABuFfohBfGijh0rUJ98RLFnPmQ2JCVnzZ3c+SAL+c3xVNcCj0g+vqmnS sik0vMqBiKlEoxlFebU6FE/xE7emNk0= X-Received: by 2002:a2e:7a19:: with SMTP id v25-v6mr773691ljc.147.1539252697098; Thu, 11 Oct 2018 03:11:37 -0700 (PDT) Received: from [192.168.0.189] (dhcp-5-186-114-252.cgn.ip.fibianet.dk. [5.186.114.252]) by smtp.gmail.com with ESMTPSA id z19-v6sm6039770ljk.20.2018.10.11.03.11.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Oct 2018 03:11:36 -0700 (PDT) Subject: Re: [PATCH 2/3] staging: greybus: loopback.c: do insertion in O(n) instead of O(n lg n) To: Bryan O'Donoghue , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20181005142826.26108-1-linux@rasmusvillemoes.dk> <20181005142826.26108-2-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: Date: Thu, 11 Oct 2018 12:11:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-10-11 01:03, Bryan O'Donoghue wrote: > On 05/10/2018 15:28, Rasmus Villemoes wrote: >> Signed-off-by: Rasmus Villemoes >> --- >> I have no idea if the performance matters (it probably doesn't). Feel >> free to ignore this and the followup cleanup. > > What's the problem you're fixing here ? No problem, really, other than my inner Paul Hogan telling me "That's not an insertion sort, ...". > Is it tested ? Compile-tested. As I said, if the performance (and inaccurate comment) is irrelevant, just drop it. Rasmus