Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 11 Oct 2018 15:43:30 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access
Message-ID: <20181011144330.GF25351@sirena.org.uk>
References: <20181011143531.7195-1-linus.walleij@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dWYAkE0V1FpFQHQ3"
Content-Disposition: inline
In-Reply-To: <20181011143531.7195-1-linus.walleij@linaro.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--dWYAkE0V1FpFQHQ3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 11, 2018 at 04:35:31PM +0200, Linus Walleij wrote:

> +	/*
> +	 * Some fixed regulators share the enable line between two
> +	 * regulators which makes it necessary to get a handle on the
> +	 * same descriptor for two different consumers. This will get
> +	 * the GPIO descriptor, but only the first call will initialize
> +	 * it so any flags such as inversion or open drain will only
> +	 * be set up by the first caller and assumed identical on the
> +	 * next caller.
> +	 *
> +	 * FIXME: find a better way to deal with this.
> +	 */
> +	gflags |= GPIOD_FLAGS_BIT_NONEXCLUSIVE;
> +

It's not just fixed regulators that do this, often regulators with
register control can do this as well.  Since power up is often a
performance critical path but regulators tend to be controlled via slow
buses like I2C it's common to have register control combined with a GPIO
enable line so you don't need to use the bus to do the enables.  That
should just be a case of adding this flag to all the drivers that have
already been converted to gpiod (including the core code that's in
regulator_ena_gpio_request() which I thought was coping with this
already) unless I'm missing something?

--dWYAkE0V1FpFQHQ3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlu/YZIACgkQJNaLcl1U
h9D47Af+LHEm3qHlbkqWm0H1Ku1iFePv0+bsa4Do4nZlGNRSOLXdvuxD2YyTptAu
uB4vzaULjSusPMG+7t9WDuJ1ODl6b2igrAB8v58QWLH91vMh327Pk994BBhDiE5r
ZYK4srJW6X2o3kbUmAFcgzaJtBsMvrhmIYcP7tid40cR5VOhmnTMBtVC6ODguM5Z
kxyBUfJtCs/5/qmiWIJPEM2IqxE/LK34yikRe74gb63Wb3cfgoZ4KwHy+Ci/vKQI
jxHb2bnejiTPYJoT43veSzE0i5GJwezwF14xHgATq3M3yIblpJ30lPhHA2/rJbyp
GO9z3HLVy8zHR1yEhVdFrhrnjETS3w==
=Mcdt
-----END PGP SIGNATURE-----

--dWYAkE0V1FpFQHQ3--