Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2294375imm;
        Thu, 11 Oct 2018 08:06:27 -0700 (PDT)
X-Google-Smtp-Source: ACcGV60F2VhsgYYGPD8iPC77egap56jG8hIvxT4Ix2a4vzVQBYBO2vZ6KxPs4q8wFEpEN5vKzvFa
X-Received: by 2002:a62:b286:: with SMTP id z6-v6mr1981734pfl.79.1539270387066;
        Thu, 11 Oct 2018 08:06:27 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1539270387; cv=none;
        d=google.com; s=arc-20160816;
        b=qnMNpZmCZZPcO0bJdaMdeKipqP8ZoWRGJIAPpf6G1k7drqAAFJJnr/Hdjdq07kfAp8
         GLxlBUQcnp/9ksAbjpAeUqTLSVTDRC87s3BjUj6VwqR3AMuq+8j5TEu8F9x1zzLDZuHg
         iFqOqEDx2yhGNfedoeyTDv3hcf5pwPxiVDW8IOBZ0fEsr4KGPikPQ8vDD93twGKeuKYG
         AG3Uv9qsu0iIMHUNhrdJdf4xe1NvCrgE6IY8jl7kbgCjRoKsZhdg2KmCnsJFYHkBb/At
         AiKYOxLdiqALHpR+KWE2WVA1FaU2wSiJuRGE47W96RPtHiG9GUGDskxGgKADsM2XwhUj
         y6Xw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=yulZ6WpRxcx9tdz/Joqw9RtVXaMU62yVBp3RP3uhvVQ=;
        b=Gz1b796KMv4zTTI6k8hY2fJoaTEh6isNrbX7Bv4LvmNs18xL/Xq7u3pJXFVVcJ4ET1
         sQBAdew5Bik5nNNuJVjRG6Nt/L+KltUjAP6GZx4J8e3kxtwGVPfZtliGgmOI7X+dM9oW
         cC+s9L1j/2dxLAefdhRsGARNEiK3bSkJg+yANsOqIC5uiJ6p28SeV/7vPe10HpEH8BBG
         pxw29K/0MjXRiFM4gPAnxliuExt8JQKSnQLbWwdi+3saKtSE7cuqiI+8zQ82PmXZQZSj
         qfWBC8nhdx05gI+sKR4sb/973ZRS+RnXZGajoQ/Dmue2rCNfFm/obSZmv1YMP5HDMd61
         G1hg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=XPe1rB0g;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 69-v6si7427291pgg.95.2018.10.11.08.06.12;
        Thu, 11 Oct 2018 08:06:27 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=XPe1rB0g;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727554AbeJKW17 (ORCPT <rfc822;chaneybenjamini@gmail.com>
        + 99 others); Thu, 11 Oct 2018 18:27:59 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:5220 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726071AbeJKW17 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 Oct 2018 18:27:59 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5bbf65850000>; Thu, 11 Oct 2018 08:00:21 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Thu, 11 Oct 2018 08:00:26 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Thu, 11 Oct 2018 08:00:26 -0700
Received: from [10.21.132.143] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 Oct
 2018 15:00:22 +0000
Subject: Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only
To:     Linus Walleij <linus.walleij@linaro.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>
CC:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Janusz Krzysztofik <jmkrzyszt@gmail.com>,
        Alexander Shiyan <shc_work@mail.ru>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Aaro Koskinen <aaro.koskinen@iki.fi>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Robert Jarzmik <robert.jarzmik@free.fr>,
        Philipp Zabel <philipp.zabel@gmail.com>,
        Daniel Mack <zonque@gmail.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        jacopo <jacopo@jmondi.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        linux-tegra <linux-tegra@vger.kernel.org>
References: <CGME20181011090112eucas1p286d8c1edfc1a2a207d8a11c5ad7eb20e@eucas1p2.samsung.com>
 <20180906122436.25610-1-linus.walleij@linaro.org>
 <20181011090112eucas1p286d8c1edfc1a2a207d8a11c5ad7eb20e~cglSx9qcr2394623946eucas1p2y@eucas1p2.samsung.com>
 <CACRpkdbTdmQQTg1D9jbcHGcT4kZermwVA+QEnUJGf+VYqoKRkg@mail.gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <c2726f18-f0cd-0d3d-c950-3e7212efd34d@nvidia.com>
Date:   Thu, 11 Oct 2018 16:00:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CACRpkdbTdmQQTg1D9jbcHGcT4kZermwVA+QEnUJGf+VYqoKRkg@mail.gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1539270021; bh=yulZ6WpRxcx9tdz/Joqw9RtVXaMU62yVBp3RP3uhvVQ=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=XPe1rB0gEWOJ68DovNua67OZcfE0OLYVPFUnAowHrYMAFDYL6JJKbLliXwy5nXk5q
         vkSWjtvwQgqh60ROOY2ioZw9rjFFneoQtUoPiUTauOtHa4QDCPJxECkTTVv33TUsL8
         YX7Jx9ZObD1B6O9bInPtB1QPE28GkocuAGJjD/wtdf4HbMWqBLvpCi2bdbTzFW5S34
         DB4qqc2AclSy25/7f5DFBSes93RPtsM2W2aguzZsgkWMOvwkj2ovZv75lSHiPjG0Ua
         wXTqvunhMfJxKThWXVsPRBuZG8jx+23QRyUu5YMplOBYnzkwULnQcwogtbw7/PW4vY
         VdTxt1jJY/ORA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Linus,

On 11/10/18 10:29, Linus Walleij wrote:
> On Thu, Oct 11, 2018 at 11:01 AM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
> 
>> I've just noticed that this patch causes regression on Samsung
>> Exynos4412-based Trats2 board. Conversion to GPIO descriptor breaks
>> operation when regulators used shared GPIO:  sii9234 i2c driver
>> is not able to get vcc33mhl regulator (it uses shared GPIO enable
>> line with vsil12 regulator).
> 
> So I guess this means that this physical GPIO line will enable the
> vcc33mhl and the vsil12 regulators at the same time?
> 
>> This issue has been already pointed in case of commits:
>> 37fa23dbccbd97663acc085bd79246f427e603a1
>> d1dae72fab2c377ff463742eefd8ac0f9e99b7b9
>> ab4d11e2c2329cf7cb7be31ff22489aae4dee5dc
> 
> A big sorry for my ignorance, I guess the information overload
> on the mailing list just makes me miss the important points.
> I'll try to be better, sadly I constantly fail to keep everything
> in mind and constantly break things like this.
> 
>> Maybe it would be better to first solve the handling of shared enable
>> GPIO in the descriptor-based interface before converting more regulators
>> and stepping into this issue again?
> 
> I am trying to solve it, but I just don't have systems to reproduce all
> kinds of things. It's a bit stressful since this is one of those runtime
> things that is hard to test when devising a patch for systems I don't
> have.

This also appears to be causing a regression on the Tegra124 Jetson TK1
that also uses a shared GPIO for two regulators. The 2nd regulator that
uses the GPIO now fails to probe [0] ...

[    0.680021] +5V_SATA: supplied by +5V_SYS
[    0.683964] reg-fixed-voltage: probe of regulators:regulator@14 failed with error -16

Not sure if you have one of these, but otherwise I can help test.

Cheers
Jon

[0] https://storage.kernelci.org/next/master/next-20181011/arm/tegra_defconfig/lab-baylibre-seattle/boot-tegra124-jetson-tk1.html 

-- 
nvpublic