Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264593AbTK0S4Q (ORCPT ); Thu, 27 Nov 2003 13:56:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264595AbTK0S4Q (ORCPT ); Thu, 27 Nov 2003 13:56:16 -0500 Received: from bolt.sonic.net ([208.201.242.18]:51878 "EHLO bolt.sonic.net") by vger.kernel.org with ESMTP id S264593AbTK0S4N (ORCPT ); Thu, 27 Nov 2003 13:56:13 -0500 Date: Thu, 27 Nov 2003 10:56:12 -0800 From: David Hinds To: Davide Libenzi Cc: Linux kernel mailing list Subject: Re: [BUG] Ricoh Cardbus -> Can't get interrupts Message-ID: <20031127105612.B28106@sonic.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.22.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 26 On Mon, Nov 24, 2003 at 07:08:26PM -0800, Davide Libenzi wrote: > > I didn't want to post this because I was ashamed of the fix, but w/out > this my orinoco cardbus gets an interrupt one every ten boots. This is > against 2.4.20 ... > > - Davide Your patch seems to do two things: First, it automatically falls back on using a socket's PCI interrupt if its ISA interrupts are not available. That part seems ok. But, it also falls back on sharing an interrupt if a driver requested an exclusive interrupt and that was not available. This part is not ok. The original code will share a PCI interrupt automatically, but will not share an ISA interrupt except under certain circumstances (for multifunction cards or when the driver specifically requests it). Sharing ISA interrupts is unsafe and should never be done blindly. -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/