Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181011103825.023036082@infradead.org> <20181011104019.748208519@infradead.org>
In-Reply-To: <20181011104019.748208519@infradead.org>
From:   Eric Dumazet <edumazet@google.com>
Date:   Thu, 11 Oct 2018 08:02:48 -0700
Message-ID: <CANn89iKxTMRr_XSC4xHD-etoU9kF6nN7yzQP4AEfYeNKjQLTPQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] x86/percpu: Fix this_cpu_read()
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Borislav Petkov <bp@alien8.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Oct 11, 2018 at 3:45 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> Eric reported that a sequence count loop using this_cpu_read() got
> optimized out. This is wrong, this_cpu_read() must imply READ_ONCE()
> because the interface is IRQ-safe, therefore an interrupt can have
> changed the per-cpu value.
>
> Fixes: 59eaef78bfea ("x86/tsc: Remodel cyc2ns to use seqcount_latch()")
> Reported-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>


Acked-by: Eric Dumazet <edumazet@google.com>

> ---
>  arch/x86/include/asm/percpu.h |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- a/arch/x86/include/asm/percpu.h
> +++ b/arch/x86/include/asm/percpu.h
> @@ -185,22 +185,22 @@ do {                                                                      \
>         typeof(var) pfo_ret__;                          \
>         switch (sizeof(var)) {                          \
>         case 1:                                         \
> -               asm(op "b "__percpu_arg(1)",%0"         \
> +               asm volatile(op "b "__percpu_arg(1)",%0"\
>                     : "=q" (pfo_ret__)                  \
>                     : "m" (var));                       \
>                 break;                                  \
>         case 2:                                         \
> -               asm(op "w "__percpu_arg(1)",%0"         \
> +               asm volatile(op "w "__percpu_arg(1)",%0"\
>                     : "=r" (pfo_ret__)                  \
>                     : "m" (var));                       \
>                 break;                                  \
>         case 4:                                         \
> -               asm(op "l "__percpu_arg(1)",%0"         \
> +               asm volatile(op "l "__percpu_arg(1)",%0"\
>                     : "=r" (pfo_ret__)                  \
>                     : "m" (var));                       \
>                 break;                                  \
>         case 8:                                         \
> -               asm(op "q "__percpu_arg(1)",%0"         \
> +               asm volatile(op "q "__percpu_arg(1)",%0"\
>                     : "=r" (pfo_ret__)                  \
>                     : "m" (var));                       \
>                 break;                                  \
>
>