Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 11 Oct 2018 18:54:06 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access
Message-ID: <20181011175406.GH25351@sirena.org.uk>
References: <20181011143531.7195-1-linus.walleij@linaro.org>
 <20181011144330.GF25351@sirena.org.uk>
 <CACRpkdbTnBQhPQARX77KfjtfWXY+t0oH6-B=WUN4hid8eQT0DA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fd5uyaI9j6xoeUBo"
Content-Disposition: inline
In-Reply-To: <CACRpkdbTnBQhPQARX77KfjtfWXY+t0oH6-B=WUN4hid8eQT0DA@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--fd5uyaI9j6xoeUBo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 11, 2018 at 07:01:13PM +0200, Linus Walleij wrote:
> On Thu, Oct 11, 2018 at 4:43 PM Mark Brown <broonie@kernel.org> wrote:
> > On Thu, Oct 11, 2018 at 04:35:31PM +0200, Linus Walleij wrote:

> > enable line so you don't need to use the bus to do the enables.  That
> > should just be a case of adding this flag to all the drivers that have
> > already been converted to gpiod (including the core code that's in
> > regulator_ena_gpio_request() which I thought was coping with this
> > already) unless I'm missing something?

> Sorry if I don't get it... we already have code in the core to
> check if the same gpiod is used by two regulators.
> regulator_ena_gpio_request() does this:

>         if (config->ena_gpiod)
>                 gpiod = config->ena_gpiod;
>         else
>                 gpiod = gpio_to_desc(config->ena_gpio);

> So after the change I made to fixed.c this comes in through
> config->ena_gpiod.

Other regulators that have GPIO control for their enables do their own
requests (as does the core) so don't they all need to set the flag
GPIOD_FLAGS_BIT_NONEXCLUSIVE when they request otherwise it'll only work
in systems where the regulators after the first that request the GPIO
are fixed regulators?

--fd5uyaI9j6xoeUBo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlu/jj4ACgkQJNaLcl1U
h9BhsQgAhqcaxL3AJRBNhk8J1gpoIf8ReGJaLmFdBgzg/TIWH1yMWH2S1f2JkKyP
022ZSDRhwPujqi3c4BYYyLAoRb0rCh7aTnqcx5bkwpUxlBqF5kRFVMvZL3iymW0G
r0dmnzCF79gli8w1ru6OUzkqdN8/iYX/+u9L8ji+xSQsMq8zB+Ele9nz8BNRJMH0
toQ4GcnX3GsO4sUYuyJB3zS5bLwenmSzz1V6NIzdu5bpS1MOV5c1om0DMKxcrlUX
8SLCdrRxrrjdgm/xBEOhKGyrAE2IXSsbX2Jq3MwOpt7/UryRJSiZgYwSqeRy6sOS
9iWTH/qfAR8+a9wjIAKFOEL4pPT/nA==
=moG1
-----END PGP SIGNATURE-----

--fd5uyaI9j6xoeUBo--