Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2635038imm; Thu, 11 Oct 2018 13:34:36 -0700 (PDT) X-Google-Smtp-Source: ACcGV625xZKHGqD338RNRSQPSKjmHixg0WzBMG1oMbcVGPMz7XrD72yu8AGBgz12GMlIw3TFgsIt X-Received: by 2002:a62:3a84:: with SMTP id v4-v6mr3034889pfj.118.1539290076032; Thu, 11 Oct 2018 13:34:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539290076; cv=none; d=google.com; s=arc-20160816; b=C171yGNysYl8w9ZGv7HbgP5/aHTaNiz/pars5nr2+Xt46VOb3T86nFFcvC1oAUmzON 2oeaZTm9oQkhHrjRBOMLc2cSY/HtzSIe9xQTdwUzelEgZybrQ8A7B+WYcPStl3w/H6fT yq99mpGK0pG4Uga/1NlFK+mUl089OnM3olqtSg1HxkfxKR7n1cGdMxWVTDv1zGpzD8Bn 3T866yXbLZTY1agkXucpQ52qaMEcp6gXP7nn1zImLlVpdlUvksepfJrhkP2VUNMla64L bZhNb2KDZectJX1RaVRPg07OXuAv8oTvCIMZSxvveFUYa3RrNeMO162HuXuGsHhmE8J6 dqAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature; bh=8gSBtBCZdWMJtw+xitppN60g2aVQjUYIFeshOHvCAaY=; b=C4CYB9AJc/10p6lqWHiUcEi3E3N9VfywkO+kbHVc18PJDwTASJ4Ll4bRJnUKeIZg6x g+uWlHi9Z9HUTCU1amBqML/rK+CvIZyNJ8HEgGgH/HQX60QOXsY0DyGaiKmXBVIr+PRv 5xZUVXkWvdPhk8qYdsgM5orEj5Ep68qEIKDjQsXFASNmXFhkoG7IAC8pTNg2lw3O6zzz gVRdRoivusu9GgEKcnVW1+ZMyfHAbhIQWK9y9bxtubegc0M1Vpd+8RRa0esx8NgUGOzc p0K14XV4tTVeBO3osxCY1eABXyQgfaqFctRBU0NclW8A7na4keLBn1azhlQYki6Hzus5 wA3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=ZEvB7rMC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12-v6si3952309plt.4.2018.10.11.13.34.21; Thu, 11 Oct 2018 13:34:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=ZEvB7rMC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726388AbeJLECV (ORCPT + 99 others); Fri, 12 Oct 2018 00:02:21 -0400 Received: from mail-dm3nam03on0059.outbound.protection.outlook.com ([104.47.41.59]:46368 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725840AbeJLECV (ORCPT ); Fri, 12 Oct 2018 00:02:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8gSBtBCZdWMJtw+xitppN60g2aVQjUYIFeshOHvCAaY=; b=ZEvB7rMCG+cFTV4tzOrDhzUDIu9igeSvUfJVcXUVbeksxMNRrg8661E6L/fLgeW+qblGeiFlc2lk4zRLVbdrZxSbZiDag03qyB2ZtSj/ZdN1c6dsvlXZVT2t3S1fVCY75zvtjWF+XE3F0PO8YSyv8NMeeQZIoa/lQ1Oj54muKwc= Received: from DM5PR12MB2471.namprd12.prod.outlook.com (52.132.141.138) by DM5PR12MB1674.namprd12.prod.outlook.com (10.172.40.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.24; Thu, 11 Oct 2018 20:33:12 +0000 Received: from DM5PR12MB2471.namprd12.prod.outlook.com ([fe80::bd60:9d30:b818:b828]) by DM5PR12MB2471.namprd12.prod.outlook.com ([fe80::bd60:9d30:b818:b828%3]) with mapi id 15.20.1228.020; Thu, 11 Oct 2018 20:33:12 +0000 From: "Moger, Babu" To: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "reinette.chatre@intel.com" , "fenghua.yu@intel.com" , "james.morse@arm.com" , "vikas.shivappa@linux.intel.com" , "tony.luck@intel.com" CC: "x86@kernel.org" , "peterz@infradead.org" , "Moger, Babu" , "pombredanne@nexb.com" , "gregkh@linuxfoundation.org" , "kstewart@linuxfoundation.org" , "bp@suse.de" , "rafael.j.wysocki@intel.com" , "ak@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "xiaochen.shen@intel.com" , "colin.king@canonical.com" , "Hurwitz, Sherry" , "Lendacky, Thomas" , "pbonzini@redhat.com" , "dwmw@amazon.co.uk" , "luto@kernel.org" , "jroedel@suse.de" , "jannh@google.com" , "dima@arista.com" , "jpoimboe@redhat.com" , "vkuznets@redhat.com" , "linux-kernel@vger.kernel.org" Subject: [PATCH v3 03/11] arch/x86: Re-arrange RDT init code Thread-Topic: [PATCH v3 03/11] arch/x86: Re-arrange RDT init code Thread-Index: AQHUYaGhdaEXYEd4YEq3qUhw6ousWQ== Date: Thu, 11 Oct 2018 20:33:12 +0000 Message-ID: <20181011203223.18157-4-babu.moger@amd.com> References: <20181011203223.18157-1-babu.moger@amd.com> In-Reply-To: <20181011203223.18157-1-babu.moger@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MWHPR22CA0062.namprd22.prod.outlook.com (2603:10b6:300:12a::24) To DM5PR12MB2471.namprd12.prod.outlook.com (2603:10b6:4:b5::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [165.204.78.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR12MB1674;20:n2I/90kYHbbXTM8p8x0hdyfuXXmrfyIrEylB0yYS6gc9lu7uZsRI/1lBaJroGF4TZet+Sx1cEKMEXqBzl5HYFdSL6El2htEOryvxmwyLVn6C35pfHXd2yN+PjFCQ+GE1MZPvXn/TRK/CA0ZZxNA6OWsWVVx7k/dq/egkmTIs+OfeFseU/9p1HvySnCNYlM5kGHAMD3KIHv6K28THMCZoEHTdvE4NFVRUBmHbRr4Yqui3fZv24SlfbvkABa01e1zx x-ms-office365-filtering-correlation-id: b111fc40-d344-4ff7-71da-08d62fb8c393 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:DM5PR12MB1674; x-ms-traffictypediagnostic: DM5PR12MB1674: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(767451399110); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823302103)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201708071742011)(7699051);SRVR:DM5PR12MB1674;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1674; x-forefront-prvs: 08220FA8D6 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(346002)(376002)(136003)(396003)(39860400002)(189003)(199004)(76176011)(53936002)(6486002)(99286004)(478600001)(6512007)(52116002)(4326008)(446003)(81166006)(6436002)(81156014)(8676002)(14454004)(2501003)(26005)(5250100002)(102836004)(1076002)(3846002)(6116002)(186003)(2906002)(7736002)(2201001)(110136005)(7416002)(54906003)(486006)(11346002)(476003)(2616005)(2900100001)(97736004)(8936002)(106356001)(305945005)(316002)(86362001)(256004)(72206003)(66066001)(25786009)(386003)(105586002)(71200400001)(71190400001)(36756003)(6506007)(5660300001)(68736007);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1674;H:DM5PR12MB2471.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ZvCLYKfvIfbicqXoJ8/tc9wvMnUJpYO009qyaLYusT0mbP39d0CmOivAWb527uz37nIbQHEklwHwKBxHXJquaLQBkJ4lD30yRsEmZpo4D8s4DnVmxbVtEjog0nl9oxGrLLDJSexlh0qjMNooCxsq8AOB98AeQGldwVw1Noqo0BVsbEJLQaFJzBCMijoxOXWWdwsNS0bxJO0Gf6tmpU+ARLIyhDu+bR7JzoV8oWdMwgqYArYz0Z1i7VKu7TCmRCc6iemvgoF+Nqh175S+yB3HCZ+mGdr8iQIFA6xuHzLPYJRIva+la71NsVhfCGHdLrzVnNfibgh+0LxEZ3i9lejgV7Glae1cBsdekkYbJVd+0Ss= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b111fc40-d344-4ff7-71da-08d62fb8c393 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2018 20:33:12.4854 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1674 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Separate the call sequence for rdt_quirks and MBA feature. This is in preparation to handle vendor differences in these call sequences. Signed-off-by: Babu Moger --- arch/x86/kernel/cpu/resctrl.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/cpu/resctrl.c b/arch/x86/kernel/cpu/resctrl.c index 07158963ca30..2c564301e008 100644 --- a/arch/x86/kernel/cpu/resctrl.c +++ b/arch/x86/kernel/cpu/resctrl.c @@ -787,6 +787,16 @@ static bool __init rdt_cpu_has(int flag) return ret; } =20 +static __init bool rdt_mba_config(void) +{ + if (rdt_cpu_has(X86_FEATURE_MBA)) { + if (rdt_get_mem_config(&rdt_resources_all[RDT_RESOURCE_MBA])) + return true; + } + + return false; +} + static __init bool get_rdt_alloc_resources(void) { bool ret =3D false; @@ -811,10 +821,9 @@ static __init bool get_rdt_alloc_resources(void) ret =3D true; } =20 - if (rdt_cpu_has(X86_FEATURE_MBA)) { - if (rdt_get_mem_config(&rdt_resources_all[RDT_RESOURCE_MBA])) - ret =3D true; - } + if (rdt_mba_config()) + ret =3D true; + return ret; } =20 @@ -833,7 +842,7 @@ static __init bool get_rdt_mon_resources(void) return !rdt_get_mon_l3_config(&rdt_resources_all[RDT_RESOURCE_L3]); } =20 -static __init void rdt_quirks(void) +static __init void rdt_quirks_intel(void) { switch (boot_cpu_data.x86_model) { case INTEL_FAM6_HASWELL_X: @@ -848,9 +857,14 @@ static __init void rdt_quirks(void) } } =20 +static __init void rdt_quirks(void) +{ + if (boot_cpu_data.x86_vendor =3D=3D X86_VENDOR_INTEL) + rdt_quirks_intel(); +} + static __init bool get_rdt_resources(void) { - rdt_quirks(); rdt_alloc_capable =3D get_rdt_alloc_resources(); rdt_mon_capable =3D get_rdt_mon_resources(); =20 @@ -864,6 +878,9 @@ static int __init resctrl_late_init(void) struct rdt_resource *r; int state, ret; =20 + /* Run quirks first */ + rdt_quirks(); + if (!get_rdt_resources()) return -ENODEV; =20 --=20 2.17.1