Received: by 2002:ac0:8f67:0:0:0:0:0 with SMTP id z94-v6csp10111imb; Thu, 11 Oct 2018 14:12:04 -0700 (PDT) X-Google-Smtp-Source: ACcGV63lNgLmQmTbf2EfjBoESXWIAFQsYNLDHR19BfVbB+oCN2DqEGJwCemGoULzd9maFgnrdRDo X-Received: by 2002:a62:9c4a:: with SMTP id f71-v6mr3211820pfe.135.1539292324220; Thu, 11 Oct 2018 14:12:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539292324; cv=none; d=google.com; s=arc-20160816; b=xoMuaoC8GPwZGyW6uOEaYSWCbaFOdGbJ+z8Uo9y+g2VS24I/WooqgMV5K7myBByXBM Ppx/U8DqxLkVaDJRnhXf6YvjzV2ycDFTziQQ9QxNFV0Z/SzY6Ac/y6XWzzbrf6cRZw8v z619liBBbTe9AvdnuQDzFGPG9myTUzC6yn1Wdz6RnX7//RQe94fApkXfu53sms+fe4xz h9ng2eWG5dDRLG7PKWM/gVj4XsjnPXi1MmMT9Hxke94p4xNVUCnL3waArpyP6h+XGCI/ Bz8jyN2e7UmmQW3CQ2Q9Ihv8m+8VaxbZdTGT6zH3Ef5xT6hx75T27VbIRxzbj5GVHkEa 3JmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=DDVWboxCunZlM92XuRTvAFj+92aebzvKdLQegV9riTg=; b=HoShYO7BkpscaREZ8JKLGdgeQ7c6xWGHknr0Cg3Q55rbGcWvBCxsb6us/w4vVNg8A4 YxmQs/sOYsz1SEgVQQvIsrNmP152KscyDlX+evmEg9StYDtf68xRPSXjf+5iaffYXiUZ 6tWYj+C4NKayUMxHHWv2rQnu3mIiwSAZiTlJSf6VzUeJQVZL7WDexalXkA3Vg5zIohpV AvbZMdClyOPahIkSPFQ6nhHXQOkWS/0R1w6DS5b5cYdLzY/aJhJnplqx4+KT+Lm/JYGo 31Ea3AaWMVjQ7TiUUfqpMRnoGQeOP26FeS+x5Vit0hNdXjQf5CcfoiN3ePRFz32tMTTN sJyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l15-v6si30883141pfg.176.2018.10.11.14.11.48; Thu, 11 Oct 2018 14:12:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726836AbeJLEk1 (ORCPT + 99 others); Fri, 12 Oct 2018 00:40:27 -0400 Received: from sauhun.de ([88.99.104.3]:41704 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbeJLEk1 (ORCPT ); Fri, 12 Oct 2018 00:40:27 -0400 Received: from localhost (p54B3377B.dip0.t-ipconnect.de [84.179.55.123]) by pokefinder.org (Postfix) with ESMTPSA id 752DA2E3577; Thu, 11 Oct 2018 23:11:22 +0200 (CEST) Date: Thu, 11 Oct 2018 23:11:21 +0200 From: Wolfram Sang To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Karthikeyan Ramasubramanian , Sagar Dharia , Girish Mahadevan , Doug Anderson Subject: Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions Message-ID: <20181011211121.6k525ixa2cbemm5w@katana> References: <20180924235235.182649-1-swboyd@chromium.org> <20180924235235.182649-2-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="taemko2ixbpiv2iq" Content-Disposition: inline In-Reply-To: <20180924235235.182649-2-swboyd@chromium.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --taemko2ixbpiv2iq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 24, 2018 at 04:52:34PM -0700, Stephen Boyd wrote: > We never really look at the 'ret' local variable in these functions, so > let's remove it to make way for shorter and simpler code. Furthermore, > we can shorten some lines by adding two local variables for the SE and > the message length so that everything fits in 80 columns and testing the > 'dma_buf' local variable in lieu of the 'mode' local variable. And > kernel style is to leave the return statement by itself, detached from > the rest of the function. >=20 > Cc: Karthikeyan Ramasubramanian > Cc: Sagar Dharia > Cc: Girish Mahadevan > Cc: Doug Anderson > Signed-off-by: Stephen Boyd Applied to for-next, thanks! --taemko2ixbpiv2iq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlu/vHkACgkQFA3kzBSg Kbb83w//eCKnP//hTPObrMhJ+Mmp6HU5Tp89ikmciHnAQvwdlV9LhNNikmnT70D/ 9mpOxz2MA56I1sX/adMQgkb6+pT5i3/fvvABoH5ZKpPs6jxjTWulRX/e9pIRAKtA FJeko90KbyPd2IlldY0cawzZmsgwVnbLxnfO5ZBoozLaJnMRxUggWz7UbrsGN1DB T1khYEPSeqBcr3tOtKjPeG8oSj4pzX5LWa356Tn1X54cpUDZPqZEDy+d3m42/piH LUS4h5qVajbL1dWErX64hFXIDYJ6QSwxnfJwfnoOH7nHNpzdcdBkb/g78asei4Fq Y3V04h/XowgAUyJHb4PDAL32/gGPHMFwR+D0zNCCYgvGKFDG4HA+tkeXAEQMu/hL YAGIqNfPTKgtuewM/Va/FtlXlgCK7ey/Kjz/r+hiQBJdgJ9+dqcgzbVspvrl95SC XE3kMilcSeBGr/UaTGU2N6o6YxW5XoncUtJwX936jIH/LZY2m5IkTFmvlIpDrtDq SJIW1NjbfTZuiS118DKVFXwGMIN65HA2ATHJvPEhlRcZ/LkqBuxdXCrC9s62Xa8r 6mEDL0bkmJoCmFTlHF8a1hpbfpZxfQHST8od4/GJBpglSCucbD9TkiidKGD3yST3 2+i4p+7Y9Ujq31r9Fug4DMRQib4B3Ukpqxxs3VUlh1wz9VWLxA4= =f4rs -----END PGP SIGNATURE----- --taemko2ixbpiv2iq--