Subject: Re: [PATCH 2.6]: IPv4: strcpy -> strlcpy
From: David Woodhouse <dwmw2@infradead.org>
To: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>
Cc: Timo Kamph <timo@kamph.org>,
       Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
       netdev@oss.sgi.com, davem@redhat.com
In-Reply-To: <1069970946.2138.13.camel@teapot.felipe-alfaro.com>
References: <20031127142125.GG8276@jdj5.mit.edu>
	 <3FC67128.14704.30155D53@localhost>
	 <1069970946.2138.13.camel@teapot.felipe-alfaro.com>
Content-Type: text/plain
Message-Id: <1070012538.10048.13.camel@hades.cambridge.redhat.com>
Mime-Version: 1.0
Date: Fri, 28 Nov 2003 09:42:18 +0000
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 781
Lines: 22

On Thu, 2003-11-27 at 23:09 +0100, Felipe Alfaro Solana wrote:
> On Thu, 2003-11-27 at 21:48, Timo Kamph wrote:
> 
> > > +	strlcpy(label->label, name, sizeof(label->name));
> >                                                                        ^^^^^^
> > I guess this shoud be label->label, or am I wrong?
> 
> Oh my god! Two consecutive mistakes with the same patch! I should have
> some sleep... Here's the one with the typo corrected.

Perhaps we should consider

#define strsizecpy(x, y) strlcpy((x), (y), sizeof(x))

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/