Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp378349imm; Thu, 11 Oct 2018 23:04:02 -0700 (PDT) X-Google-Smtp-Source: ACcGV63QDSioUaYWPoutuAaA0r6dKTrCARo3ocMZ522sEJ9/238x7UKmya0ampF68N2/gkJTBnKo X-Received: by 2002:a17:902:9004:: with SMTP id a4-v6mr4504487plp.166.1539324242622; Thu, 11 Oct 2018 23:04:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539324242; cv=none; d=google.com; s=arc-20160816; b=JRfLZtgLCa/CgXs0Hx3wix30lqisJDOmj9taWCX3Titr2YwCO6vUxv1hratAa15UES xcLmI9RalwNClnZGgRjmk+sY76FtyP6X74RjLJz1Uz7W241D/37EggbAIAC+NNBu23Tk fusP6fBMyF8aKYy2hWu7FK4EWx6AExD7ZMgFk13DSJNopItpm8QopeeTva1UzMwXq+IX 5f7PlbVjYY4YqVssVK4nGbcag2hBzEosJtAgpwRYV9TlqNWdyxINJ+Up1XbfaDGFW1oA PJb4JqkpVb1TJ86Sw+jVvJ7lzaG2cdI9TFpayQpVPMwijvY+cGfA3Gt44GeMniWgf4PZ b4/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=1FQSCKuIkAaAiYuE6GiVmfbP6AtGw3cssKcsN9qB8Qk=; b=vYYZ0fY84gx6AwXLl6jR2exlbEaxPEHkg/g1uM2QaJ4K0WQ6j8bZWF5AgheMeeCBCs JqMMtNv0e9Fmowtf+ACgAcD9ZpOcQmIb1p2yVidWVJMLd0ly/zoIhJh8wZk6i6E3N1/p RCB8cDWAlRGFzGw3sLUs3Ez7kQDPI/wBKPWjvYOAhmuQvjRoPQBse79hXN7uGE50ewzO few2dDTKF6o2dUGIEvwnn5shZMIiDrEi7axK9NvaTrNZqRZ55Y1yAQ26TBEw6zsz8KPN uezZFbHN6mzxtcJ0rTuB0SYH+v8+nmXnreZD6U0kVPZ1FEh3s67lifdgDht8bt9tUgR6 71Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cHMGLZg2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p19-v6si229828pfi.12.2018.10.11.23.03.47; Thu, 11 Oct 2018 23:04:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cHMGLZg2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727703AbeJLNeM (ORCPT + 99 others); Fri, 12 Oct 2018 09:34:12 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:40691 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727361AbeJLNeL (ORCPT ); Fri, 12 Oct 2018 09:34:11 -0400 Received: by mail-io1-f66.google.com with SMTP id w16-v6so8423463iom.7 for ; Thu, 11 Oct 2018 23:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1FQSCKuIkAaAiYuE6GiVmfbP6AtGw3cssKcsN9qB8Qk=; b=cHMGLZg2CJbHkP3UAjzfRu2ZT4KGXWUp1r4Wif05y1ZPapPKZqvIA3AZaTC1mN6TPC 0MAu4PRrUc8OvVYJsjFrMOpwtEuSrl6w30Uvx6GabqL3sF3PZ6TnAtV4DDwdes28q+Vl ypvJ1p4xp7cQRWwWSfaxsWFoN02c1VD4g83UY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1FQSCKuIkAaAiYuE6GiVmfbP6AtGw3cssKcsN9qB8Qk=; b=ibEmlQGdqvh2mOAWn6RL/DPOGrzvepeeBvymFyV0jJBes/O5k+Lt7DNuBRvfaPHz+k yOazrrP1qcF7wiGOSipQRIpw08p0e6eihMVDpLrNBEv2ZcuP/CypRZF9WCcAadjfgZ28 xPv1t+jaQHoWGmxwKNTyjWpj3XOAgFxN8gbZpZI/X7msnMO1g4nLJSSiOmioepQm+gm9 nB0tknDwS3ZP1oouMeDIAP69VRfnG5+zWVN8mwvGk3Dw5M0+mZ4WH1DqGD1eXPjBiCmF 1IEETq2ZZqULgwV5EFG1UcWPa0BminjzRy1LGm2BKGMnc4PpeB1ezpvbs4Og5yPKoaIn jxDQ== X-Gm-Message-State: ABuFfogGMdEeYtfNN+vLLt871hj0sSNtX7wb53crK7T0GG6YrC+b8YSA OK/Agv6JPzmoLN9GRXZwunrUprmUWVZw+3PKbkEDDw== X-Received: by 2002:a6b:6302:: with SMTP id p2-v6mr3042350iog.175.1539324201274; Thu, 11 Oct 2018 23:03:21 -0700 (PDT) MIME-Version: 1.0 References: <20181005065300.22882-1-ricardo.ribalda@gmail.com> <20181005065300.22882-3-ricardo.ribalda@gmail.com> <9746eba6-63f5-feaf-e63f-7e0ea7638942@ti.com> <8d180cc7-d7cb-66eb-001d-f2a5c371d179@ti.com> In-Reply-To: <8d180cc7-d7cb-66eb-001d-f2a5c371d179@ti.com> From: Linus Walleij Date: Fri, 12 Oct 2018 08:03:09 +0200 Message-ID: Subject: Re: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning To: Vignesh R Cc: Ricardo Ribalda Delgado , timur@kernel.org, Stephen Boyd , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , jhugo@codeaurora.org, Linux-OMAP , ext Tony Lindgren , Grygorii Strashko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 12, 2018 at 7:59 AM Vignesh R wrote: > On Thursday 11 October 2018 07:12 PM, Ricardo Ribalda Delgado wrote: > > Hi Vignesh > > > > Ups, it does not look too good :S . Can you check if this change fixes it: > > > > Below diff works for me. I no longer see crash and gpio-hog seems to be > working. Thanks! Ricardo can you send a patch with a Fixes: tag and Vignesh's Tested-by/Reported-by? Yours, Linus Walleij