Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vitaly Kuznetsov <vkuznets@redhat.com>
To:     Haiyang Zhang <haiyangz@microsoft.com>
Cc:     "davem\@davemloft.net" <davem@davemloft.net>,
        "netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
        KY Srinivasan <kys@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "olaf\@aepfle.de" <olaf@aepfle.de>,
        "devel\@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info
In-Reply-To: <MWHPR21MB0176EB148DC772F9DC5845D2CAE10@MWHPR21MB0176.namprd21.prod.outlook.com>
References: <20181011201434.30737-1-haiyangz@linuxonhyperv.com> <MWHPR21MB0176EB148DC772F9DC5845D2CAE10@MWHPR21MB0176.namprd21.prod.outlook.com>
Date:   Fri, 12 Oct 2018 08:27:45 +0200
Message-ID: <87k1mnptlq.fsf@vitty.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Haiyang Zhang <haiyangz@microsoft.com> writes:

>> -----Original Message-----
>> From: Haiyang Zhang <haiyangz@linuxonhyperv.com>
>> Sent: Thursday, October 11, 2018 4:15 PM
>> To: davem@davemloft.net; netdev@vger.kernel.org
>> Cc: Haiyang Zhang <haiyangz@microsoft.com>; KY Srinivasan
>> <kys@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
>> olaf@aepfle.de; vkuznets <vkuznets@redhat.com>;
>> devel@linuxdriverproject.org; linux-kernel@vger.kernel.org
>> Subject: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info
>> 
>> From: Haiyang Zhang <haiyangz@microsoft.com>
>> 
>> The VF device's serial number is saved as a string in PCI slot's kobj name, not
>> the slot->number. This patch corrects the netvsc driver, so the VF device can be
>> successfully paired with synthetic NIC.
>> 
>> Fixes: 00d7ddba1143 ("hv_netvsc: pair VF based on serial number")
>> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
>
> Thanks Stephen for the reminder -- I added the "reported-by" here:
>
> Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Thanks) 

The difference in the hack I sent to Stephen was that instead of using
kstrtou32() and checking the return value I opted for snprintf() and
doing strncmp().

-- 
Vitaly