Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp418765imm; Fri, 12 Oct 2018 00:00:10 -0700 (PDT) X-Google-Smtp-Source: ACcGV60POpvXP3MbcF0i6nYc45lvRs3O0P0+L+LyWNGESM0ux1VTdXOpVHp3u4joTrYijugxAQh7 X-Received: by 2002:a63:5509:: with SMTP id j9-v6mr4324735pgb.208.1539327610714; Fri, 12 Oct 2018 00:00:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539327610; cv=none; d=google.com; s=arc-20160816; b=mS+jaxH0nAxgEXfC3oaHne9S6s4ywFXKyF01vQnkGBrMT/kxLPLmV/8LhUpN5XkB1j ULOMIPb3wYzwt6oSr1i1LlMaAnQ6tzmt6YObWoCLyYRHJi4aBjjWpelnS8XqXqN2yghI 9MBLSElXWGIMXaqLv80VMYtSiFzYEwecgsc00ddQocH8d3l+wFHATanOJdUkSCrLaj1V s7xW/gOhdHmpDgaDxR3dObZdgBL9kerEGo2lKY8Nfz8K9Mx0V7sU2Dx6RV49ZIhZiK3d zJ7jgk5vpO7jWvPFw78hN0HaB3gU2gTBj4EvcUnTCCoTG7YwwYsriuU1YP2cnfErg4lu J+Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:subject:cc:to :from:date; bh=QzJ4iqDGtnbO6yYcExbmK9D8bRpp8QijPZrHfSMGfNs=; b=Y7loQuQODEJsVFkOklQCKmnphIKVADsQ1RUbMMQ8XU6kO4Ta51hG3GhewdpYwJJvFG IMdYyqV9Dg8FE5pTtsju/tmZ3qHnqnxEzR+ph/q++9rVY+3/naulCOevYoZmomFP1RcV dib9Qq5tXlD6TbPNlQo/6vNV+7BrXOBJhhJM+5nDr1+xYzB3Wr5+FW/rKJBA3LP8wlvV BcQOzT7mGZ98YP9Vv2Aj21iyLnLsvuYG5ExHTJ8Z6L9RSztvHhyRbc4UaB+a5VVPNqQ6 EJOExpgYlEB8NrVFPt3hmAmoKmcziCnd42nhESOTGiX4UZb5ZnVdHlJwhrJe7CuvGj2n yWqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p33-v6si407496pld.57.2018.10.11.23.59.42; Fri, 12 Oct 2018 00:00:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727529AbeJLOaG (ORCPT + 99 others); Fri, 12 Oct 2018 10:30:06 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58316 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727358AbeJLOaG (ORCPT ); Fri, 12 Oct 2018 10:30:06 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9C6oS36194985 for ; Fri, 12 Oct 2018 02:58:57 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0b-001b2d01.pphosted.com with ESMTP id 2n2kbnphww-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 12 Oct 2018 02:58:56 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 Oct 2018 07:58:39 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 12 Oct 2018 07:58:35 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w9C6wYgH8061234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Oct 2018 06:58:34 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 28C5DAE04D; Fri, 12 Oct 2018 09:57:16 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A8262AE051; Fri, 12 Oct 2018 09:57:13 +0100 (BST) Received: from linux.vnet.ibm.com (unknown [9.126.150.29]) by d06av26.portsmouth.uk.ibm.com (Postfix) with SMTP; Fri, 12 Oct 2018 09:57:13 +0100 (BST) Date: Fri, 12 Oct 2018 12:28:31 +0530 From: Srikar Dronamraju To: "Gautham R. Shenoy" Cc: Dave Hansen , "Aneesh Kumar K.V" , Michael Ellerman , Benjamin Herrenschmidt , Michael Neuling , Vaidyanathan Srinivasan , Akshay Adiga , Shilpasri G Bhat , "Oliver O'Halloran" , Nicholas Piggin , Murilo Opsfelder Araujo , Anton Blanchard , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 1/3] powerpc: Detect the presence of big-cores via "ibm,thread-groups" Reply-To: Srikar Dronamraju References: <1539235983-25259-1-git-send-email-ego@linux.vnet.ibm.com> <1539235983-25259-2-git-send-email-ego@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1539235983-25259-2-git-send-email-ego@linux.vnet.ibm.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-TM-AS-GCONF: 00 x-cbid: 18101206-0016-0000-0000-0000021208E1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18101206-0017-0000-0000-00003269837B Message-Id: <20181012065831.GA28228@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-10-12_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=589 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810120069 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +DECLARE_PER_CPU(cpumask_var_t, cpu_smallcore_map); > > +/* > + * On big-cores system, cpu_l1_cache_map for each CPU corresponds to > + * the set its siblings that share the L1-cache. > + */ > +DEFINE_PER_CPU(cpumask_var_t, cpu_l1_cache_map); > Nit: Can you add a comment on how cpu_l1_cache_map differs from cpu_smallcore_map?. Everything else looks okay to me.