Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp493187imm; Fri, 12 Oct 2018 01:35:16 -0700 (PDT) X-Google-Smtp-Source: ACcGV613V8wObfBssIFk+baBesFM+iuYN9wdzXwtV/Ur9z5QzGJCSwcvDR/NTWgRFiSmXLEKqhyy X-Received: by 2002:a62:798e:: with SMTP id u136-v6mr5016145pfc.95.1539333316393; Fri, 12 Oct 2018 01:35:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539333316; cv=none; d=google.com; s=arc-20160816; b=BgqrPNRkx7PtRH6TYiqWEPtESSyKLdReXUOsXTKHFIyfzxMyt2My8t4zOIGjBiDeN1 DFWUFExz3ahyPSR1k3us/1nTs+XoE0WocHyrpMzzqCgOnes7lFW0SeerRjM4Jf+QKrP4 F0J4IskxEWqQwpq1W2RHuoKr/8jS+AcgdWUeTJUyoN1aHmOxnACqhd67+6JFHZx4s1ub 3U3j8xz5REAVUsKHB1GR6lGb5cwOzxeGO3bm9tZKXJxCIhl/aOWVgcvgG5qZ/tm7QJSr ynoub9jKNUwhuhNTqhZwl4cn55oEgWl5gXD0SxiOIRfo5FlJxLVIKbRvKXX0PgHREMSo DCgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CV1oagRJDP2EqGLZzyeHJt/FxQ8kMku7E9llviYz6so=; b=ki49Lbdn+i4mIJWAYok5FKp1wxnXibOcGBviBhUYg/bp1YvRfQ+8PhzY8rAJfEl6R5 9Q3FbNldf8Tfk7TFAlj9IBS74g7xGDZxqyS5gMm/GpVwlca7jDgF70K/I/0vIgp9U0VT lav6oHKjz0rgDOPwTmenoYy9NrBctnOmadxRhYdEbj6thRc5HUwflRqbfUnCG67anSUo j19R32RtwTjMzKfOkZ+cyftS9AYmXFDy5wglYatnMppqwvoHmlx8Y9fDvi27FvSfdy1s xH3nrPukGaUkbqcWma5e+VxejHePbelJpQh6KxZQRqAzKplSgvXhtpm1WvlM3waAq3ji kTWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o12-v6si654211pfh.9.2018.10.12.01.35.01; Fri, 12 Oct 2018 01:35:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728102AbeJLQFt (ORCPT + 99 others); Fri, 12 Oct 2018 12:05:49 -0400 Received: from imap1.codethink.co.uk ([176.9.8.82]:48206 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727791AbeJLQFd (ORCPT ); Fri, 12 Oct 2018 12:05:33 -0400 Received: from [148.252.241.226] (helo=rainbowdash) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1gAstc-0005TY-LB; Fri, 12 Oct 2018 09:34:08 +0100 Received: from ben by rainbowdash with local (Exim 4.91) (envelope-from ) id 1gAstc-00052Y-4N; Fri, 12 Oct 2018 09:34:08 +0100 From: Ben Dooks To: netdev@vger.kernel.org Cc: oneukum@suse.com, davem@davemloft.net, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel@lists.codethink.co.uk, Ben Dooks Subject: [PATCH 2/8] usbnet: smsc95xx: add kconfig for turbo mode Date: Fri, 12 Oct 2018 09:33:59 +0100 Message-Id: <20181012083405.19246-3-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181012083405.19246-1-ben.dooks@codethink.co.uk> References: <20181012083405.19246-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a configuration option for the default state of turbo mode on the smsc95xx networking driver. Some systems it is better to default this to off as it causes significant increases in soft-irq load. Signed-off-by: Ben Dooks --- drivers/net/usb/Kconfig | 13 +++++++++++++ drivers/net/usb/smsc95xx.c | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index 418b0904cecb..c3ebc43a6582 100644 --- a/drivers/net/usb/Kconfig +++ b/drivers/net/usb/Kconfig @@ -351,6 +351,19 @@ config USB_NET_SMSC95XX This option adds support for SMSC LAN95XX based USB 2.0 10/100 Ethernet adapters. +config USB_NET_SMSC95XX_TURBO + bool "Use turbo receive mode by default" + depends on USB_NET_SMSC95XX + default y + help + This options sets the default turbo mode settings for the + driver's receive path. These can also be altered by the + turbo_mode module parameter. + + There are some systems where the turbo mode causes higher + soft-irq load, thus making it useful to default the option + off for these. + config USB_NET_GL620A tristate "GeneSys GL620USB-A based cables" depends on USB_USBNET diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 401ec9feb495..cb19aea139d3 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -78,7 +78,7 @@ struct smsc95xx_priv { struct usbnet *dev; }; -static bool turbo_mode = true; +static bool turbo_mode = IS_ENABLED(CONFIG_USB_NET_SMSC95XX_TURBO); module_param(turbo_mode, bool, 0644); MODULE_PARM_DESC(turbo_mode, "Enable multiple frames per Rx transaction"); -- 2.19.1