Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp520862imm; Fri, 12 Oct 2018 02:09:55 -0700 (PDT) X-Google-Smtp-Source: ACcGV60fmXjxM73F7Al4blbXsYBKcdBJW10pBTLNCPpwKVgiH7BybpJX/shYHRSXTwfv4GNUU9A2 X-Received: by 2002:a63:65c7:: with SMTP id z190-v6mr4763380pgb.146.1539335395198; Fri, 12 Oct 2018 02:09:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539335395; cv=none; d=google.com; s=arc-20160816; b=e2fRo1edtZsuAsTq0BWFk0mHhEn/dZgXZM/KQWUO0C8YU9h08T3oDhBp8hBuC7vAnh JLZOri+PkRhZNF5AoREKk2CNqm06KK77gLn+rOhCfp16bfOdLt/Z57q7RLev5LnAQMXe 1V5EBWcGtGTbw5lCnr2Ky0JUFrfADwIe1AUsglrQfNc2CvPaT1kZCejK3VpOuFiDd92D 7inKRdIazoPnc9AxWRHf+twcG4PDR8dn1lFRfu3vUB/QmChUn9jrXHltboNI+dAhwtKR pGgfy9CWlVMV4pYIR3hGAVgujIS2O89WLVOXnkBpDiZoVxGCSK+LwD5+I8xQzdLkIWFV DZNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qUzUwOaGtf3aXbq+RKvcYD5Ee7pzT5zqBQkaRUi0JAI=; b=v3Xrga7Vt5lKuilWk0SK5fBHxosvjaeEnfFXpR7QVICpvcVfap8LT7tkRoUwB3rv6/ PqTWH0Nk+6H+bwurrNVWxePdxd/dLwLXRana9M1tYBNVTnWlLNHRbC0Rv1BLpYMi1elo NyNunZfc7+YGM3HSuE4uUxMInQPz4KrzMA2bT/I0PIaSlSOSD2Y+b/dPcrCFyTd+hOEH K1dsgAGfc8FaPn1p+qws3bVnMFptcg56FJ/hzas3fU+R6eFg/dS3EsV8zRYG7MjB1kyT u/ccSkkWrL9USXKxgSlnzJh63ZI4vEo++ucNqnOtezKKHaQ9fM9Suu2LcK3dqoytqAcs as5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QWHgSe5a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t33-v6si709148pgk.141.2018.10.12.02.09.39; Fri, 12 Oct 2018 02:09:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QWHgSe5a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728102AbeJLQka (ORCPT + 99 others); Fri, 12 Oct 2018 12:40:30 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:36349 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727808AbeJLQka (ORCPT ); Fri, 12 Oct 2018 12:40:30 -0400 Received: by mail-io1-f68.google.com with SMTP id p4-v6so8721900iom.3 for ; Fri, 12 Oct 2018 02:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qUzUwOaGtf3aXbq+RKvcYD5Ee7pzT5zqBQkaRUi0JAI=; b=QWHgSe5aeXveYsJy9hwsIlKniUkx30ScwEe3g2OxPl+1fzlR+Zj5IU/DhypSX2kPyU rmg30qSoFrK7m00oLsTEHf0TKkYwHoQ9VLNfz7OQUFL7wJ/1yGIQiMEaD6nHV+asOHMA OvOtoNxkaSNsO4SpPGYjw/mzRuFma6HL95i20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qUzUwOaGtf3aXbq+RKvcYD5Ee7pzT5zqBQkaRUi0JAI=; b=kc1h+EqxF4RzLaKLz6s0hxjAeMBJcrX5QR+k8h6y/f0XmjeS4g192sQOTVoq5u0aOa 9b/VIyHYR/IqJlhywIF5XyZdTDbyZHq1H/lcLTmLN3Z80HhZ+TO5VcEsgUBy8k902RHh X/mmbcTu7ZaJOnhbLGUkSjCTf/e8d0L4ZVYDCasWrFcycQJn6JhRQiAFkg1exNiHQShD 5s7wyph7vexyghXGQ2bKQaczDlbq9rx7xgHqbhKTStH3PXAfltSX7o/ec/dC68z9yRvA wmM9+raMnQfRUGOowyTYJcO+tvRMlxPtCnrIsK+X+5pRzzvISXpUmahz1fa8SD4V7/tu F6kg== X-Gm-Message-State: ABuFfogg2I7WT75i3dl6viICBv5uppyk0T/R2OBFZWC4nIYzPQcdi3ID XrAsN0nwvmENPDUUs90tdM+bV6yfrbdJnGMjeqy0xA== X-Received: by 2002:a6b:4006:: with SMTP id k6-v6mr3375615ioa.277.1539335342548; Fri, 12 Oct 2018 02:09:02 -0700 (PDT) MIME-Version: 1.0 References: <20181005065300.22882-1-ricardo.ribalda@gmail.com> <20181005065300.22882-3-ricardo.ribalda@gmail.com> <1539334839.30485.9.camel@toradex.com> In-Reply-To: <1539334839.30485.9.camel@toradex.com> From: Linus Walleij Date: Fri, 12 Oct 2018 11:08:50 +0200 Message-ID: Subject: Re: REGRESSION: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning To: Marcel Ziswiler Cc: timur@kernel.org, Stephen Boyd , "open list:GPIO SUBSYSTEM" , jhugo@codeaurora.org, Ricardo Ribalda Delgado , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 12, 2018 at 11:00 AM Marcel Ziswiler wrote: > On Fri, 2018-10-05 at 08:53 +0200, Ricardo Ribalda Delgado wrote: > > Current code assumes that the direction is input if direction_input > > function is set. > > This might not be the case on GPIOs with programmable direction. > > Unfortunately, this breaks at least Apalis T30 and Apalis TK1. Enabling > earlycon reveals the following: Does this (just applied) patch fix the issue? https://marc.info/?l=linux-kernel&m=153932470412013&w=2 Yours, Linus Walleij