Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp857681imm; Fri, 12 Oct 2018 07:49:52 -0700 (PDT) X-Google-Smtp-Source: ACcGV623DYDYFMU1W1pW6bns+6jppsoj8X1GT7/gZEbaZYjZqyJfGWFCSQHhzIPxUsaw4g9lJCVu X-Received: by 2002:a63:5d55:: with SMTP id o21-v6mr5746675pgm.349.1539355792028; Fri, 12 Oct 2018 07:49:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539355792; cv=none; d=google.com; s=arc-20160816; b=Kg3ZMjx6HggdFD9ZHF939npy4CuuWeS9VecrbHE5CzMdGrj9xdS7J106jizl62XTAm hqzrSsJGkuXOdod4f+bF3yeHEXA7+Il0uIY79EawWGdDioknA+8BxyJFMlv6vLsx695w g4MeNBhcYzPSf7hBvh3+t2HfDIJwstInLmwBFjiyZX1CbkqDvFcwVAZC3/XlRWIm1S36 cqeqB0vsPAV1WdW3mVWJHbI3+d5+5XAIItkM2gnYPc+bYiaaUgwWoJCKPHi8k9J7x9Jg lDiFGW4aHh6EPk7vLLuA/cdtVHoklAvYJu4qUhxKd1edStERWrb5oX+r6UmoGD8x7UNk opvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jfRO+XuQPfglsf6o7ame1vKCXPdEA9BrcgU7woH/d2o=; b=HeWbvwh89HCAvxfwxwrEg3LEN3OEZ5PwO0gOEOklm3sCpGIQbyFDi8kAbK2ACb97Sm oOyZFGcfmFrU7p+qkYrgN3l2qEGwKAC3ODgyJXJxjjXMxMPGyFW110WdxsXwxMK4vwMr XxweDQ5V1DrgZSlxFWOCLbd/WLs0gGaNK2Ub7V8HkWwfQZeTK3M61Bdy4QRuv1wSDYsH 4RgJQwNRx7oyjnO+ULY51oIK62B/KuWwppsyGFcBLGZd7gpega0wmo7BC0cgPysXiief fxpYfsADOGTYLi4E7O/em04jtrG2JD4iZyis0mfePLr6tYl1+UR2SNycMiZTKgBxYq3v uLJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u81-v6si1512903pfi.175.2018.10.12.07.49.36; Fri, 12 Oct 2018 07:49:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728917AbeJLWVr (ORCPT + 99 others); Fri, 12 Oct 2018 18:21:47 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:32903 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728720AbeJLWVq (ORCPT ); Fri, 12 Oct 2018 18:21:46 -0400 Received: by mail-oi1-f195.google.com with SMTP id a203-v6so10070701oib.0; Fri, 12 Oct 2018 07:48:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jfRO+XuQPfglsf6o7ame1vKCXPdEA9BrcgU7woH/d2o=; b=asVjXyuywbbYqzOgxYtz7JKaFJaor3KRrJAkCcpEkW5CFwwxuy51EuvWGTXNR2gaLD zwp9TiNwuBHpYxmcpsGav7KlupbAdcwoFPIdcc5ITrCmBWoS0QS2vGZLksNDNhC3vEXb JWGMrWik9dTdHckjZcO4X+hXPyZewUIf0w6otaFPjxt/WwgUiGQrAvbNN/gWRLMKiIY/ qW3j3fKNXM+9tV3CYGOZIhRYfxBy24q9eor3kO2Z9NpEFb66aZgB57KEGur0W/L05FRu 9HKwG9e3k+ICtipCuRIKVa5v3TVo2cd8Cxo9N0/JhrDN8c/o0W+GqE5+ffiM/9SsbKS4 FGBw== X-Gm-Message-State: ABuFfoh1HyOANklkbIoIYmU/nAfnqcWamX5kZMFIvLVg6h9VkfBrmTc6 VuYdlOFQYoi5Zhah7PhKdA== X-Received: by 2002:aca:75d4:: with SMTP id q203-v6mr3554217oic.334.1539355738294; Fri, 12 Oct 2018 07:48:58 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k24sm387168otd.57.2018.10.12.07.48.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Oct 2018 07:48:57 -0700 (PDT) Date: Fri, 12 Oct 2018 09:48:56 -0500 From: Rob Herring To: Badhri Jagan Sridharan Cc: Mark Rutland , Heikki Krogerus , Greg Kroah-Hartman , Chanwoo Choi , Andrzej Hajda , Li Jun , linux@roeck-us.net, jackp@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Badhri Jagan Sridharan Subject: Re: [PATCH v3 3/3] usb: typec: tcpm: charge current handling for sink during hard reset Message-ID: <20181012144856.GA3720@bogus> References: <20181001194501.58338-1-badhri@google.com> <20181001194501.58338-3-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181001194501.58338-3-badhri@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Oct 2018 12:45:01 -0700, Badhri Jagan Sridharan wrote: > During the initial connect to a non-pd port, sink would hard reset > twice before deeming that the port partner is non-pd. TCPM sets the > the charge path to false during the hard reset. This causes unnecessary > connects/disconnects of charge path and makes port take longer to > charge from the non-pd ports. Avoid this by not setting the charge path > to false unless the partner has already identified to be pd capable. > > When partner is a pd port, set the charge path to false in > SNK_HARD_RESET_SINK_OFF. Set the current limits to default value based > of CC pull up and resume the charge path when port enters > SNK_HARD_RESET_SINK_ON. > > Signed-off-by: Badhri Jagan Sridharan > > -------- > Changes in V3: > Rebase on top of usb-next > > Changes in V2: > Based on feedback of jackp@codeaurora.org > - vsafe_5v_hard_reset flag from tcpc_config is removed > - Patch only differentiates between pd port partner and non-pd port > partner > > V1 version of the patch is here: > https://lkml.org/lkml/2018/9/14/11 > --- > drivers/usb/typec/tcpm/tcpm.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring