Message-ID: <3FC7803D.2050203@cyberone.com.au>
Date: Sat, 29 Nov 2003 04:05:01 +1100
From: Nick Piggin <piggin@cyberone.com.au>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030827 Debian/1.4-3
MIME-Version: 1.0
To: Felipe W Damasio <felipewd@elipse.com.br>
CC: Lista da disciplina de Sistemas Operacionais III 
	<sisopiii-l@cscience.org>,
       Ricardo Nabinger Sanchez <rnsanchez@terra.com.br>,
       Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [SisopIII-l] Re: [PATCH] fix #endif misplacement
References: <20031128141927.5ff1f35a.rnsanchez@terra.com.br> <Pine.LNX.4.53.0311281732100.21904@gockel.physik3.uni-rostock.de> <3FC77A59.2090705@elipse.com.br>
In-Reply-To: <3FC77A59.2090705@elipse.com.br>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 938
Lines: 34


Felipe W Damasio wrote:

>     Hi Tim,
>
> Tim Schmielau wrote:
>
>> No, this is exactly what is intended: don't use the TSC on NUMA, use 
>> jiffies instead.
>
>
>     The patch didn't hurt this.
>
>> Look at the comment just above those lines.
>
>
>     The patch doesn't uses jiffies indiscriminately: Only if we're on 
> a NUMA system with !use_tsc.
>
>     Otherwise (on x86 SMP, for example) we use rdtsc...which seems The 
> Right Thing(tm). Hece move the #endif a bit down.


The ifdef isn't pretty, but its performance critical code, its easy to
understand, and there is a big comment above it. I think its OK the
way it is. Not that you would ever notice any difference probably.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/