Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1141533imm; Fri, 12 Oct 2018 12:29:45 -0700 (PDT) X-Google-Smtp-Source: ACcGV62fhZZuFFVNDNBFPy5D5L8yp0JEtIFavQg7wQimcbz7dYuGYg5+vf7RyiZPC55+Mhw5jo+D X-Received: by 2002:a17:902:108a:: with SMTP id c10-v6mr6859836pla.272.1539372585858; Fri, 12 Oct 2018 12:29:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539372585; cv=none; d=google.com; s=arc-20160816; b=b31RMNyjmge4UBuVv/OiCvUYsvZAWAqQaOeOd991xT3ovJg2lQigtIfbeMAWBtxOnh drF53JeNpYhDZ4eHWUIrMowT/HJM2dZ97MzCtPUZC2USF9GOjrsuCA2Iii22cVGDQIwK vBISVWbXlgoA8ouvXRwbLDvy283nLkgwx71PblgIB2XWILWnP2xWkajQt/h+plC7D95y FjdnwhvzOgcMXSR4k5qqClhUf2N1H47e69vkiVx04m3dJvnKkC8Rv0IGd0twI/g2+zVs UoLpn8r7CTaWwFu/K+3oWVEEKZ6qKZ+snIrS4DRYxou+zKPr16rK46CPo9OyUuxG9RWh qG0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RYWO8KtUJIsIDUxDsFWpBfStjnUGYpB77rznkweQw3w=; b=eWZNrS/rtNFQDTvqdx6ftCQphWKtMFyf3ekCwF9Fuj9wwbx3JjSHWF1o9GMtn4Xrtj PNYrYXevNriKi1TWjAwVq6eeJ1L1zmcrhYWLv5p+mepY+w+IbhmWBStpU69BQWivYIbw GwBKEWmgo3RzcoegQYeB+Ry5gGlj9xzgVdA9/jVs6PcpScWvq2y1B+hSbggxzgYU2IS0 2Ct1wBCLDuu8BG32He8KNZuE0w2rYEAIcHRXE22Fgp6ZbcVuY9vKaQ40HtE3Tv/EuYyA 99++wxJOplBTtSuEB7yPZjRXUx6AlsrqY7yP40yhWeSd3Irp4uSbxVlw8uV0qgSxYXBn W8Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AR1ByF10; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j185-v6si2150535pfc.186.2018.10.12.12.29.30; Fri, 12 Oct 2018 12:29:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AR1ByF10; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726299AbeJMDDJ (ORCPT + 99 others); Fri, 12 Oct 2018 23:03:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:53852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbeJMDDJ (ORCPT ); Fri, 12 Oct 2018 23:03:09 -0400 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79A1021470; Fri, 12 Oct 2018 19:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539372549; bh=KuMgXPH8usKv6hTV9oS+/nn9FCAXBOXou6iPLt7BfGo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=AR1ByF10kSRYgNFZc9owNvKpxtLrOtiZJDjT1gUfYi2TtiOC5G8R99UL8IVTudifN IhJnKdMcI1EpyYJiX2rV0ZbaJA+euG/Cn2/h+9TB5UlnvwhTXW8F8PNMJGoE38JSF0 04li67/k50xK3G/gyUOiBgSDuwkvD5gtmPAMm9jI= Received: by mail-qt1-f181.google.com with SMTP id e10-v6so15028325qtq.12; Fri, 12 Oct 2018 12:29:09 -0700 (PDT) X-Gm-Message-State: ABuFfoiBDWqxPeFEaax5qHb0xa+seFbU8P3OfaLWkCFHtB/NMkx1x+zS agB4DlU05wbNunrcq4P8GoIX1BiY0k/ZbeXg4g== X-Received: by 2002:ac8:1739:: with SMTP id w54-v6mr6887176qtj.76.1539372548638; Fri, 12 Oct 2018 12:29:08 -0700 (PDT) MIME-Version: 1.0 References: <1bc1488a4cbf21fafc64269958ba3ed04e0a3c1c.1539322989.git.michal.simek@xilinx.com> In-Reply-To: <1bc1488a4cbf21fafc64269958ba3ed04e0a3c1c.1539322989.git.michal.simek@xilinx.com> From: Rob Herring Date: Fri, 12 Oct 2018 14:28:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] of: base: Change logic in of_alias_get_alias_list() To: Michal Simek Cc: "linux-kernel@vger.kernel.org" , Michal Simek , Geert Uytterhoeven , Greg Kroah-Hartman , devicetree@vger.kernel.org, Jiri Slaby , "open list:SERIAL DRIVERS" , Frank Rowand , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 12, 2018 at 12:43 AM Michal Simek wrote: > > Check compatible string first before setting up bit in bitmap to also > cover cases that allocated bitfield is not big enough. > Show warning about it but let driver to continue to work with allocated > bitfield to keep at least some devices (included console which > is commonly close to serial0) to work. > > Fixes: b1078c355d76 ("of: base: Introduce of_alias_get_alias_list() to check alias IDs") > Fixes: ae1cca3fa347 ("serial: uartps: Change uart ID port allocation") > Signed-off-by: Michal Simek > --- > > Changes in v2: > - Use EOVERFLOW instead of EINVAL - Rob Reviewed-by: Rob Herring