Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1300678imm;
        Fri, 12 Oct 2018 15:46:05 -0700 (PDT)
X-Google-Smtp-Source: ACcGV62ppCf7TcQrukYg3yrI1OHHXaX2hRLMUnL41UpOVzDEik4tEw3CbhdWZZgVKYOeQYBjRiDq
X-Received: by 2002:a63:2323:: with SMTP id j35-v6mr7240355pgj.337.1539384365881;
        Fri, 12 Oct 2018 15:46:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1539384365; cv=none;
        d=google.com; s=arc-20160816;
        b=Dl1zArOZC50SrkFRlESaxC5FGAAjmhcL7uqq+YBmSnkValERwX79zgO68IhD8lezUy
         np/qDuM2Rd6OIeW1gfB14wxrWbEEOcP2cTJkmkemCD5y5JiqfZ2TtH++bHD/+U8uaKk0
         f5A45+wFm6HwWnCREguM52Vyfbkoe6OjkgWZh8n8PaGmyY8VWg3nuTUWHygTQNOzhn/p
         yEpGybyiqeLtwHS9wDDleNlNnvpzHSGDlvcQrblEDEa+rHztw7ZlxbqemQDniI6O/H6A
         N19XY2AoFQQOWW6dwUOittVZQStgYBufoEGuj4TksMM+wXUhOxQ6JyRZL7k1NDybVXjm
         Iz9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=HmSvI2dJbJlJCbivHEMd/3Ef67TqPOy5QK9qvRAe6Zo=;
        b=vLhItBg7W0uPwi4HyHpVgkVvI+ZqHb5md0NA43TJfOPqwOFtAv9ru4WIH1mBn6p86Q
         QWSMgW2BakzrYf5egrQO6tyQCp+Wp6e8KOyD6wwqzT5lfunnC4nItwxQHqfE4Egtg9AZ
         MytKQUeiNIGnBVjKyvWJb1H4nFccsB8CnCUwLT4sZlrdfe+GmFsASVV8gZY6/w+n9KS7
         UphgPYEbXDAxLuhl5Nf9PtsyKOwGng/OXC09T7ou2YCa8hBEVKGYDP/8TYhekGR8PZ6S
         2+CdrQJvw/khUIP/AFmYn0YwqLfFltxJm3lzMWmXmuoueNU2+LDY7HqaK2WUHJ8CDFyW
         ASzQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=nT8X6RRJ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id a34-v6si2549356pld.149.2018.10.12.15.45.37;
        Fri, 12 Oct 2018 15:46:05 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=nT8X6RRJ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726031AbeJMGTm (ORCPT
        <rfc822;paul.schmitz.hallo.parkuhr@gmail.com> + 99 others);
        Sat, 13 Oct 2018 02:19:42 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:13316 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725812AbeJMGTl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 13 Oct 2018 02:19:41 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5bc123f50000>; Fri, 12 Oct 2018 15:45:09 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Fri, 12 Oct 2018 15:45:06 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Fri, 12 Oct 2018 15:45:06 -0700
Received: from [10.2.173.107] (172.20.13.39) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 12 Oct
 2018 22:45:05 +0000
Subject: Re: [PATCH 1/6] mm: get_user_pages: consolidate error handling
To:     Balbir Singh <bsingharora@gmail.com>
CC:     Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@kernel.org>,
        Christopher Lameter <cl@linux.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Dan Williams <dan.j.williams@intel.com>,
        Jan Kara <jack@suse.cz>, <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
References: <20181012060014.10242-1-jhubbard@nvidia.com>
 <20181012060014.10242-2-jhubbard@nvidia.com> <20181012063034.GI8537@350D>
From:   John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <090e5019-b1b9-fdc5-73a1-902164400fe2@nvidia.com>
Date:   Fri, 12 Oct 2018 15:45:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20181012063034.GI8537@350D>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1539384309; bh=HmSvI2dJbJlJCbivHEMd/3Ef67TqPOy5QK9qvRAe6Zo=;
        h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=nT8X6RRJlNu+Zc5hraBRbiwSC4dt7Gbo+I9RlOztu+8jOzmKw4I7SG67Ti8t8Qd9a
         +vJMpqGtbwOsjFUGNjGSggK4cmWpgQZOwpPHb7Gjg6UWQVFiVYBy4sXF7r7EyPw/cm
         8Y1yDrdcRMpsRq1ya/lVq3YwN3RXy39Jtb6IGlthBKrOLa8jSL5oUB9XMIl9ZUFJw3
         DWSwgOA5fmR2u8jxD2NRQEB6A0Ir5fD/blUMjDKEl63R5IwyiI1eO8wm2D1uYhnthb
         mxHb3HhB6SgMQdGrKTBTUS0ix7BWbplH/kCem7yGZHRYWFm8MA8F5GlyPWt1G42SYo
         YNrxRkyNzRvTQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/18 11:30 PM, Balbir Singh wrote:
> On Thu, Oct 11, 2018 at 11:00:09PM -0700, john.hubbard@gmail.com wrote:
>> From: John Hubbard <jhubbard@nvidia.com>
>>
>> An upcoming patch requires a way to operate on each page that
>> any of the get_user_pages_*() variants returns.
>>
>> In preparation for that, consolidate the error handling for
>> __get_user_pages(). This provides a single location (the "out:" label)
>> for operating on the collected set of pages that are about to be returned.
>>
>> As long every use of the "ret" variable is being edited, rename
>> "ret" --> "err", so that its name matches its true role.
>> This also gets rid of two shadowed variable declarations, as a
>> tiny beneficial a side effect.
>>
>> Reviewed-by: Jan Kara <jack@suse.cz>
>> Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>> ---
> 
> Looks good, might not be needed but
> Reviewed-by: Balbir Singh <bsingharora@gmail.com>
> 

Thanks for the review, very good to have another set of eyes on
this one.

-- 
thanks,
John Hubbard
NVIDIA