Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1542999imm; Fri, 12 Oct 2018 21:56:12 -0700 (PDT) X-Google-Smtp-Source: ACcGV63BC8jyHCGU/Pu4IT+58i67QDxxfx2sBfJrCVlnLTC5oiFueFIlI0/xX4bq5oZN4FhgHAhQ X-Received: by 2002:a62:475c:: with SMTP id u89-v6mr8882283pfa.212.1539406572221; Fri, 12 Oct 2018 21:56:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539406572; cv=none; d=google.com; s=arc-20160816; b=RzGWrhtz6Aszjllepmx2NiZgyhRPEtEcdS+P4g2OX/tLg4GWwCJfG/1wAWZwXANT83 vY+m0I2YF2dytIqswzf/DTDLGwiJJ+cVnJznfi++q/NaesNY4G0+xs61WbkeJYY0OMfV MmXx0dhkR03VXZhiQi1thRLvbAqJZQXQ0VFGvzWDYUPhlb36YavvVP5l4XOHROiEjzK7 AzLfBx1C8JYHKb2SwFoTKI2M0mTZ/G76P+AvT3LmuiH8DtCtJQimpB3zwFXSSgTXroRc Trl3KXJAQkeI+/vtwFCjbSibQ6hwo278BMaPPO/7/8vU54KdRWF9h087qFcPYEMPvMWF yQbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=M4dGHNWK9yvMCplN74sEUY4ZcqWQ+poGeb6zjVC5TlY=; b=iIZsiR4LL3zfMfdlxua7OHh1R3vYnJL5JKb9QW9tjG5sOX/mAYJsOSc65RVT+50p+j i8K0GiTyFFlBr2I93lxBw+kJm7xiIczK7i9tO6pudki4hMQ40oQoRgO/tjWkNwzvcrR+ IzCYZdlfC0xQcRdzqhnCSfX27Y1zw7YjpEcbE5u9tVLHjY3VGMJHIPpxzj3vy5cGGtDr leP7W8WIYUp4Gm9/S85OYlJsheTK1EjgLtKDQiCjH7ObHSipEXqqbaISaP0koqKnSCHL vYGm0Fd3j836LlePVTDwmfg+mGc3CvmlkqYOk3FTn3yH+QDzjh2vTqTgTB1y3q0Sm99g bkcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=S3o6SlIa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11-v6si3163264pgs.179.2018.10.12.21.55.57; Fri, 12 Oct 2018 21:56:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=S3o6SlIa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727254AbeJMMbJ (ORCPT + 99 others); Sat, 13 Oct 2018 08:31:09 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:45001 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727164AbeJMMbG (ORCPT ); Sat, 13 Oct 2018 08:31:06 -0400 Received: by mail-pf1-f196.google.com with SMTP id r9-v6so7148632pff.11; Fri, 12 Oct 2018 21:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M4dGHNWK9yvMCplN74sEUY4ZcqWQ+poGeb6zjVC5TlY=; b=S3o6SlIagmxnHfGrZI34r2HygKejAau1DPnNDbTQCEXLsdkEHMURCgMKM2hiSXKucQ GPmURtlvC/py9Hvtwx82PdYeCK+1JhVRuCiasUOBgeBJam8O8/kHdDk+qZpNLFJ6qGgk 5RpSRHDuUyi6ebBOsmdfZdUQS4NYZCiUO2hucgejZIIu10fnOjOIIODj/ORaJnMuQcy2 96deMshDa1STmPN/f2GVNywsH2V9RTM32EG/SKy50NZ98vHB+WTp4dHwVC89dWjzlRO7 yHU+n828MdpsXCF2wt/uo0qdzDKQoCt0EUFSnXW4eN3o0NxANyd/a0ZiEfiI981ceyBy NZhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M4dGHNWK9yvMCplN74sEUY4ZcqWQ+poGeb6zjVC5TlY=; b=M//kWHewnTRQn9uuv4WQLgQrAjkoZ2CoWO2xDjmhK+G67gwggE7vclsdVuutrPBrp5 vSnY0EbnO1kxgwpkmGcvTjdZtz3sGLnmklfLeMCOnTEpxGrIPxyHGfw5mEELNwmoTTrw kaEusMLmTRW86y/dLR+mw1daGfZAiy9XLXu2RpybOifhYzgThppAHnIYnek6OzX2xTUG X5/34tssDdaw6oRomW6BQhulUwLrUOij7rBSw9eEM8tqGEveIrNLgMOOKDc/1Qq75rOh GhOWriatslnPqzpovBr6BZpKLL6F3IRwnCgPIHxzMaxHkkyy7fy0c3wYeVxLzbYFMM1b CckQ== X-Gm-Message-State: ABuFfogsZqka7J0Cm1nTU0zOQM5cmdahxYlYatTHsz3xQBn6Ie5jHHIS vqfnWXyIFcCofu2SamsIZk4= X-Received: by 2002:a62:5ac6:: with SMTP id o189-v6mr9102764pfb.40.1539406524814; Fri, 12 Oct 2018 21:55:24 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id h87-v6sm6959462pfj.78.2018.10.12.21.55.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 12 Oct 2018 21:55:24 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH v2 16/18] of: unittest: allow base devicetree to have symbol metadata Date: Fri, 12 Oct 2018 21:53:36 -0700 Message-Id: <1539406418-18162-17-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1539406418-18162-1-git-send-email-frowand.list@gmail.com> References: <1539406418-18162-1-git-send-email-frowand.list@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand The overlay metadata nodes in the FDT created from testcases.dts are not handled properly. The __fixups__ and __local_fixups__ node were added to the live devicetree, but should not be. Only the first property in the /__symbols__ node was added to the live devicetree if the live devicetree already contained a /__symbols node. All of the node's properties must be added. Signed-off-by: Frank Rowand --- drivers/of/unittest.c | 43 +++++++++++++++++++++++++++++++++++-------- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 6d80f474c8f2..1c2bd8503095 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -1057,20 +1057,44 @@ static void __init of_unittest_platform_populate(void) * of np into dup node (present in live tree) and * updates parent of children of np to dup. * - * @np: node already present in live tree + * @np: node whose properties are being added to the live tree * @dup: node present in live tree to be updated */ static void update_node_properties(struct device_node *np, struct device_node *dup) { struct property *prop; + struct property *save_next; struct device_node *child; - - for_each_property_of_node(np, prop) - of_add_property(dup, prop); + int ret; for_each_child_of_node(np, child) child->parent = dup; + + /* + * "unittest internal error: unable to add testdata property" + * + * If this message reports a property in node '/__symbols__' then + * the respective unittest overlay contains a label that has the + * same name as a label in the live devicetree. The label will + * be in the live devicetree only if the devicetree source was + * compiled with the '-@' option. If you encounter this error, + * please consider renaming __all__ of the labels in the unittest + * overlay dts files with an odd prefix that is unlikely to be + * used in a real devicetree. + */ + + /* + * open code for_each_property_of_node() because of_add_property() + * sets prop->next to NULL + */ + for (prop = np->properties; prop != NULL; prop = save_next) { + save_next = prop->next; + ret = of_add_property(dup, prop); + if (ret) + pr_err("unittest internal error: unable to add testdata property %pOF/%s", + np, prop->name); + } } /** @@ -1079,18 +1103,23 @@ static void update_node_properties(struct device_node *np, * * @np: Node to attach to live tree */ -static int attach_node_and_children(struct device_node *np) +static void attach_node_and_children(struct device_node *np) { struct device_node *next, *dup, *child; unsigned long flags; const char *full_name; full_name = kasprintf(GFP_KERNEL, "%pOF", np); + + if (!strcmp(full_name, "/__local_fixups__") || + !strcmp(full_name, "/__fixups__")) + return; + dup = of_find_node_by_path(full_name); kfree(full_name); if (dup) { update_node_properties(np, dup); - return 0; + return; } child = np->child; @@ -1111,8 +1140,6 @@ static int attach_node_and_children(struct device_node *np) attach_node_and_children(child); child = next; } - - return 0; } /** -- Frank Rowand