Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1628407imm; Sat, 13 Oct 2018 00:07:06 -0700 (PDT) X-Google-Smtp-Source: ACcGV61P7WSuIQxNc7xcD9ILvFqL8W+QII+R6Y4Fnet7GoFl4829cZHzPF3tXIhmzZZ6ZktNoPTH X-Received: by 2002:a63:4723:: with SMTP id u35-v6mr7985264pga.95.1539414426823; Sat, 13 Oct 2018 00:07:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539414426; cv=none; d=google.com; s=arc-20160816; b=k33hcB9ppUnIbOz+N0qBrN3JtwZ1BDtJ/2HAruDVxLP9O4Q0rHmAxi33TwudgBuvnI sRKKp0pmAsXNOuvNNCd3Mz41FmosTZajzAdtqx4hBkkc4DCw1nTS60dEBQfQsds4Jewq N5hi3YqD9i+tI6ZaYI0g9FJS2VnCccigl0sOmRhO42is0K2sjQO/dOUJ8gPhAHxB00qq BxiLfWXK+pvZUkMOAs9A4XLYLmcDXy67l8cug8pBLHUVgoqmA86l7Gsjnf/izMLDl39u sNx2PtGa9Csgm2rdKrH9W/RHFKNIAET05pGf5/zCDhxYMJcDpbgwVu8wJRtdnwhMu9P9 kXNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=K8BHExVW3bR1nDzdi6l323qQBna0JsdwY1S1MqiCjsk=; b=Ebuq8W8CtmT77B/9W0xGcZEwLL6AypZs6h9jiaY+4ECuY3P5dkVZEBIJMgATQdBHLX 47XBVgLnRS/JCKVVr5ICyV8Wmx4gpTaPFPEXwitUtAGEaBG5z3ff/+vRx6HMciNzRzzD 0Ee7X2sAHWQzPksvxSZsaTW7hYzHnuxPbM9JgX85XQj5vwrEN8eEw46KhJbjWYj027kI eli41qCNZlwiE4Wu3s3Vuh4z8SnX7+FVsXW4Hzjf7EZIXuKaejLmTqtVblmLfWk9Kheb zwOOVRbn/AY9t/dyI7bri8LWqWioQ/yEFgWofuLAro0yvX4+c/99SprFW5W/TfaMTuqy rs6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=tiiZ1Vn2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z31-v6si3809966plb.58.2018.10.13.00.06.51; Sat, 13 Oct 2018 00:07:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=tiiZ1Vn2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726292AbeJMOlO (ORCPT + 99 others); Sat, 13 Oct 2018 10:41:14 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39106 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725986AbeJMOlO (ORCPT ); Sat, 13 Oct 2018 10:41:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=K8BHExVW3bR1nDzdi6l323qQBna0JsdwY1S1MqiCjsk=; b=tiiZ1Vn2Pg+EZKpUu6R0piEcP 6Pp3PFj8jAciTUi32oxPUI8sF+T6bJEj/Mo6Sr4M6+RRk14ylD4XLpEXegeBp6rJYi1L6hOKpHBIP cz/kWomx6L3j3PGCzNp/oyPY30R6pBr8TXaxZx+8+lRma8iM+9vgB6ELbw10hv5Uklyh67nwAI6dN 81nSQgVy9Ac8J+F7X1HVRzTKyH/4qj8U8sfPGoVA+45GNyN0hsiqgCeBT42SzrpyF5hn+QrWdk2N1 BsSciXAWACcJt6COtWc6lQ5VZglODTnDrb8h82SEmEFz2WTIyXmyfmfefft8d5ZISZTSehVNpcxbA bT982I7sw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gBDz2-0001he-Tc; Sat, 13 Oct 2018 07:05:08 +0000 Date: Sat, 13 Oct 2018 00:05:08 -0700 From: Christoph Hellwig To: Finn Thain Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , Hannes Reinecke , linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] esp_scsi: De-duplicate PIO routines Message-ID: <20181013070508.GA15008@infradead.org> References: <09d3a141dc16af63921f5414263069e9b4f97222.1539391876.git.fthain@telegraphics.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09d3a141dc16af63921f5414263069e9b4f97222.1539391876.git.fthain@telegraphics.com.au> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +#if IS_ENABLED(CONFIG_SCSI_MAC_ESP) || IS_ENABLED(CONFIG_SCSI_ZORRO_ESP) Please add a new CONFIG_SCSI_ESP_PIO symbol that is selected by the mac and zorro drivers instead. > + pr_err("FIFO is empty (sreg %02x)\n", esp_read8(ESP_STATUS)); This should probably use dev_err (at least with my series).