Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1640539imm; Sat, 13 Oct 2018 00:25:19 -0700 (PDT) X-Google-Smtp-Source: ACcGV61ToZdjIbYlG/ofaLEU3kpqp0vSZzOMsTMya9kO1n8nkqjezM1Ku7jvtczk9E15c2YXBdBk X-Received: by 2002:a63:4a0e:: with SMTP id x14-v6mr8288336pga.34.1539415519747; Sat, 13 Oct 2018 00:25:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539415519; cv=none; d=google.com; s=arc-20160816; b=Xy07CA1IZ7R2v5iCys8It1Rl64sED7Nrr33pAkrD6mA6QPgJoZ98z9fDgm9+aSgogv l0Vxd/CWcJXUh7rMHpYFMNQg7b4v8hdk0tMjybd697PMubMGRu/fdBn1hZaSjlWMA7lv 0bpa74isHEoj1tqPnOkEQUH31OgVN9ZVp0POHlIzp29XGrF5+ZVtHsJhEKMRaMv0gxfZ kwbjleVKpMYtIIsYfqH54lbop75TVv82L3AV0u4OBu22D5RYjUHLKcaeOwQP1QSkA8be 3G3iMkuY3Tby3qrW5M6k2E6Y0pMuQ9NdkB/1Ot+yyKYZLMp8OL3A0i6IQHkUxR9uKJ+f EtXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date; bh=zBKQvngcjyqoUlucT5xCbKYMnjkF4uV56aR1rKYJ5XU=; b=zIQMaUK9R9uqKsBiuE41VkdTkQrIoAujDjGUmIj7/T+BXsgOELaV+/615QscaUiBs/ ly2v/kNSqr5al77paJYxfVfoJL3LRcTd1OcSs7yoIJVJdab/6mT6DXKCuCAezWWUczii /WUZIROYbCglbToxBM1BNl1Lkm+wfzrsb0f8APBteqzJjq2s5BfNARrJotW9idH7P12J 3GPfwb7xH6Av5MKVkPpt3JqOoEeqnCAD6OtWCw1p3gkd1HGtSk8RMOTdCCNIWmfhhjRv j50EgnmWpiuM7t/5DPfynu9gf6FwMVx4ljqn6IJdnQ3ryK3Q8tINVt/S0/BRLZ1K9YVG bIOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s12-v6si3722805pfk.213.2018.10.13.00.25.05; Sat, 13 Oct 2018 00:25:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726910AbeJMO6W (ORCPT + 99 others); Sat, 13 Oct 2018 10:58:22 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:48792 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbeJMO6W (ORCPT ); Sat, 13 Oct 2018 10:58:22 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 94C6829E16; Sat, 13 Oct 2018 03:22:17 -0400 (EDT) Date: Sat, 13 Oct 2018 18:22:18 +1100 (AEDT) From: Finn Thain To: Christoph Hellwig cc: "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , Hannes Reinecke , linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] esp_scsi: De-duplicate PIO routines In-Reply-To: <20181013070508.GA15008@infradead.org> Message-ID: References: <09d3a141dc16af63921f5414263069e9b4f97222.1539391876.git.fthain@telegraphics.com.au> <20181013070508.GA15008@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 Oct 2018, Christoph Hellwig wrote: > > +#if IS_ENABLED(CONFIG_SCSI_MAC_ESP) || IS_ENABLED(CONFIG_SCSI_ZORRO_ESP) > > Please add a new CONFIG_SCSI_ESP_PIO symbol that is selected by > the mac and zorro drivers instead. > OK. > > + pr_err("FIFO is empty (sreg %02x)\n", esp_read8(ESP_STATUS)); > > This should probably use dev_err (at least with my series). > How about shost_printk()? That would be consistent with the rest of esp_scsi.c. It also means my series need not depend on yours which would complicate things. --