Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1834435imm; Sat, 13 Oct 2018 05:00:25 -0700 (PDT) X-Google-Smtp-Source: ACcGV62BOG+9tRfgs+vd1+lCz4t7kbwVMr97uOUeADov+THebobIvuyFx16Sskw+6KNtBQMBua2h X-Received: by 2002:a62:2315:: with SMTP id j21-v6mr10068665pfj.90.1539432025162; Sat, 13 Oct 2018 05:00:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539432025; cv=none; d=google.com; s=arc-20160816; b=dc27M9zh2Jx0q+k8CMetGNheXLKrl4YJW17jA6n1VoD4+H55y7tzC6hX5dIlPxKk75 OII37RPCI7sZROG50cr2ncAFokClHeWqQNcaS5KTHRLhY2XHzCyzcqY7Ks83fLtOfUCp F4ea8RN0uV39Ht+z6IbxXyHxngQPRuSMTf/Ms7gmxe9fvMX1sWnc9rrT4KpXmMtHoc+8 N6drmSX+yw7DXM9ELS4rW+bIdmgX6PjKnf3K610B/4d2QlFFstNUXOBYc3lV0vbhJuBX YW+5c98uxUqGgAcxqBLXd5lvWHi0wICHC8sp0fLXsPGMQrSoqyjBp5Iim4BrPjcstL3e +fAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=1Ov/fTDd3bUTzVe9QxS24YFpeqUwDlbDUMmqngl08bU=; b=08cHfYboN5piKc7vYlLDMdRp2uDebSa2TyXTsMILH9xTunUyT7nmA4ZG4lC6RllBa9 Ud9pUmYrQ3cXXT0l+x+Jc1ygwdjxIez+jThlD+4izRGqQHRHBQEes1UFKlsSJ8lKjuY2 iekmmtWys8ON7OLNlyA1YwbkN8HY7NmgE7XX0M/42VqnTVrqNu+xvci0rEqH5iI6ISR1 4NmNscZpFdYBIAm1uopnRFFNdCViOh2DzLobOUlf9duhD2UFPWqNzoPH47KJLteveOkt VXY9qhe9kteZDhb6TAmkYOHoV4gR4b/ARnIuKsxGKD8/pZxOTdPrPN8lHbUgabasOC94 Ltsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Mg2jSNPt; dkim=pass header.i=@codeaurora.org header.s=default header.b=TCJWBTbp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2-v6si4643245plm.25.2018.10.13.05.00.10; Sat, 13 Oct 2018 05:00:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Mg2jSNPt; dkim=pass header.i=@codeaurora.org header.s=default header.b=TCJWBTbp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbeJMTgk (ORCPT + 99 others); Sat, 13 Oct 2018 15:36:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39960 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726033AbeJMTgk (ORCPT ); Sat, 13 Oct 2018 15:36:40 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 230CE6072E; Sat, 13 Oct 2018 11:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539431988; bh=+xHzGxZ1lcEIR2p7HkOWM+n8eAsYmTvoGX8NFvZ3O+c=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Mg2jSNPtdxAY4xJNqqnPArowO/FKK+/UhnkP7ux58tV3GK9QanzdEWGNcXaxOEz8o V258JeN9dTNhc8u4HS9c72ofDJasFN8tbodHm0+JoFVqvtO5WGr4vT+aPvASTV8+xE Bk+TPH4DOcWwWtHvjIpUz4NDybjfl9DTKJ09LI28= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-228.elisa-laajakaista.fi [88.114.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7D035601D2; Sat, 13 Oct 2018 11:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539431987; bh=+xHzGxZ1lcEIR2p7HkOWM+n8eAsYmTvoGX8NFvZ3O+c=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=TCJWBTbp4fE5K8jnIIM0zUAIU2qRKDw3z6ScK7sFMiO1udDpnzopEO/l6OdYcZyk7 qvcDG5rwrcWoMuNypDsZDfStIC32G/mVRBz8L8rvMUf2cs8dxibY9xefAhe25eVGmN Lov+aRrj77HzhqVcIax/VDby+8gD/1sqA6jt2ZRE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7D035601D2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: rtl8821ae: add in a missing break in switch statement From: Kalle Valo In-Reply-To: <20181006184246.29985-1-colin.king@canonical.com> References: <20181006184246.29985-1-colin.king@canonical.com> To: Colin King Cc: Ping-Ke Shih , "David S . Miller" , Larry Finger , Tsang-Shian Lin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20181013115948.230CE6072E@smtp.codeaurora.org> Date: Sat, 13 Oct 2018 11:59:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The switch case RATR_INX_WIRELESS_MC has a missing break, this seems > to be unintentional as the setting of variable ret gets overwritten > when the case falls through to the following RATR_INX_WIRELESS_AC_5N > case. Fix this by adding in the missing break. > > Detected by CoverityScan, CID#1167237 ("Missing break in switch") > > Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver") > Signed-off-by: Colin Ian King Dropping this patch per discussion. Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/10629291/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches