Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2598668imm; Sun, 14 Oct 2018 00:03:23 -0700 (PDT) X-Google-Smtp-Source: ACcGV61UoOXwULhT6MwC8IgZwj8Hrk6SavZ2HooZQsTRO0byxZKqHYY66LBs+OZVX1N4xlYCEheL X-Received: by 2002:a17:902:2f41:: with SMTP id s59-v6mr3127456plb.277.1539500603235; Sun, 14 Oct 2018 00:03:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539500603; cv=none; d=google.com; s=arc-20160816; b=NUDI8LgyQYH7i248FRZxI0cwq4qH2LuNCkj50dyN5BsFTCpbm8t3fT+WuTKm8ySgI8 +88A5SHzHn/xfC7424A3RoXy5tIOTu1bDAXpRnsVZLfY4hmJkdlT5+10sXv8ow/C3CTL 0tigU6Q6s/Ll/M3m0YQYfSb5wrbo0nwbAonKuSp/PuEdvreuJfYLELXX/AKGBFCln4NJ Er9dLkSmKWwvK3aoyy25+LguBHgWtTzUMUp+VWUfsj3X9ziAE7IIXTigz5YNHXxfNxp/ V/uJY60liwOcKPGeSZPFoc1U2cLEuxi/TLErMK2XnTYywsMWCAQ1QoydtMiEZA3rEHIn V2Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=Yhm8RPlGpaOB8AVNm13k9NOvofXAHlH+jVyQCuvbBbo=; b=iMa90TE20hR3kE3nvlUz0FMryEpZ8o3nLX3NNRz73dyuAIGZwudaPTBwJExz8jOvzo wYYd+O0EifJTlaZEHAJrz4nMocp4mLa/AYMTu3NNcmphtmMRXR5TX2W5Zi3XtwMFW84H tIDKit6XpsCT3sKFlCl/OJHNu8QSkpWnQ0ulyME3h1kisMhYoqP0lgZ/4k6V9i8bU9hK pBtUzCrEz/0fqppn+GfUa21gvlggJOlUgdB0aNIA1OGdyW19wM3GYsuTL6ymbhWL33T9 cQmu1afTIvSPLHiVH5ez5LO1boYi4SWzbR61hU+6EigaqA5ob/QqZUs+rJWABz5TJWSY y9SA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i25-v6si7131458pgi.426.2018.10.14.00.03.07; Sun, 14 Oct 2018 00:03:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726421AbeJNOmt (ORCPT + 99 others); Sun, 14 Oct 2018 10:42:49 -0400 Received: from ozlabs.org ([203.11.71.1]:35807 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726356AbeJNOmt (ORCPT ); Sun, 14 Oct 2018 10:42:49 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 42Xsw54Pw9z9s3Z; Sun, 14 Oct 2018 18:02:45 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Christophe Leroy , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Dominik Brodowski , Geoff Levand , Jens Axboe , Kumar Gala , Li Yang , Nicholas Piggin , Paul Mackerras , Scott Wood , aneesh.kumar@linux.vnet.ibm.com Cc: linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap() In-Reply-To: <87d0sd19vm.fsf@concordia.ellerman.id.au> References: <52bd80b06bae0d854d04501e1e136575b77fa9fa.1539092111.git.christophe.leroy@c-s.fr> <87d0sd19vm.fsf@concordia.ellerman.id.au> Date: Sun, 14 Oct 2018 18:02:45 +1100 Message-ID: <87a7nh104q.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michael Ellerman writes: > Christophe Leroy writes: > >> Set PAGE_KERNEL directly in the caller and do not rely on a >> hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. >> >> As already done for PPC64, use pgprot_cache() helpers instead of >> _PAGE_XXX flags in PPC32 ioremap() derived functions. >> >> Signed-off-by: Christophe Leroy > > Something in here is breaking my p5020ds (both 32-bit and 64-bit): Oh duh. That's because I didn't take patch 4. It didn't have any acks, but I guess I'll just merge it rather than breaking things. cheers