Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2974449imm;
        Sun, 14 Oct 2018 08:48:43 -0700 (PDT)
X-Google-Smtp-Source: ACcGV63EzXDGfVP+BIz71yofTUBucgV3RtFeqixCdJR1dchiHN8Ry5MEOegqKRBCpCpLbZv7G69C
X-Received: by 2002:a65:64d5:: with SMTP id t21-v6mr13074323pgv.428.1539532123027;
        Sun, 14 Oct 2018 08:48:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1539532122; cv=none;
        d=google.com; s=arc-20160816;
        b=ASEjfdMtYDJoC4kunl0ugEA8lz8Grl/Vx68H7VMGbOEn01HY6WryuhcN04MqjfN0pe
         aDJ8mdfRdeFCIAUmvkJ1JtHnkdQL3zz3ixJZMp6bKUDqz1BIRp/x3LsKXuHyhdYrBwOb
         ugqostYB9q20/AGMrAfmMX8gvcfK2Xvc2S35rXPFg5ZqLtbt9/9uiIWCQ0uxkPd7gxbI
         BVNac78Fs+Aw7B/cITRZt9AMGXiv9loRblRB4T8L+6VjcBqeayr3tk/UNaG0ErY2ep5v
         IjfBB7/578sMbPHd3o/GBOXkk9VM8c9AfV10C/vpqELObIJah2LfoqpqDmcZarmh2EyS
         Kvog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=0lRLoKpiIc+IKNfb3idhqj+9RVOQ3vYZdWGUekhyeLA=;
        b=C6zjLos0oNkac7YjPaFe1nefLZfj0g3IBU/mYj4v19LTnv8sMo0lMtHUbIVRuAOK2t
         DvI3lO9LhFTff4I6dCas6uooz5gljOX7W8ISuC3h1ep5p55pVBYjtSBe9oKwgoQGaNIO
         F8q2aQnG9T+q3ZyitmmuiEuLA/bNEPEBRLFRuqiqLihMf5g+Kwzq88OPcwC6LeTwy+2u
         lXwvkU6GvtAJmjJpddFY6n4ioCEdTYEdw9Xdk/rC2ExAAMJXFGc/ZyUtktXG2pZoIhZX
         WnsRndgYfa2czT/tQgMhIRNA1DwV6UzfoOxA405kTbWWvanRlfC7PjcSP3iWLApLOGDh
         vtpQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="n4U0l/sN";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id q1-v6si7581541pls.17.2018.10.14.08.48.28;
        Sun, 14 Oct 2018 08:48:42 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="n4U0l/sN";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729269AbeJNX3W (ORCPT
        <rfc822;paul.schmitz.hallo.parkuhr@gmail.com> + 99 others);
        Sun, 14 Oct 2018 19:29:22 -0400
Received: from bombadil.infradead.org ([198.137.202.133]:46402 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728125AbeJNX3W (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 14 Oct 2018 19:29:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
        Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
        List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
         bh=0lRLoKpiIc+IKNfb3idhqj+9RVOQ3vYZdWGUekhyeLA=; b=n4U0l/sNNp57FDNvHzTUQgX64
        ROMbhrCQD5USUdUW1KdGD3EJ6cePCuUXCBA4nyqysNVSz4qsZBc4QRK390S+h10qtvmtYBXbisiAH
        LmP7jYF3Lu0cNnqHUban7atbdx84jF5wPXVKazuRjY2cRqXePsLioiCMAsxGF7xJs+GX/qD9kyVi3
        r3uiYZrDdOGZczMYSSO9bFPP3v222amUh5JZiI20Mf9iNYJA+9f9dkTGshINjxsPW/g/yY4Bq42oc
        K/+IN1doutJufkjYfslnHdkNUIiQpq72glp4Lo+I+AZPxjYOVhc23bjcTMv/jpb2EsMMctmTFapOy
        7sVP3opzA==;
Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux))
        id 1gBicT-0006GM-NL; Sun, 14 Oct 2018 15:47:53 +0000
Date:   Sun, 14 Oct 2018 08:47:53 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Finn Thain <fthain@telegraphics.com.au>
Cc:     "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Michael Schmitz <schmitzmic@gmail.com>,
        Hannes Reinecke <hare@suse.de>, linux-scsi@vger.kernel.org,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged
 commands
Message-ID: <20181014154753.GA19252@infradead.org>
References: <cover.1539497520.git.fthain@telegraphics.com.au>
 <91b9ff9fc19ba40e3a2562171c8cd78a2ce7dc79.1539497520.git.fthain@telegraphics.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <91b9ff9fc19ba40e3a2562171c8cd78a2ce7dc79.1539497520.git.fthain@telegraphics.com.au>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +	*p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun);

I think lp should always be non-NULL here.