Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3107334imm; Sun, 14 Oct 2018 11:48:24 -0700 (PDT) X-Google-Smtp-Source: ACcGV61e4PHnvIwDbtTzM2vl5qhB2etQGpx+VWHdfyUfx0cmOJiIKdgIVqy1T9vF202wryulyGrt X-Received: by 2002:a63:d30c:: with SMTP id b12-v6mr13277658pgg.61.1539542904290; Sun, 14 Oct 2018 11:48:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539542904; cv=none; d=google.com; s=arc-20160816; b=Vycg7QokJZxo27S3P5J2SJCgmExWPswCx3RxBu9Bl+URl7hpdB/g8jG6CTsVaxrW0I KOvgKKb9wk0zgGgm9/pvuoUDCCtrUs1Qqw4Z98GWchqeviw9pJ6yay3yLgC5jdtrY3f7 P7mo3hzZibnJDBpCV0te8w8N0qmKoZzU0GLEz3TyqBEJID8k+TqHBbKJnFxDN3zRa9B2 UZCXTgM8wFt/RJ1yRRcbBrnq7JzTaCweT0Zk8w3mD7TS8Q54YxxhJhwnvciH1OeuDz4P bhy4p1SaIwIDSvTeC4XjNqOvRYnxGJUeXBpTv100FKaN3MkIR+eY1MYXnbvn6cZV+FbQ erbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=u+FUqAoADsF0BK8A3lm/30ELPhG87cMlnBh1WBsF4gs=; b=vm/EQL6AtnKuHi2AMuktZi3Kdfhgksu3iiNbgiMB4lWcGO6KxEgh3F+PtVxVZkQDHG 1wQOuRKyKw0ECTZWD1s9MNG+oVDIi0xVZWApfII1gXm3GqswWtxuKGmEp+Hbz3C7ifPs yy2TSld3jYgv2Fg/AlIEPwn75Lrta+NbzliieDeQGaIzGMO2I8O2FTkcwXBlJH9mWQyE +2D79NLQGKbT+3YJ8P3iV7QEasYczRmgngGJTyghhLHMkXvd0jKIiMFMGPJNHR2MbVro YZkht8fladMhEQi3mHR717uZddPrXEjNHyq/KGmpi9nLLOTojd+i8wGuTg+Kab4P1hXZ L93A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d185-v6si3945938pfd.260.2018.10.14.11.48.06; Sun, 14 Oct 2018 11:48:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726499AbeJOC3k (ORCPT + 99 others); Sun, 14 Oct 2018 22:29:40 -0400 Received: from mail.skyhub.de ([5.9.137.197]:48120 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbeJOC3k (ORCPT ); Sun, 14 Oct 2018 22:29:40 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PPG9FzMzDT0Y; Sun, 14 Oct 2018 20:47:42 +0200 (CEST) Received: from zn.tnic (p200300EC2BDC0500329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bdc:500:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9873F1EC03E3; Sun, 14 Oct 2018 20:47:42 +0200 (CEST) Date: Sun, 14 Oct 2018 20:47:35 +0200 From: Borislav Petkov To: Uros Bizjak Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: Use assembly instruction mnemonics instead of .byte streams in arch_hweight.h Message-ID: <20181014184735.GC7667@zn.tnic> References: <20181014183510.18908-1-ubizjak@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181014183510.18908-1-ubizjak@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 14, 2018 at 08:35:10PM +0200, Uros Bizjak wrote: > Recently the minimum required version of binutils was changed to 2.20, > which supports popcnt instruction mnemonics. The patch removes > all .byte #defines and uses real instruction mnemonics instead. What is "real insertion mnemonics" ? To me it looks like this patch replaces our defines with binutils' defines and frankly, if it ain't broke, why fix it... -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.