Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3176423imm; Sun, 14 Oct 2018 13:31:01 -0700 (PDT) X-Google-Smtp-Source: ACcGV610uhISV0FTtbsikn/qHZ3ox8mhSkQpsH3TD5XYojdihZBnPjqI/ODuuoQqEXVDUoch+2HR X-Received: by 2002:a17:902:507:: with SMTP id 7-v6mr5740545plf.272.1539549060946; Sun, 14 Oct 2018 13:31:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539549060; cv=none; d=google.com; s=arc-20160816; b=e/MQCV3JwyJHeTe+aDj1o39Z4fsV8oyI3SUlRiU6sUDXAsDOvaqUuWPM2Ddb/vy4P4 sGd2MdyUvkA0poBbv2g33JdNCRlTBKm181LrcoB5xvO2QcdZRhrHlop/sX602yGYhc55 Ou6X6iLMR5D17cS108gPpnPgv1i3+Wtri/muCojZ6cF/voJPlfq7bIleZTZnMcxxU65F 65ynhewbvKR05JjTSVhl/MzYELbBqGZuGH+5UQBx6J+48YY5ZjpQ+GOJNfwMRkiI/H56 v4Z2JevcT4jq+1aK/ORr+WOHwVxlLe9SIFIWZ0d5kikxDZQuAQwqqulMrC9Sy1sB5yfP RlvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=9ogos7gZwE4YjepCHPJn6atiIoqEZ4cLfdc7jhqnqAM=; b=hzECmxX/C7678pljilR7L/obxq+YhH+sfbOanATrFxqfFX5oNms8TuYY/wwOJxdQph BMhgWaekKmJDLOKlqKxlvG2biP2qU0iOtrJKZ50ZLGe9enPjx8W8EQQ2TfrRGnkZf9yB oYnjW6Z8QhR97ilP+n/g2w79WQuX3wb11SoX0coQplQiHYFzWCyPKnIGmG+XYoXwNgIJ PTnX4R8BLP2Cp8f72dOquSMWkh+RhPTSkszX0/35pyj7WB2F3CZ9PPkAyPh1rviLhT6f ljeSPS114RwI1NLLeab3xc9JDYa5WmRwwepE4W+HBOCbyO9+prpLLHjF9p0k8HOOA91S oG8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x68-v6si8379041pfc.205.2018.10.14.13.30.45; Sun, 14 Oct 2018 13:31:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbeJOEMg (ORCPT + 99 others); Mon, 15 Oct 2018 00:12:36 -0400 Received: from mail.skyhub.de ([5.9.137.197]:50666 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725722AbeJOEMf (ORCPT ); Mon, 15 Oct 2018 00:12:35 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3eSO2nYBWR-m; Sun, 14 Oct 2018 22:30:23 +0200 (CEST) Received: from zn.tnic (p200300EC2BDC0500329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bdc:500:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A2B831EC0987; Sun, 14 Oct 2018 22:30:23 +0200 (CEST) Date: Sun, 14 Oct 2018 22:30:22 +0200 From: Borislav Petkov To: Uros Bizjak Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86: Use assembly instruction mnemonics instead of .byte streams in arch_hweight.h Message-ID: <20181014203022.GF7667@zn.tnic> References: <20181014202354.21281-1-ubizjak@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181014202354.21281-1-ubizjak@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 14, 2018 at 10:23:54PM +0200, Uros Bizjak wrote: > Recently the minimum required version of binutils was changed to 2.20, > which supports popcnt instruction mnemonics. The patch removes > corresponding #defines that implement popcnt instructions using target-dependant > .byte streams and uses unified instruction mnemonics instead. > > Tested by building x86_64 and i386 version of the kernel and comparing > objdump dumps of the pathced and unpatched vmlinux.o. They were the same. > > v2: Update commit message to emphasize removal of #defines. > > Signed-off-by: Uros Bizjak > --- > arch/x86/include/asm/arch_hweight.h | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) Thanks. But with one week before the merge window and this being not nearly urgent, it'll have to wait for after the merge window. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.