Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3272126imm; Sun, 14 Oct 2018 16:06:18 -0700 (PDT) X-Google-Smtp-Source: ACcGV60RRrCvAsBlsJwB8ADDqAafzbHtcAvr0g0laeyTCcuZot4lF9LS7c0CTezUexEXaod0duAo X-Received: by 2002:a63:608c:: with SMTP id u134-v6mr13548664pgb.266.1539558378747; Sun, 14 Oct 2018 16:06:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539558378; cv=none; d=google.com; s=arc-20160816; b=rK+dnZI38VmLYuNeJplasCsYp0Mr2IQ7pNkQiz1Kc4seCUQ/8l9z03oFHpWyPWyJXV Z35+AYq2IHlBcZuXQ0K/9lXPviIA4uGYvO9brY5L22GYb5KZLfFKa1fRbNtxf+WEryPz +dCxCjT1zIaVKvTV4XARVOaY1PhMZDww4cuzi7NXWC3pD/JVRkHL8HZiBwPXsK+3wJ36 GYnGgUrEOhGFhq2Kd/lyCKHPI/03cb/IQUtVlJs2WXwbbgO5LPYz7HqsQDikfUQrKl8Q FphBofY2TNz84yYzGJT1a7pOw+zgpRnBYQbSvc0Ju7Pc/+3ZoJGqpUJBYaVHqrndl/z2 Tc7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date; bh=68PgAccbL5IYr0AR1uVX8cYvk72amhg0EfEyADQpyts=; b=U+9U8XhWEI6NuP4qZSNvRIebaQOq1wnuClgSVTdvib1E6hcEMJ7v5Vsn6fE4cnKak8 OLNGO+kgcTBkDA4PayDNiAMNsBakTFpJg/2BZqygVxaU/SKw6WTk+mjI6oH6YUlQOdvd gHKml7qSO45ew1PKImSxtFNtHGQAwzIIrNJuhIGSKo9EDVitLdrob1BV8FrCJrfuwYrc adstkfdw6glTvppiIklEowMDirVZme/3o7cyOeUqSP5Ki2lpBWUtGyvEs2/pmS72o9r6 VhEr0lSCldJm3hJcXb07HqxPWct+iwYsQ6jzV9/3cvLgdE5PlQxGTdUGfSX5As7oEbSl 7UWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i21-v6si8898094pgh.53.2018.10.14.16.05.31; Sun, 14 Oct 2018 16:06:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbeJOGrK (ORCPT + 99 others); Mon, 15 Oct 2018 02:47:10 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:59480 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725722AbeJOGrK (ORCPT ); Mon, 15 Oct 2018 02:47:10 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 20ABD22C30; Sun, 14 Oct 2018 19:04:29 -0400 (EDT) Date: Mon, 15 Oct 2018 10:04:27 +1100 (AEDT) From: Finn Thain To: Michael Schmitz cc: Christoph Hellwig , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands In-Reply-To: <4719e984-2c7e-33e1-6e7c-16dea5d4f610@gmail.com> Message-ID: References: <91b9ff9fc19ba40e3a2562171c8cd78a2ce7dc79.1539497520.git.fthain@telegraphics.com.au> <20181014154753.GA19252@infradead.org> <4719e984-2c7e-33e1-6e7c-16dea5d4f610@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Oct 2018, Michael Schmitz wrote: > > Do we really need to make that distinction? > esp_reconnect() dereferences lp, so !lp has to inhibit disconnection. At least, that's my reading. I can't see any other reason for the lp conditional. --