Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3322423imm; Sun, 14 Oct 2018 17:28:01 -0700 (PDT) X-Google-Smtp-Source: ACcGV607mwG3AlWfhaJnloh7RMoLaxggULTv0yJ16uIvRM50QkElPMRw0d6aKYNEvARWtyU5qKRZ X-Received: by 2002:a63:fe13:: with SMTP id p19-v6mr13843099pgh.265.1539563281797; Sun, 14 Oct 2018 17:28:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539563281; cv=none; d=google.com; s=arc-20160816; b=SuYK6lW8RtQC73URc6trWL3TTBMR0GQl64BXmgfscxoT7QlUNr8L0OkKRXxJ+kkvzW 8ooosshmk86ydTxt55zoEC9fUncNUzMpf2x2yyVtWQg0AtWjkj+ER2aoAt4kCBI/ClJk ApNEDVZ8CmwN6LrsHEMsoWAQoQSuZ6DzetmEXrnzk4a86N+VypbT5q9mYb1uwlqlWRCN O0a84f0cdV7gkgvwKIpThGeFdHBf2K6yNUFeEWObv5VYYv162WzDydXhow4q2VEZqprF cn6iKge/fzz0Wj4mOSaaSIZ+NypjUtUoLJubFDRmFaXNyR0CShEdxEk/t1mdLxym4BV4 b7Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=BwKhWXvi9uObifIA2caG7KxBnrbJ0SRY7Oj5Ow4g1sM=; b=kd8SMivBvBIUezxfmESNk0TnsjPmkZchtAMRtcnEdl2uOvfV0HYV6TfmxtJ0u1qdkp SoNYfafUPsC4CAAaeICNXNLpPDNXo3EisSjxN4+xOzXyR5H2VE1/cKx5Fc9+ClXKJTtk gU0wyfiT4kYS5WO5/r3vCrlUDBD96xT4PcvcPpCog/UZnPxQrzUZ8y82OK38wsZeq/Fy DCphcpLK8WZP5FTA7K6++a5xlzyM90xAML4g1BhbGiaxwuyvbDBodIUcukmkPUM354oe 5P4jO/1Cj76d5FAdCb3yrm/bXAHOwIaVvOWYSZyTsD7gWTgWpZwZmQIYoSAsIW0IDCM2 HEhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IbdZSPqR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 23-v6si8473105pge.453.2018.10.14.17.27.47; Sun, 14 Oct 2018 17:28:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IbdZSPqR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726827AbeJOIJB (ORCPT + 99 others); Mon, 15 Oct 2018 04:09:01 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:43004 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726541AbeJOII7 (ORCPT ); Mon, 15 Oct 2018 04:08:59 -0400 Received: by mail-pl1-f196.google.com with SMTP id c8-v6so8389383plo.9; Sun, 14 Oct 2018 17:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BwKhWXvi9uObifIA2caG7KxBnrbJ0SRY7Oj5Ow4g1sM=; b=IbdZSPqRTU12HVAPHQC4U1kmpBQ/wG7dpte77EPwS66x6e8kFeTncfdzvPTuAGU7J1 JtsvQDXItXJDfO7QBnceRhyyxDm7Y1LxQtK+TQ+MlS+z9Iafk8rDkv44qeORwZE4YwIE AAlKpJpIjxY9kbWSxyZ33822j2MVCqBhTOPsy3+6Xtk0jxO+jXp7uAo8nJHbduiRuM5S eTTsVtkeVoVilYKVoNFrGRPIix+27qVqMyOYbadmOVqVXplefpDodNy0CWfnVoVU6NtB cjXugPeUdfm4jShYIhwELZyBoDSlmWLma0bPKcDnRiNkkGMFaXD2Ge2qV0Vl576JB26p e9uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BwKhWXvi9uObifIA2caG7KxBnrbJ0SRY7Oj5Ow4g1sM=; b=LXsiSTbOYT/rwMYnbAdnfhjwHPHrUJAic6jEABcn7omAIPzuArvoW/Kk+cg4wxpwWD wXm+STBgTHZVrW4xNO09PARBX5NBPnnOr0pmv4ENnnykZ6suu6tm+GkiEH+EbIZSSyoc GGvBagu5YWwnKNny2a+mUIc8v+n/mVPdtX8qUBJIVugwUGC4ydeYkz9VkwNgXYhQAP4X DBaDZnj3O3BIn0RcZejJ9t1ehmZcui1kjaWMqfw6WLxuKsFV/8910wjji72+yq45frIm b5gY/BeKcuzThbZwlhyFBGvAeMJhEFwRKtdtDDK9X+nndIbSaT42hdzzG1nwY4M8VkWP fNhg== X-Gm-Message-State: ABuFfogsRv2mQmUVBZ7i6BRA/g3ZdTG/udYcSyYsNS5JacQPUkSQIRwX hZf8heM+Nj/IjLOr0SwrZtY= X-Received: by 2002:a17:902:1129:: with SMTP id d38-v6mr9609107pla.270.1539563171237; Sun, 14 Oct 2018 17:26:11 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id j14-v6sm11387110pgh.52.2018.10.14.17.26.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 14 Oct 2018 17:26:10 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH v3 09/18] of: overlay: validate overlay properties #address-cells and #size-cells Date: Sun, 14 Oct 2018 17:24:21 -0700 Message-Id: <1539563070-12969-10-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1539563070-12969-1-git-send-email-frowand.list@gmail.com> References: <1539563070-12969-1-git-send-email-frowand.list@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand If overlay properties #address-cells or #size-cells are already in the live devicetree for any given node, then the values in the overlay must match the values in the live tree. If the properties are already in the live tree then there is no need to create a changeset entry to add them since they must have the same value. This reduces the memory used by the changeset and eliminates a possible memory leak. This is verified by 12 fewer warnings during the devicetree unittest, as the possible memory leak warnings about #address-cells and Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 38 +++++++++++++++++++++++++++++++++++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 272a0d1a5e18..ee66651db553 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -287,7 +287,12 @@ static struct property *dup_and_fixup_symbol_prop( * @target may be either in the live devicetree or in a new subtree that * is contained in the changeset. * - * Some special properties are not updated (no error returned). + * Some special properties are not added or updated (no error returned): + * "name", "phandle", "linux,phandle". + * + * Properties "#address-cells" and "#size-cells" are not updated if they + * are already in the live tree, but if present in the live tree, the values + * in the overlay must match the values in the live tree. * * Update of property in symbols node is not allowed. * @@ -300,6 +305,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs, { struct property *new_prop = NULL, *prop; int ret = 0; + bool check_for_non_overlay_node = false; if (!of_prop_cmp(overlay_prop->name, "name") || !of_prop_cmp(overlay_prop->name, "phandle") || @@ -322,13 +328,39 @@ static int add_changeset_property(struct overlay_changeset *ovcs, if (!new_prop) return -ENOMEM; - if (!prop) + if (!prop) { + + check_for_non_overlay_node = true; ret = of_changeset_add_property(&ovcs->cset, target->np, new_prop); - else + + } else if (!of_prop_cmp(prop->name, "#address-cells")) { + + if (prop->length != 4 || new_prop->length != 4 || + *(u32 *)prop->value != *(u32 *)new_prop->value) + pr_err("ERROR: overlay and/or live tree #address-cells invalid in node %pOF\n", + target->np); + + } else if (!of_prop_cmp(prop->name, "#size-cells")) { + + if (prop->length != 4 || new_prop->length != 4 || + *(u32 *)prop->value != *(u32 *)new_prop->value) + pr_err("ERROR: overlay and/or live tree #size-cells invalid in node %pOF\n", + target->np); + + } else { + + check_for_non_overlay_node = true; ret = of_changeset_update_property(&ovcs->cset, target->np, new_prop); + } + + if (check_for_non_overlay_node && + !of_node_check_flag(target->np, OF_OVERLAY)) + pr_err("WARNING: %s(), memory leak will occur if overlay removed. Property: %pOF/%s\n", + __func__, target->np, new_prop->name); + if (ret) { kfree(new_prop->name); kfree(new_prop->value); -- Frank Rowand