Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3323436imm; Sun, 14 Oct 2018 17:29:55 -0700 (PDT) X-Google-Smtp-Source: ACcGV62677IaJXPR3ErBvW7L22ieIqEcIm9UQnaajWeFdZJkJ3CKbBxGbd8DO98BPwoqyt232rFG X-Received: by 2002:a65:668d:: with SMTP id b13-v6mr13822157pgw.163.1539563395504; Sun, 14 Oct 2018 17:29:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539563395; cv=none; d=google.com; s=arc-20160816; b=sxaRJrJswxCCPQg+a3OVUqAgE5oi0ooA/IP1e6dfLtNNFR9kZocqbOuSYFc8v5lxyM 3jsfj9WS5wguW5r5OapEg1tcwk8CQL1Nsnhp93sBGhD9TqL7jGDYSLWaA3xi8qkDBflY 9xlEKHdomf89VQkUkXlfQVLc0JzUHZV6eCeTyANAFmy0ZlU4QzCiTLqVN6vEamDsPFwT Ru2dDv7C1mJ9klv+qpf2484SiG0ee12O63zBUU7kdFerNdgHNXh8lNJbzgYSSp8B28m4 HGoAxk5yToX9ZVzCS5jdeU1YxEFes4wL44u80BCQxeNeE6TLcAdEagcplpHAIhz3NFF6 Kxvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=uQ0FyqUpesMBzjf7/OI8xWcjm3RFtiErVhhCpWTGBY4=; b=vwBdQ9AGQRDilqypt4cR3zFVLOSxMbL5+DSkPn6jIqLGUDrn6UcZmvepX69i8CZtG+ vn+pUTJJUkeYnM4axOQuuyphkJPEcO0BuYLg8Yyb9tEVl/EMQ/XuhruhmXxDFPSThK/F aTXNBTJ+3Plhjq/MEUex8p1JNrHTn0S+Y5M3paFajyOB4cx0hzIwcXEnWwAXJRRHZJeD 7444yGeWqWP3LaJuaUznMQq3RpkbfZs8Oim1dttcd/QpKdSzNpM35cy7S7xJLGw21qQW Njnhxlv29rVt6LilW9WhMiQDms+5psjC8lX3+6HxFugMozZ8rr0mNxmBG5LUrjpaI4rc SDSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Sfx3oawF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 190-v6si8756433pfc.95.2018.10.14.17.29.40; Sun, 14 Oct 2018 17:29:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Sfx3oawF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726444AbeJOIIs (ORCPT + 99 others); Mon, 15 Oct 2018 04:08:48 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:46169 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726186AbeJOIIs (ORCPT ); Mon, 15 Oct 2018 04:08:48 -0400 Received: by mail-pg1-f194.google.com with SMTP id a5-v6so8282691pgv.13; Sun, 14 Oct 2018 17:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=uQ0FyqUpesMBzjf7/OI8xWcjm3RFtiErVhhCpWTGBY4=; b=Sfx3oawFpmra7ruGIS9s5zAho+VMrIwPlrpfy0KZDbkkzEIE4lWFBmaMCJ0AxQqys5 lQlD1JIkJSnDN50RmorQzMeMYQTJUv9yU4T9QBx3SpSDodetXe+iqOXG8hHC5dq5Ny1e EVLM274xOzzu41cK/Bv5dYO2pfGVTGzy8uR885cPq5BTuVfEyGg38LBcvgqCsG2mXAyJ oHF01m03EfULXkzR9BcZ0qCWr+9v3ooBV4onC3ewkINDDHDJRQuQT5Z/B9kHoVskaiPN B57zrPVbwJ/RyLEVSoUTVcgUPyfEfIXTxksdvePrclykfENh8WJx5VJz2JE4AhfuRsWK unoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uQ0FyqUpesMBzjf7/OI8xWcjm3RFtiErVhhCpWTGBY4=; b=BwLaDlo6WRvBi5RgudkYch+wcSoHnCODP3FfAh31VAbwo2TJ10SYKR/R0lq8DRqM6Z jEKx3eZm8VOeDKJ/nDUpmZ82EsKomQKvQGR+wd3laWUon16RsGetOeu0jQNwNGyAMKTx cUaXa8xzIEyURcPnou3tcpmY7VLGgKdnWkgnSUvGlDHcYUXgtavajeHdq7jUTzBwGSXv Pm1tvUIORSRJfCojpD1jqglKfF75hhLoYfsc4/O2EjYC9pX2ZtPfdRtUZC3kJ8QjBowR 1P1U+GH+MB8edxzvXxAuU4zb/ctW8uVcIcoQ4Xb78V3w1xdvCggHovKXgnWfxRJB4MqG HWTw== X-Gm-Message-State: ABuFfojNhfYGSSwebYFkiha1ZSf3bY7umFvzE7F9K95SamO8//anJa96 Pa7LE8zQ2AzblB9oVj3+XiE= X-Received: by 2002:a63:c54a:: with SMTP id g10-v6mr13715821pgd.201.1539563159389; Sun, 14 Oct 2018 17:25:59 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id j14-v6sm11387110pgh.52.2018.10.14.17.25.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 14 Oct 2018 17:25:58 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH v3 00/18] of: overlay: validation checks, subsequent fixes Date: Sun, 14 Oct 2018 17:24:12 -0700 Message-Id: <1539563070-12969-1-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand Add checks to (1) overlay apply process and (2) memory freeing triggered by overlay release. The checks are intended to detect possible memory leaks and invalid overlays. The checks revealed bugs in existing code. Fixed the bugs. While fixing bugs, noted other issues, which are fixed in separate patches. ***** Powerpc folks: I was not able to test the patches that ***** directly impact Powerpc systems that use dynamic ***** devicetree. Please review that code carefully and ***** test. The specific patches are: 03/16, 04/16, 07/16 FPGA folks: I made the validation checks that should result in an invalid live devicetree report "ERROR" and cause the overlay apply to fail. I made the memory leak validation tests report "WARNING" and allow the overlay apply to complete successfully. Please let me know if you encounter the warnings. There are at least two paths forward to deal with the cases that trigger the warning: (1) change the warning to an error and fail the overlay apply, or (2) find a way to detect the potential memory leaks and free the memory appropriately. ALL people: The validations do _not_ address another major concern I have with releasing overlays, which is use after free errors. Changes since v2: - 13/18: Use continue to reduce indentation in find_dup_cset_node_entry() and find_dup_cset_prop() Changes since v1: - move patch 16/16 to 17/18 - move patch 15/16 to 18/18 - new patch 15/18 - new patch 16/18 - 05/18: add_changeset_node() header comment: incorrect comment for @target - 18/18: add same fix for of_parse_phandle_with_args() - 18/18: add same fix for of_parse_phandle_with_args_map() Frank Rowand (18): of: overlay: add tests to validate kfrees from overlay removal of: overlay: add missing of_node_put() after add new node to changeset of: overlay: add missing of_node_get() in __of_attach_node_sysfs powerpc/pseries: add of_node_put() in dlpar_detach_node() of: overlay: use prop add changeset entry for property in new nodes of: overlay: do not duplicate properties from overlay for new nodes of: dynamic: change type of of_{at,de}tach_node() to void of: overlay: reorder fields in struct fragment of: overlay: validate overlay properties #address-cells and #size-cells of: overlay: make all pr_debug() and pr_err() messages unique of: overlay: test case of two fragments adding same node of: overlay: check prevents multiple fragments add or delete same node of: overlay: check prevents multiple fragments touching same property of: unittest: remove unused of_unittest_apply_overlay() argument of: overlay: set node fields from properties when add new overlay node of: unittest: allow base devicetree to have symbol metadata of: unittest: find overlays[] entry by name instead of index of: unittest: initialize args before calling of_*parse_*() arch/powerpc/platforms/pseries/dlpar.c | 15 +- arch/powerpc/platforms/pseries/reconfig.c | 6 +- drivers/of/dynamic.c | 68 +++-- drivers/of/kobj.c | 4 +- drivers/of/overlay.c | 298 ++++++++++++++++----- drivers/of/unittest-data/Makefile | 2 + .../of/unittest-data/overlay_bad_add_dup_node.dts | 28 ++ .../of/unittest-data/overlay_bad_add_dup_prop.dts | 24 ++ drivers/of/unittest-data/overlay_base.dts | 1 + drivers/of/unittest.c | 96 +++++-- include/linux/of.h | 19 +- 11 files changed, 439 insertions(+), 122 deletions(-) create mode 100644 drivers/of/unittest-data/overlay_bad_add_dup_node.dts create mode 100644 drivers/of/unittest-data/overlay_bad_add_dup_prop.dts -- Frank Rowand