Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3539435imm; Sun, 14 Oct 2018 23:06:46 -0700 (PDT) X-Google-Smtp-Source: ACcGV63jUMJ1sOHpWizmNY1bv+fahqCOTR9ivVjL7rzfQN5B5tpXGzYB3cMpaH4KNXO5ebrMQvTY X-Received: by 2002:a63:8dc1:: with SMTP id z184-v6mr14637285pgd.328.1539583606386; Sun, 14 Oct 2018 23:06:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539583606; cv=none; d=google.com; s=arc-20160816; b=ynThhKgHnzE/W8oNjmPq1pm5bc0QVcp9ENx+6TJbYJRVtwN+DNnroXHnwlSGhGcrva Yllvg4WMmwNiwb+DTmGshwQlgmp3D5LFqQPW9w+3MVgx63MIB3AeeYkDyVO9/DefSrqU KYzRKrl3K+r4XQsM5ia3kHuOK2AcuLhE+906JIhR+uV0NkyjdNyZs2MTZMFDxB+Czo22 C1cBa+iHw22kCr4vAxVePXU0iPnWw1JSFacuj2d8MRc3B3VNj1D3sR5tZ/TP9r5cwPT1 bhFKMcdkbBk0m+Ui9mRckEsnbcRYlmBgr9gDTpmdTgQs4HAfQRaIFuTn1tDzYtjUQOd4 PWLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id; bh=dc5u6U7+HswFQY5oWeS8znM2SD6awnb1rUPjKMEwVWc=; b=NLZqJ0HgfTmV1mvL7IpusDC2VlzgPqBBH5YGOnpyM04FwOKkZI8Z6juZOFmE++wl5m v/gbEtGD5PscQ/EnUzS7RGrwYeP5MiD0nh8J+vNyFr7dHLFJCrLURW80HPkoDmVFdLeJ nNEbmaDFAU+ZXZ1xv7RRi6Vv5lCIectIZwnJu+/mEvRzDoksw3yTnBN10C5Vb7Q4IUiN qPRrTY4Z4kJI9Qupt0SQFwHt2/Qtc3cFuC6HZKVg4A3sNg6Bi/W5V6qP+NejWENkOhfl usS+dmycxswHQBsIBcgIjwgi6SYzYP6UD956kpwC98HAgtNOE36MGKuQEP7AZaP7KwRx kg3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si9137741plz.380.2018.10.14.23.06.31; Sun, 14 Oct 2018 23:06:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbeJONtr (ORCPT + 99 others); Mon, 15 Oct 2018 09:49:47 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:38999 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726401AbeJONtr (ORCPT ); Mon, 15 Oct 2018 09:49:47 -0400 X-UUID: 84507e3de42a467bbddde0788015103e-20181015 X-UUID: 84507e3de42a467bbddde0788015103e-20181015 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 166524223; Mon, 15 Oct 2018 14:05:55 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 15 Oct 2018 14:05:54 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 15 Oct 2018 14:05:54 +0800 Message-ID: <1539583554.20626.2.camel@mtkswgap22> Subject: Re: [PATCH v7 0/9] PCI: mediatek: fixup find_port, enable_msi and add PM, module support From: Ryder Lee To: CC: , , , , , , , , , , , , , , Date: Mon, 15 Oct 2018 14:05:54 +0800 In-Reply-To: <1539582287-9171-1-git-send-email-honghui.zhang@mediatek.com> References: <1539582287-9171-1-git-send-email-honghui.zhang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2018-10-15 at 13:44 +0800, honghui.zhang@mediatek.com wrote: > From: Honghui Zhang > > This patchset includes misc patchs: > > The patch 1 fixup the mtk_pcie_find_port logic which will cause system > could not touch the EP's configuration space that connected to PCIe slot 1. > > The patch 2 fixup the class type for MT7622. > The patch 6 fixup the enable msi logic, the operation to enable MSI > should be after system clock is enabled. Call mtk_pcie_enable_msi in > mtk_pcie_startup_port_v2 since the clock was all enabled at that time. > > The patch 7 was rebased and refactor of the v4 patch[1], changes are: > -Add PM support for MT7622. > -Using mtk_pcie_enable_port to re-establish the link when resumed. > -Rebased on this patchset. > > The patch 9 add loadable kernel module support. > > [1] https://patchwork.kernel.org/patch/10479079 > > Change since v6: > - Remove the pci_unmap_iospace when remove the device since the > devm_pci_remap_iospace is an devm_ version. > - Commit message changed for patch 2(Fix class type for MT7622 as PCI_CLASS_BRIDGE_PCI). > - Capitilizing "MSI" and "PM" in the patch title. > > Change since v5: > - A bit improvement of mtk_pcie_find_port suggest by Lorenzo. > - Add fixup tags of fix enable MSI logic in patch 6. > - Add Acked-by tags from Ryder. > > Change since v4: > - Add patch 2 to fixup class type for MT7622. > - Add patch 3 to remove the redundant dev->pm_domain check > - Add patch 4 to covert to use pci_host_probe > - Add patch 5 to re-arrange the function define, this is a prepare patch for > fixup the enable_msi logic, no functional changed have been made by this one. > - Add patch 8 to save the GIC IRQ in mtk_pcie_port as a prepare patch for tear > down the irq when remove the kernel module. > - Re-arrange the find_port flow suggest by Lorenzo to make the code parse easier > for the patch 1. > - Remove the .pm_support in mtk_pcie_soc in patch 7 since if system pm was not > supported, then those pm callbacks will never be executed for MT7622. So the > .pm_support is not needed. > > Change since v3: > - Remove pm_runtime_XXX ops in suspend and resume callbacks in the third patch. > - Rebase to 4.19-rc1. > > Change since v2: > - Fix the list_for_each_entry_safe parameter error. > - Add Ryder's Acked-by flag. > > Change since v1: > - A bit of code refact of the first patch suggested by Andy Shevchenko, and > commit message updated. > > Honghui Zhang (9): > PCI: mediatek: Using slot's devfn for compare to fix > mtk_pcie_find_port logic > PCI: mediatek: Fix class type for MT7622 as PCI_CLASS_BRIDGE_PCI > PCI: mediatek: Remove the redundant dev->pm_domain check > PCI: mediatek: Convert to use pci_host_probe() > PCI: mediatek: Move the mtk_pcie_startup_port_v2 function's define > after mtk_pcie_setup_irq > PCI: mediatek: Fixup enable MSI logic by enable MSI after clock > enabled > PCI: mediatek: Add system PM support for MT2712 and MT7622 > PCI: mediatek: Save the GIC IRQ in mtk_pcie_port > PCI: mediatek: Add loadable kernel module support > > drivers/pci/controller/Kconfig | 2 +- > drivers/pci/controller/pcie-mediatek.c | 319 +++++++++++++++++++++------------ > 2 files changed, 204 insertions(+), 117 deletions(-) You forgot to add my Acked-by tags in v7. Acked-by: Ryder Lee for the series. Thanks.