Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3837041imm;
        Mon, 15 Oct 2018 05:08:42 -0700 (PDT)
X-Google-Smtp-Source: ACcGV60mMix+nj/IcHEnZEBSUrGOsKPQtDls2dh1yw3f+eEnD5gXppLbneqCmQl8ETAtEv4hStRk
X-Received: by 2002:a62:90db:: with SMTP id q88-v6mr17049580pfk.98.1539605322381;
        Mon, 15 Oct 2018 05:08:42 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1539605322; cv=none;
        d=google.com; s=arc-20160816;
        b=HYnrrxFkoG1yw1l2+Y6xvJ/ivaWZ47WSY3rIdP8AiDYdzeVZsY64ruq7YNpDa1nBCB
         J5o4bVqNsoRG6Unf/0eZJWADUFskRpeHz+q40uKInUMCmf9HymkacUc1INMyqCcLm0OT
         w9WKNHibJMIoqCodCMGW6lqBJaI/xKTABz6gdUtW2QUJaoR2FyaKXdQDkfOR1h2VJFuD
         n2Wt6/2sIF5vSNGin3URGdOEHfjg6joWghNIZFoEvP8g7n8ZPybG+KLQTS3nFMKNEfmr
         cOyjcFNrdvmzE1cMgMi0686hNMrVLqX7cNSIKi2Cb7TA1fq22wrHEAIQsNnJnrYPb8Kx
         7DSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=A8IRdm8I0TrYsyNvTAWSqZcElvit005sjLl0svfYN1I=;
        b=vtShL86f0VNOfugXAe+50w34lJT0EnsbjTFZBFGQKCU0D4Ne9K60uNAWRRREIg2lqp
         lMxEU6HINhyHFsXQNvteElito/WCM9dF8AYvUAcYxDsGjHp501MFIS9eTQMtxMS4vgGm
         qVuvPcCwXGq4Ub9XDZWz0r8czSL/Omkq0XPzbt56A4LZILl8yS4jopd2t+XAg5Oo+Imd
         tQxw/caCNaZooebJ7Bk7Rp56ThDJbkwX3KR3o8URm3QURvCg9Wi7E5QRf2lM/tQsvMpU
         EyAapdzGZZOykFsSafOf3jHED5mpJ27CXS48sWlHmpTtrmwv4BD42msVvHojkaJlImak
         svPw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id o11-v6si10325255pls.76.2018.10.15.05.08.27;
        Mon, 15 Oct 2018 05:08:42 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726666AbeJOTwx (ORCPT <rfc822;chaneybenjamini@gmail.com>
        + 99 others); Mon, 15 Oct 2018 15:52:53 -0400
Received: from mga05.intel.com ([192.55.52.43]:6228 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726498AbeJOTwx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 Oct 2018 15:52:53 -0400
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2018 05:07:53 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,384,1534834800"; 
   d="scan'208";a="272520527"
Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.164]) ([10.237.72.164])
  by fmsmga006.fm.intel.com with ESMTP; 15 Oct 2018 05:07:52 -0700
Subject: Re: Can we just remove the sw_lpm_support from current xhci driver?
To:     "Zengtao (B)" <prime.zeng@hisilicon.com>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
References: <678F3D1BB717D949B966B68EAEB446ED1F18C855@dggemm526-mbx.china.huawei.com>
From:   Mathias Nyman <mathias.nyman@intel.com>
Message-ID: <155e2a10-d324-6bc6-b3fc-b23d15a3af25@intel.com>
Date:   Mon, 15 Oct 2018 15:11:19 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <678F3D1BB717D949B966B68EAEB446ED1F18C855@dggemm526-mbx.china.huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15.10.2018 12:35, Zengtao (B) wrote:
> Hi:
> 
> I am recently reading the LPM related code in xhci driver, and I find
> that the xhci->sw_lpm_support is not really used, but I am not sure
>   whether we should remove it or not?
> 
> Any ideas, Thanks.

I think it was used to prevent LPM in pre-0.96 xHC controllers.
Now driver only supports HW LPM for 1.0 and later controllers, so xhci->sw_lpm_support
doesn't really do anything.

You can send a patch removing it

Thanks
-Mathias