Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3885241imm; Mon, 15 Oct 2018 05:54:09 -0700 (PDT) X-Google-Smtp-Source: ACcGV62C38UBYfDiJ6ApuF8lLJaaIUkeG/wfgPiwLiksT2jkrwx8fN+MrNyRajBTkMTSRcSjc7EH X-Received: by 2002:a63:595:: with SMTP id 143-v6mr16001768pgf.244.1539608049359; Mon, 15 Oct 2018 05:54:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539608049; cv=none; d=google.com; s=arc-20160816; b=cbdIhtZuyTWjFQ+CWOUvqwdCRPwlLSI+oeGtoM/BSzyVnDDavax8nXFiD2U15GABXl Fgy5DCqk70c32dK/5QlcnSZxUHtH8+I6XCRGSQeGwZehpigXYc9a+FzliGbfKK3Cv+Od SVKDizlLP3QfvbnJ3DV3BGmDeiljALfdKLO81osVtuUrNOWDhVALd2Ngbq7VA3UdXD0P OizaFS2YjFBEFIJE084wEx+Pp48yW5rSM8zaUwIv3pYkD6EaK4NOSCKZvBESM05AZNkE rszNFtgMn9Pzi6Eo+Md6WF0dxKUDVv8QujUDmEYYiT/b/wmEU1pCQGiH+evwiU3aGgMo xxlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ye7qdguWGVMxyMFXGZc3mYxNm8/GKTNpe/iAI/SCtS4=; b=eNO8UDIse5TFea/Na7ynhRZVU+456M+Zl/n62fU7ZC4nZHMwNk4QJ2Qd87kVwXcdRc FP5kmZz7ZRo8lQWhQ/VxGm+iRVFZD7SN/XZUHn4Bz4/bdf3RIdDAoj+Ji3R9KX4rst09 ii7YOh9avSOwEF4UKXSjqND0h7oEvZ+wGYntzz+WQ8oK8oZGIizlPrpX+SdkANo8Ji3t n8prhP+h4wS4hTN/LfYtihK9g1a0KWkVnuLVSWnviRW6fOL4/6xwl23txlwIqC/dvC5a lnplZh4TGQZlh/mcnv+5Mj7S4hwsA8DWg998+/dz42muZBv3e7wVG2mhedy3diDX3swy ibXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=QV2BZufm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m80-v6si10540829pfj.48.2018.10.15.05.53.54; Mon, 15 Oct 2018 05:54:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=QV2BZufm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726684AbeJOUin (ORCPT + 99 others); Mon, 15 Oct 2018 16:38:43 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59674 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbeJOUin (ORCPT ); Mon, 15 Oct 2018 16:38:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ye7qdguWGVMxyMFXGZc3mYxNm8/GKTNpe/iAI/SCtS4=; b=QV2BZufmKOTf53vuMKCSaQufu QvYcfWUVnYvkiZFOt1oXs7HDYBMjLr538iYpzEUAFkl4pn9Sa7qFuHBkb8bEef4clo+mwacinPW2T BtJlH5uVYVnn3TlQggyR4P0yYYJOcYyPFUH+03x6tExukzvmcq+AK6KI/mEKAK3IVe14vCFmp714r jC9q5BXQic0xJqxA9vdYsQa5udR9Buz4wtW/6rrt7WEYDrc/HdKoShfTf+rnK8n30lH0BEI8c+hiv cYgirtyBSi2S7k7n9OLQW+QEvCQPIl8lp2cbvAb2KKzZuU5q88ZBiBlEdgR8K0rap/BC4KYWtnd+7 U9AjsK6Fg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gC2NF-0002cR-7y; Mon, 15 Oct 2018 12:53:29 +0000 Date: Mon, 15 Oct 2018 05:53:29 -0700 From: Christoph Hellwig To: Hannes Reinecke Cc: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines Message-ID: <20181015125329.GA8952@infradead.org> References: <35ac9f31-7068-ab93-4629-363ee0bb4c70@suse.de> <2b48c925-73f0-0ca0-2f3c-3c35d90010ba@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b48c925-73f0-0ca0-2f3c-3c35d90010ba@suse.de> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 15, 2018 at 12:58:42PM +0200, Hannes Reinecke wrote: > However, the function declaration really is a worry, as the actual function > body only exists when the config option is enabled. Having a prototype without an implementation is no problem at all. We have this case all over the kernel, either intentionally to keep things simple or due to bitrot.