Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS
From:   Andy Lutomirski <luto@amacapital.net>
In-Reply-To: <20181015051705.GA20687@flashbox>
Date:   Mon, 15 Oct 2018 07:34:14 -0700
Cc:     Andy Lutomirski <luto@kernel.org>, nick.desaulniers@gmail.com,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <2CCAF5D3-1B11-43BF-93E4-72C2603A184F@amacapital.net>
References: <20181015003726.29103-1-nick.desaulniers@gmail.com> <CALCETrUZoBtxoR9u=72CSmNa-793EZySMd7TjH_BmHcrNSvLZg@mail.gmail.com> <20181015051705.GA20687@flashbox>
To:     Nathan Chancellor <natechancellor@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Oct 14, 2018, at 10:17 PM, Nathan Chancellor <natechancellor@gmail.com>=
 wrote:
>=20
>> On Sun, Oct 14, 2018 at 08:43:18PM -0700, Andy Lutomirski wrote:
>> On Sun, Oct 14, 2018 at 5:37 PM Nick Desaulniers
>> <nick.desaulniers@gmail.com> wrote:
>>>=20
>>> Fixes the objtool warning:
>>> arch/x86/mm/fault.o: warning: objtool: no_context()+0x220: unreachable
>>> instruction
>>>=20
>>> Link: https://github.com/ClangBuiltLinux/linux/issues/204
>>> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
>>> ---
>>> arch/x86/mm/fault.c | 6 ++++--
>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>=20
>>> diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
>>> index 47bebfe6efa7..057d2178fa19 100644
>>> --- a/arch/x86/mm/fault.c
>>> +++ b/arch/x86/mm/fault.c
>>> @@ -760,9 +760,11 @@ no_context(struct pt_regs *regs, unsigned long erro=
r_code,
>>>                 * and then double-fault, though, because we're likely to=

>>>                 * break the console driver and lose most of the stack du=
mp.
>>>                 */
>>> -               asm volatile ("movq %[stack], %%rsp\n\t"
>>> +               asm volatile (UNWIND_HINT_SAVE
>>> +                             "movq %[stack], %%rsp\n\t"
>>>                              "call handle_stack_overflow\n\t"
>>> -                             "1: jmp 1b"
>>> +                             "1: jmp 1b\n\t"
>>> +                             UNWIND_HINT_RESTORE
>>>                              : ASM_CALL_CONSTRAINT
>>>                              : "D" ("kernel stack overflow (page fault)"=
),
>>>                                "S" (regs), "d" (address),
>>=20
>> NAK.  Just below this snippet is unreachable();
>>=20
>> Can you reply with objtool -dr output on a problematic fault.o?  Josh,
>> it *looks* like annotate_unreachable() should be doing the right
>> thing, but something is clearly busted.
>>=20
>> Also, shouldn't compiler-clang.h contain a reasonable definition of
>> unreachable()?
>>=20
>> --Andy
>=20
> Hi Andy,
>=20
> Did you mean 'objdump -dr'? If so, here you go (rather long, sorry if I
> should have pasted it here instead):
> https://gist.github.com/nathanchance/f038bb0a6653b975bb8a4e64fcd5503e
>=20
>=20

Hmm, -dr wasn=E2=80=99t quite enough to dump the .discard bits, assuming the=
y=E2=80=99re there at all. Can you just put the whole .o file somewhere?=