Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 15 Oct 2018 23:33:48 +0800
From:   Boqun Feng <boqun.feng@gmail.com>
To:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc:     "Paul E. McKenney" <paulmck@linux.ibm.com>,
        Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        tglx@linutronix.de, Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [PATCH] rcu: Use cpus_read_lock() while looking at
 cpu_online_mask
Message-ID: <20181015153348.GB8952@tardis>
References: <20180911160532.GJ4225@linux.vnet.ibm.com>
 <20180911162142.cc3vgook2gctus4c@linutronix.de>
 <20180911170222.GO4225@linux.vnet.ibm.com>
 <20180919205521.GE902964@devbig004.ftw2.facebook.com>
 <20180919221140.GH4222@linux.ibm.com>
 <20181012184114.w332lnkc34evd4sm@linutronix.de>
 <20181013134813.GD2674@linux.ibm.com>
 <20181015144217.nu5cp5mxlboyjbre@linutronix.de>
 <20181015150715.GA2422@tardis>
 <20181015150902.asifwhikqkz53ai4@linutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX"
Content-Disposition: inline
In-Reply-To: <20181015150902.asifwhikqkz53ai4@linutronix.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--yNb1oOkm5a9FJOVX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 15, 2018 at 05:09:03PM +0200, Sebastian Andrzej Siewior wrote:
> On 2018-10-15 23:07:15 [+0800], Boqun Feng wrote:
> > Hi, Sebastian
> Hi Boqun,
>=20
> > On Mon, Oct 15, 2018 at 04:42:17PM +0200, Sebastian Andrzej Siewior wro=
te:
> > > On 2018-10-13 06:48:13 [-0700], Paul E. McKenney wrote:
> > > >=20
> > > > My concern would be that it would queue it by default for the curre=
nt
> > > > CPU, which would serialize the processing, losing the concurrency of
> > > > grace-period initialization.  But that was a long time ago, and per=
haps
> > > > workqueues have changed.=20
> > >=20
> > > but the code here is always using the first CPU of a NUMA node or did=
 I
> > > miss something?
> > >=20
> >=20
> > The thing is the original way is to pick one CPU for a *RCU* node to
> > run the grace-period work, but with your proposal, if a RCU node is
> > smaller than a NUMA node (having fewer CPUs), we could end up having two
> > grace-period works running on one CPU. I think that's Paul's concern.
>=20
> Ah. Okay. From what I observed, the RCU nodes and NUMA nodes were 1:1
> here. Noted.

Ok, in that case, there should be no significant performance difference.

> Given that I can enqueue a work item on an offlined CPU I don't see why
> commit fcc6354365015 ("rcu: Make expedited GPs handle CPU 0 being
> offline") should make a difference. Any objections to just revert it?

Well, that commit is trying to avoid queue a work on an offlined CPU,
because according to workqueue API, it's the users' responsibility to
make sure the CPU is online when a work item enqueued. So there is a
difference ;-)

But I don't have any objection to revert it with your proposal, since
yours is more simple and straight-forward, and doesn't perform worse if
NUMA nodes and RCU nodes have one-to-one corresponding.

Besides, I think even if we observe some performance difference in the
future, the best way to solve that is to make workqueue have a more
fine-grained affine group than a NUMA node.

Regards,
Boqun

>=20
> > Regards,
> > Boqun
>=20
> Sebastian

--yNb1oOkm5a9FJOVX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEj5IosQTPz8XU1wRHSXnow7UH+rgFAlvEs1gACgkQSXnow7UH
+riLhQgAl8b5Ic5ilwWUpkxrUEhRfcUDSSmpzzAdJEbueKFQAaLH1wp5Gi1M6QzL
u7Klz03o4zpYcBnEXzaeZrewywkmbsPOi3/NGoxOV8vRdVl52XwyctqBUvL37UVp
4DGJxmnw2bwxVPa74n94LE72hdS1p6yCU7TKHQ9D57Q1qDHE16x4cQC/zlA62hlT
vzUjyo61tV4gcngVQBao72EuIPNHRkbEktbJ9e8D/lcWIQEu1MXx2eQUeTDFGoKl
sElQRxL5o+lUXztfuNVQ7RXY+e+kBUWZKyaa5hqFvSBj55OJBGN/2sGtvt0pAxW2
+FHaV9yWRKkMZmSNsDh8GVxqnaih7Q==
=MozF
-----END PGP SIGNATURE-----

--yNb1oOkm5a9FJOVX--