Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <Pine.LNX.4.44L0.1810151120060.1394-100000@iolanthe.rowland.org>
References: <00000000000050c44f05780f6bbe@google.com> <Pine.LNX.4.44L0.1810151120060.1394-100000@iolanthe.rowland.org>
From:   Andrey Konovalov <andreyknvl@google.com>
Date:   Mon, 15 Oct 2018 18:20:35 +0200
Message-ID: <CAAeHK+zc-JyzxTAtv7tuVAw8Aut2uAfGP7FfNmseALY1ZBgcNQ@mail.gmail.com>
Subject: Re: WARNING in usb_submit_urb (3)
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     syzbot <syzbot+24a30223a4b609bb802e@syzkaller.appspotmail.com>,
        Thinh.Nguyen@synopsys.com,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        "Gustavo A . R . Silva" <garsilva@embeddedor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 15, 2018 at 5:22 PM, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Fri, 12 Oct 2018, syzbot wrote:
>
>> Hello,
>>
>> syzbot found the following crash on:
>>
>> HEAD commit:    9dcd936c5312 Merge tag 'for-4.19/dm-fixes-4' of git://git...
>> git tree:       upstream
>> console output: https://syzkaller.appspot.com/x/log.txt?x=123b8da1400000
>> kernel config:  https://syzkaller.appspot.com/x/.config?x=88e9a8a39dc0be2d
>> dashboard link: https://syzkaller.appspot.com/bug?extid=24a30223a4b609bb802e
>> compiler:       gcc (GCC) 8.0.1 20180413 (experimental)
>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13888991400000
>> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1476e5e6400000
>>
>> IMPORTANT: if you fix the bug, please add the following tag to the commit:
>> Reported-by: syzbot+24a30223a4b609bb802e@syzkaller.appspotmail.com
>>
>> IPVS: ftp: loaded support on port[0] = 21
>> ------------[ cut here ]------------
>> usb usb7: BOGUS urb flags, 1 --> 0
>> WARNING: CPU: 0 PID: 5828 at drivers/usb/core/urb.c:503
>> usb_submit_urb+0x717/0x14e0 drivers/usb/core/urb.c:502
>> Kernel panic - not syncing: panic_on_warn set ...
>
> This should have been fixed by commit 7a68d9fb8510 ("USB: usbdevfs:
> sanitize flags more").  Was that commit not present in the kernel you
> tested?

The commit is there, AFAICT. This must be a different issue.