Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <Pine.LNX.4.44L0.1810151309030.1394-100000@iolanthe.rowland.org>
References: <CAAeHK+zc-JyzxTAtv7tuVAw8Aut2uAfGP7FfNmseALY1ZBgcNQ@mail.gmail.com>
 <Pine.LNX.4.44L0.1810151309030.1394-100000@iolanthe.rowland.org>
From:   Andrey Konovalov <andreyknvl@google.com>
Date:   Mon, 15 Oct 2018 19:40:49 +0200
Message-ID: <CAAeHK+wJVFv-8AHFG3V3tOdkzw9D63Ztot_tb=oR-QVNXWPoXw@mail.gmail.com>
Subject: Re: WARNING in usb_submit_urb (3)
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     syzbot <syzbot+24a30223a4b609bb802e@syzkaller.appspotmail.com>,
        Thinh.Nguyen@synopsys.com,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        "Gustavo A . R . Silva" <garsilva@embeddedor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        Oliver Neukum <oneukum@suse.com>
Content-Type: multipart/mixed; boundary="0000000000002723b3057847f028"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--0000000000002723b3057847f028
Content-Type: text/plain; charset="UTF-8"

On Mon, Oct 15, 2018 at 7:12 PM, Alan Stern <stern@rowland.harvard.edu> wrote:
> Ah, I see the problem.  In fact it is the same issue, but the commit
> mentioned above contains an error (is_in gets tested too soon).  The
> fix is below; can you check it?

You can ask syzbot to do this:

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master

--0000000000002723b3057847f028
Content-Type: text/x-patch; charset="US-ASCII"; name="usb_submit_urb.patch"
Content-Disposition: attachment; filename="usb_submit_urb.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_jnal3y1h0

ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2NvcmUvZGV2aW8uYyBiL2RyaXZlcnMvdXNiL2NvcmUv
ZGV2aW8uYwppbmRleCAyNDQ0MTdkMGRmZDEuLmZmY2NkNDBlYTY3ZCAxMDA2NDQKLS0tIGEvZHJp
dmVycy91c2IvY29yZS9kZXZpby5jCisrKyBiL2RyaXZlcnMvdXNiL2NvcmUvZGV2aW8uYwpAQCAt
MTQ3NCw4ICsxNDc0LDYgQEAgc3RhdGljIGludCBwcm9jX2RvX3N1Ym1pdHVyYihzdHJ1Y3QgdXNi
X2Rldl9zdGF0ZSAqcHMsIHN0cnVjdCB1c2JkZXZmc191cmIgKnV1cmIKIAl1ID0gMDsKIAlzd2l0
Y2ggKHV1cmItPnR5cGUpIHsKIAljYXNlIFVTQkRFVkZTX1VSQl9UWVBFX0NPTlRST0w6Ci0JCWlm
IChpc19pbikKLQkJCWFsbG93X3Nob3J0ID0gdHJ1ZTsKIAkJaWYgKCF1c2JfZW5kcG9pbnRfeGZl
cl9jb250cm9sKCZlcC0+ZGVzYykpCiAJCQlyZXR1cm4gLUVJTlZBTDsKIAkJLyogbWluIDggYnl0
ZSBzZXR1cCBwYWNrZXQgKi8KQEAgLTE1MDUsNiArMTUwMyw4IEBAIHN0YXRpYyBpbnQgcHJvY19k
b19zdWJtaXR1cmIoc3RydWN0IHVzYl9kZXZfc3RhdGUgKnBzLCBzdHJ1Y3QgdXNiZGV2ZnNfdXJi
ICp1dXJiCiAJCQlpc19pbiA9IDA7CiAJCQl1dXJiLT5lbmRwb2ludCAmPSB+VVNCX0RJUl9JTjsK
IAkJfQorCQlpZiAoaXNfaW4pCisJCQlhbGxvd19zaG9ydCA9IHRydWU7CiAJCXNub29wKCZwcy0+
ZGV2LT5kZXYsICJjb250cm9sIHVyYjogYlJlcXVlc3RUeXBlPSUwMnggIgogCQkJImJSZXF1ZXN0
PSUwMnggd1ZhbHVlPSUwNHggIgogCQkJIndJbmRleD0lMDR4IHdMZW5ndGg9JTA0eFxuIiwK
--0000000000002723b3057847f028--