Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20181004173338.GL22824@google.com>
Date:   Mon, 15 Oct 2018 20:06:02 +0200
Cc:     Sinan Kaya <okaya@codeaurora.org>,
        Balakrishna Godavarthi <bgodavar@codeaurora.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Marcin Wojtas <mw@semihalf.com>,
        Andy Shevchenko Andy Shevchenko <andy.shevchenko@gmail.com>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        Loic Poulain <loic.poulain@linaro.org>,
        Brian Norris <briannorris@chromium.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <9B742DB5-F584-4A47-A04B-4F72EB17519C@holtmann.org>
References: <20180927004810.124185-1-mka@chromium.org>
 <20180927004810.124185-2-mka@chromium.org>
 <b28c34475e447cc29a139f9121b3c1d9@codeaurora.org>
 <e6752d4b-b22a-d951-e9db-1ae7445dc403@codeaurora.org>
 <20180927171305.GG22824@google.com> <20181004173338.GL22824@google.com>
To:     Matthias Kaehlcke <mka@chromium.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Matthias,

>>>>  void bt_sock_reclassify_lock(struct sock *sk, int proto);
>>>> 
>>>> +int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr);
>>> 
>>> Maybe change the API name to start with bt_ and get rid of device_?
>> 
>> device_ indicates that we get the BD_ADDR for a 'struct device' and
>> not for e.g. a 'struct fwnode_handle'.
>> 
>> Anyway with this version of the patch fwnode_get_bd_address() has been
>> scrapped and it might never be introduced again, so I'm open to change
>> the name to bt_ if there is a general preference for it.
> 
> Marcel, can you live with this being added to the Bluetooth code base
> instead of property? Also if you'd prefer the function to be named
> bt_get_bd_address() let me know.

explain to me again why this is useful? I am failing to see the benefit if this is not part of the property.h API.

Regards

Marcel