Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4302178imm; Mon, 15 Oct 2018 12:23:11 -0700 (PDT) X-Google-Smtp-Source: ACcGV60RrUPGv5Gw5ITllTPGH6VAbSouy3DMymaezIdlLuuug/8Vnaaq6iAj0R9i+JK7084jh3LQ X-Received: by 2002:a62:e057:: with SMTP id f84-v6mr18763714pfh.208.1539631391767; Mon, 15 Oct 2018 12:23:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539631391; cv=none; d=google.com; s=arc-20160816; b=pZ3F+adiW6BLMKgOHQIZx+berwGYOGyfAJQwAogPvzSfDg2KnG8aR5+moa3JYjVAJm 6AewRNhVGqN55s90e5wgLXnXSQz306mQ2y0cEi8yvCMZucvCAkvN20oQ8HgISMSm7PIF qHBJeqXuORPAHd1/LBf53YiPb36iJC6pjXLhTiXP5LkvMOy0Pmw7yyhj0t+yFqJ3W6jB iVwtdQDF5huGD2hzrHRJPcPYw5NcxQ9X4FbD4+Ex5qUDcVv0Ad0YUMc05VCWJYOvhH3N 9bvdPHggbFk/HuwhGJzE1gY7MA7x54sfVF7E9+xDOVboEkmHuD4nRnD2xK5VssZbo2rS 8QPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Wy1ARHv46Cp0sCjMTh/vVZFwhRqyGYeNLL1D6nymFhs=; b=CeMJiay+rrAFSX74nhr3Xpk6YbU5GDdGvULTpviNqLYUjr1ifhIH/mrokBuP4amFMt PQf7djJqN0FE0K1B4aMKVYpg5rxjtdb5P/zhxio2C5er8Zn1AGutvajsr6bo8Hti5DxI IRNTYWBRCrjkiDytCmjFlauZAoddqtRm4UujT/pFmpCsQULUt1vK4nXkxtz9ACF+7Vdo 3p5tnF6tvm596HW59jd8XKummM6w/nJYJrwVHkJVubZLWFYIpZ1exfo2TgXJq1GSk36D pROt7feDZ9PUudryu9qHZeosQtxtFtbrMq69fWdfWuwPTHmAWNDDPltSK8sRJJ/fssQm jcog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lXssOpZP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12-v6si11020533plt.4.2018.10.15.12.22.56; Mon, 15 Oct 2018 12:23:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lXssOpZP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726906AbeJPDIy (ORCPT + 99 others); Mon, 15 Oct 2018 23:08:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:54148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726681AbeJPDIy (ORCPT ); Mon, 15 Oct 2018 23:08:54 -0400 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 14CF82145D; Mon, 15 Oct 2018 19:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539631337; bh=ZPil9R+QKO8poIw11LkPFCCgJT/t/NekTHonWAJibQ8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=lXssOpZPf5eraYSYN/wXeykVTyEAcGr04qUm/1/L6+sSnJ0DGTr9suSHv/aJWpN+a zsiltdMMv5luJxUkE0X1t2HhQE1VNSKNHHwt8pu/SwY+27hZDGVsYwxEshB09Lx3AF S13Om4Gbc9hqh8s3d2sk1uvCQGfhyhH5CmiSSPqI= Received: by mail-ed1-f43.google.com with SMTP id w19-v6so18947309eds.1; Mon, 15 Oct 2018 12:22:17 -0700 (PDT) X-Gm-Message-State: ABuFfohZeXHsnMFmWar8RWmTiyKoX5cstfU5sUlPVJMVGG7wucp0Txqg 27AxpxpD2YmyiHbTTp9cs/eFtdSvr3s/UWXYux4= X-Received: by 2002:a50:fc06:: with SMTP id i6-v6mr22468551edr.153.1539631335410; Mon, 15 Oct 2018 12:22:15 -0700 (PDT) MIME-Version: 1.0 References: <1539563070-12969-1-git-send-email-frowand.list@gmail.com> In-Reply-To: <1539563070-12969-1-git-send-email-frowand.list@gmail.com> From: Alan Tull Date: Mon, 15 Oct 2018 14:21:39 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 00/18] of: overlay: validation checks, subsequent fixes To: Frank Rowand Cc: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Moritz Fischer , linux-kernel , linuxppc-dev , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-fpga@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 14, 2018 at 7:26 PM wrote: > > From: Frank Rowand > > Add checks to (1) overlay apply process and (2) memory freeing > triggered by overlay release. The checks are intended to detect > possible memory leaks and invalid overlays. > > The checks revealed bugs in existing code. Fixed the bugs. > > While fixing bugs, noted other issues, which are fixed in > separate patches. > > ***** Powerpc folks: I was not able to test the patches that > ***** directly impact Powerpc systems that use dynamic > ***** devicetree. Please review that code carefully and > ***** test. The specific patches are: 03/16, 04/16, 07/16 > > FPGA folks: > > I made the validation checks that should result in an > invalid live devicetree report "ERROR" and cause the overlay apply > to fail. > > I made the memory leak validation tests report "WARNING" and allow > the overlay apply to complete successfully. Please let me know > if you encounter the warnings. There are at least two paths > forward to deal with the cases that trigger the warning: (1) change > the warning to an error and fail the overlay apply, or (2) find a > way to detect the potential memory leaks and free the memory > appropriately. I reran my FPGA testing. The strings are fixed, no longer NULL. I have functionality back, my test passes now. I'm seeing the intended warnings about any properties added to existing nodes. That includes warnings about added symbols. Below is a simplified part to show some of what I'm seeing. By the way my testing is all using Pantelis' DT overlay configfs interface. root@arria10:~# ./apply-static-region.sh Applying dtbo: socfpga_arria10_socdk_sdmmc_ghrd_ovl_ext_cfg.dtb [ 1821.088640] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /soc/base_fpga_region/ranges [ 1821.103307] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /soc/base_fpga_region/external-fpga-config [ 1821.117359] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /soc/base_fpga_region/clocks [ 1821.130130] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /soc/base_fpga_region/clock-names [ 1821.143449] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /__symbols__/clk_0 [ 1821.155357] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /__symbols__/ILC [ 1821.167074] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /__symbols__/freeze_controller_0 [ 1821.180171] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /__symbols__/sysid_qsys_0 [ 1821.192662] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /__symbols__/led_pio [ 1821.204720] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /__symbols__/button_pio [ 1821.217034] OF: overlay: WARNING: add_changeset_property(), memory leak will occur if overlay removed. Property: /__symbols__/dipsw_pio [ 1821.231977] of-fpga-region soc:base_fpga_region:fpga_pr_region0: FPGA Region probed [ 1821.240144] altera_freeze_br ff200450.freeze_controller: fpga bridge [freeze] registered root@arria10:~# ./apply-static-region.sh root@arria10:~# rmdir /sys/kernel/config/device-tree/overlays/1-socfpga_arria10_socdk_sdmmc_ghrd_ovl_ext_cfg.dtb [ 1823.805564] OF: ERROR: memory leak - destroy cset entry: attach overlay node /soc/base_fpga_region/clk_0 with refcount 2 Alan Alan > > ALL people: > > The validations do _not_ address another major concern I have with > releasing overlays, which is use after free errors. > > Changes since v2: > > - 13/18: Use continue to reduce indentation in find_dup_cset_node_entry() > and find_dup_cset_prop() > > Changes since v1: > > - move patch 16/16 to 17/18 > - move patch 15/16 to 18/18 > - new patch 15/18 > - new patch 16/18 > > - 05/18: add_changeset_node() header comment: incorrect comment for @target > > - 18/18: add same fix for of_parse_phandle_with_args() > - 18/18: add same fix for of_parse_phandle_with_args_map() > > Frank Rowand (18): > of: overlay: add tests to validate kfrees from overlay removal > of: overlay: add missing of_node_put() after add new node to changeset > of: overlay: add missing of_node_get() in __of_attach_node_sysfs > powerpc/pseries: add of_node_put() in dlpar_detach_node() > of: overlay: use prop add changeset entry for property in new nodes > of: overlay: do not duplicate properties from overlay for new nodes > of: dynamic: change type of of_{at,de}tach_node() to void > of: overlay: reorder fields in struct fragment > of: overlay: validate overlay properties #address-cells and > #size-cells > of: overlay: make all pr_debug() and pr_err() messages unique > of: overlay: test case of two fragments adding same node > of: overlay: check prevents multiple fragments add or delete same node > of: overlay: check prevents multiple fragments touching same property > of: unittest: remove unused of_unittest_apply_overlay() argument > of: overlay: set node fields from properties when add new overlay node > of: unittest: allow base devicetree to have symbol metadata > of: unittest: find overlays[] entry by name instead of index > of: unittest: initialize args before calling of_*parse_*() > > arch/powerpc/platforms/pseries/dlpar.c | 15 +- > arch/powerpc/platforms/pseries/reconfig.c | 6 +- > drivers/of/dynamic.c | 68 +++-- > drivers/of/kobj.c | 4 +- > drivers/of/overlay.c | 298 ++++++++++++++++----- > drivers/of/unittest-data/Makefile | 2 + > .../of/unittest-data/overlay_bad_add_dup_node.dts | 28 ++ > .../of/unittest-data/overlay_bad_add_dup_prop.dts | 24 ++ > drivers/of/unittest-data/overlay_base.dts | 1 + > drivers/of/unittest.c | 96 +++++-- > include/linux/of.h | 19 +- > 11 files changed, 439 insertions(+), 122 deletions(-) > create mode 100644 drivers/of/unittest-data/overlay_bad_add_dup_node.dts > create mode 100644 drivers/of/unittest-data/overlay_bad_add_dup_prop.dts > > -- > Frank Rowand >