Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181003171720.169953-1-rkir@google.com> <20181003171720.169953-9-rkir@google.com>
 <20181015183807.GA6905@kroah.com> <CAOGAQeo31ggKCHsJw3D297J6Ya1kq8MptTaDR7q6H7-q99sdGw@mail.gmail.com>
 <20181015190134.GA6700@kroah.com>
In-Reply-To: <20181015190134.GA6700@kroah.com>
From:   Roman Kiryanov <rkir@google.com>
Date:   Mon, 15 Oct 2018 13:23:35 -0700
Message-ID: <CAOGAQepAqCorTosBwqJq-Kez=MUThv35JM=S8jfZEkkk1Xr9jw@mail.gmail.com>
Subject: Re: [PATCH v3 09/15] platform: goldfish: pipe: Move goldfish_pipe to goldfish_pipe_v2
To:     gregkh@linuxfoundation.org
Cc:     linux-kernel@vger.kernel.org, Todd Kjos <tkjos@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > I want our "v2" driver to be in a "v2" file and our "v1" driver in a
> > "v1" file. I think this is reasonable.
>
> The in kernel driver is the "v1" one.

I believe v2 (on our end) was upstream as goldfish_pipe.c instead of
goldfish_pipe_v2.c.

>  Why do you need a totally new driver file at all anyway?

I don't want to mix v1 and v2.

> And again, can you GUARANTEE that userspace will not break if you rename
> the kernel module?

Yes, it works:
https://android.googlesource.com/kernel/goldfish/+/android-goldfish-4.14-dev/drivers/platform/goldfish/

I don't see how userspace could be affected, unless we refer to
__FILE__ inside the driver for some important things. I believe we
don't.