Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4441241imm; Mon, 15 Oct 2018 15:05:41 -0700 (PDT) X-Google-Smtp-Source: ACcGV60XoKRowG3TJAeni38i5l086+X21gOW5+YZXigTO60K1D+9mpUJDEygL4tp+3qzrLGeQjUU X-Received: by 2002:a65:610e:: with SMTP id z14-v6mr17575710pgu.138.1539641141884; Mon, 15 Oct 2018 15:05:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539641141; cv=none; d=google.com; s=arc-20160816; b=KuOA1woNpiEnt1m8K3347iLYG/t9VQyP/79pvfQbl0vXV1ABERllvDp2uEY2v+d/ZG VjOtRUd49BfkQSCd5rUFPJ7/6GOjYJrYcsQVGumsN3v1iT7wP/LUzp7YiVxzyezlKs2i rfbHL59I6MumS4TB/R0ADF2ybEwhuHwg+iFWHMpzf2iKI+aN8u6dHJ4gyIv/roGjNvib ADlhlpxbng0a/CDSbCzrefpCH+XfHYJZ1+bB7GQ/9y8OeeuX3dqD4x3+xPQTIRNkTZhm 1hZ4T+PbiS9gMFqnD2Qvjej2JZ06h852NzovBrmEIvaiUeeRdSg9lM7FeRlrp52MJND2 S/tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=c6v2p/Mh2UIeR7AshI2QHs59D35WmV8IBz++4LUXbng=; b=Y6tSGYK/41f/qQyMrgBpylaGv8xOdzdrwRykqiVCkr1Skcal6zxp10gmnG9LLS66dI elcta1+5QKFfLmrnW0YkzHKTYVGUy6dp71tRngwCBCLw+UCnNW5uSbNhEW/vO4uU/OM+ Bkn1r4T7UyaFLLgesocPcpu/apkEshk9fjmcYMVEFiANvCuKhHbatqu+fQ9e+ANtPCTQ L3dZgwChABAyvU65DRQ21/zg5yVRaOqzK7G40Npx5Y9U/Tn6cQc55QXKeCM6DbmVZ8+s NcafESAEmGkFD6c/yKrpv1F4Wrx7FzE5apl+eVpCxUiZtGB4L4O27xq3pkPq3yrJe08i rApA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ufygQDov; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si12138042plr.72.2018.10.15.15.05.23; Mon, 15 Oct 2018 15:05:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ufygQDov; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726928AbeJPFwJ (ORCPT + 99 others); Tue, 16 Oct 2018 01:52:09 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:40130 "EHLO mail-lj1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbeJPFwJ (ORCPT ); Tue, 16 Oct 2018 01:52:09 -0400 Received: by mail-lj1-f170.google.com with SMTP id r83-v6so18934876ljr.7 for ; Mon, 15 Oct 2018 15:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c6v2p/Mh2UIeR7AshI2QHs59D35WmV8IBz++4LUXbng=; b=ufygQDovQPP5kauOD4VGri5yApe9sG8pPBWYC/jjGYlWoOGkv3N7SOEPz2jPiCd9UE aFbBgghDgGSFKhSu1uO8VNHIU9IwIX6AQ9o0j86v2xAJeu2T+odvN773jDar1zOZfRC0 OIjLyO0yaoKDTYIvuwodXJZ4vSboMaq7LfRHXpiK5O5gMAJ0Irf6J1AmeZM9TRO5k5lD nePaDrZhIZg+WbxBdvL64alrcyzDKAdGO/pUGkPLTKWhoipVTC8keTMWv0jffx+YbTZp oBfMhp80Xj2TJZfZm1/lilWN/7yILroffimgEfLwfpivN7VZRy4Bsgl0oTkGnTDIdb9N s55A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c6v2p/Mh2UIeR7AshI2QHs59D35WmV8IBz++4LUXbng=; b=ez2YxBZN+OhYfp8mrBj3OHGEwx/Ll852HxrqUaDCADIpXfYksfIzTuq4vRVF/ASuMQ g5V4MiNtZNUQMxPEVS2B0wpmt2FOOj4oC4wI1XkEjMUytejprTPQNZ97r3uTjTgultoA g3VNXu6bgoAl4DhjI/Z/h2nPqIOw/STlMyyYuxpowoCORtcBiLCb+P7VoIUwMQVxPkEB njUA0umyniemSXRPklGd+OaVNCo5Vc3yz7qnpI1w5e7rmYFMAACqGX5iW6/0s6vfZ0s1 gWjXIJ/xRaJ3GivhCFGDciXpovQLSVBCQp7AO5FNpVhsBeMVJr3K9IbSdVqTGiA6rbE4 15Gg== X-Gm-Message-State: ABuFfogyEgnqZERzLljvcXX/CHCJ9Lua8/nrO0IY3D/K7P4+yRx1OLMO //yqyrNryeBIV6fNVtKqEWtDVeZmRTZ7Qs5qhu2BicgBBLY= X-Received: by 2002:a2e:6d0a:: with SMTP id i10-v6mr13136016ljc.14.1539641099688; Mon, 15 Oct 2018 15:04:59 -0700 (PDT) MIME-Version: 1.0 References: <20181003171720.169953-1-rkir@google.com> <20181003171720.169953-7-rkir@google.com> <20181015183605.GB28454@kroah.com> In-Reply-To: <20181015183605.GB28454@kroah.com> From: Roman Kiryanov Date: Mon, 15 Oct 2018 15:04:47 -0700 Message-ID: Subject: Re: [PATCH v3 07/15] platform: goldfish: pipe: Return status from "deinit" since "remove" does not do much To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Todd Kjos Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This function can not fail, why are you returning 0 always? That > doesn't make sense. remove in struct platform_driver requires returning something, we have to have "return" somewhere. I think we want to return closer to the place where we do something useful.