Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: net/wan: hostess_sv11 + z85230 problems
To:     =?UTF-8?Q?Krzysztof_Ha=c5=82asa?= <khalasa@piap.pl>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Alan Cox <gnomes@lxorguk.ukuu.org.uk>
References: <1468d110-4f92-da7a-21b5-36afcec3c94e@infradead.org>
 <m34ldnd3ju.fsf@t19.piap.pl>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <dfa87c53-3b26-4473-5166-180760004f1e@infradead.org>
Date:   Mon, 15 Oct 2018 15:24:28 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <m34ldnd3ju.fsf@t19.piap.pl>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/15/18 1:20 AM, Krzysztof Hałasa wrote:
> Hi,
> 
> Randy Dunlap <rdunlap@infradead.org> writes:
> 
>> kernel 4.19-rc7, on i386, with NO wan/hdlc/hostess/z85230 hardware:
>>
>> modprobe hostess_sv11 + autoload of z85230 give:
> 
> BTW Hostess SV11 is apparently an ISA card, with all those problems.

Yeah.

>> [ 3162.511877] Call Trace:
...
> 
> Not sure about z8530 internals (driver and hw), but I guess the sv11
> driver should initialize the hw first, and only then request_irq().
> Perhaps there should be no "default address" either? The user would
> have to provide the hardware parameters explicitly.
> 
> How about this (totally untested):
> Fix the Hostess SV11 driver trying to use the hardware before its
> existence is detected.
> 
> Signed-off-by: Krzysztof Halasa <khalasa@piap.pl>

Tested-by: Randy Dunlap <rdunlap@infradead.org>

or you can just rm it, like Alan suggested.

thanks.
-- 
~Randy