Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4475115imm; Mon, 15 Oct 2018 15:47:35 -0700 (PDT) X-Google-Smtp-Source: ACcGV61Z+ileQ+9m1e/I1QBcXzREL2/0D+WueE3E9ZvyTpEDqU7L3etkeSIT2ioU0iD/+vG1El9M X-Received: by 2002:a62:968a:: with SMTP id s10-v6mr19266446pfk.191.1539643655826; Mon, 15 Oct 2018 15:47:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539643655; cv=none; d=google.com; s=arc-20160816; b=LNkfx2Up13dgJ1vv5pqb4NvMgFapul+5oVF4pSlizVEh5EymcF/gyjARjjIvimZ9ny i4xnkx+uC4yHjL28iwMmjEOJjX8K3PlLd7FsUsoSOZ8HLRl9hP8j9cgd+4yZFyFjRKOi skoEt9wd7mOJrjlDY0/UC+R6DTuOP45geygPWG5qsJcWydIAtp76UxihrrmoKog0up7v oFyFhRatk0e0lkzkt4rQcTzCdl/pSrg67JFB7NU1+G5qqdzNOlczEI8jM7kEcbJdJCug 02pVTyr8GwhOL0R4AjKoVZz4Y11+s62SQ/4GtaTKetqjAtHPZgT5WNMjTFEgvW6YN1ds J0gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=XQFllYClGd1uQOK3o9OSojQtCM1ildTE3T13sYosiAk=; b=vHYxxUXK5wW2DbiJ8CiImufN8qQL57mG/q6dJatNoHzUELwtw9v7aShih9C9U8AsKf H0jp7ghwZda+p0W/NGD7/v94BaeP2FNszN2VarD5LZUS0UsV2S6H1GwdJmfa/zd8h7At zLBViBuq9UBubgXtRpz3nGjVmQhwJKu0sbQSQWRdC7pIFOLVcSaKN0yeEIu0mwnn5BlW oRY8y4S1z4o1FsG3d+5Yqx4uDQS3n5/ESHkXXbGaOo32CEKrI8lGBcT6tLnw7HbhuNu7 B2wTpnz0X5r31OtvG8fMCmkG0wa+dX5WYV5dQn4j+D98l0eqc/68UUwvJ+L6ixQ5q6+3 dOwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=oLdAvSq8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=wdc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4-v6si11623603pll.214.2018.10.15.15.47.20; Mon, 15 Oct 2018 15:47:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=oLdAvSq8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=wdc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbeJPGdE (ORCPT + 99 others); Tue, 16 Oct 2018 02:33:04 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:56976 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726836AbeJPGdE (ORCPT ); Tue, 16 Oct 2018 02:33:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1539643548; x=1571179548; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=0kqf4lYkvDyufTbLog7W6BaQxp+WNMo095AGVKAKpQo=; b=oLdAvSq8/Msg85wAkr2Tir/RN+1qEXTAYL7pC9K5KlEnF3gjijhNgsX8 B24XijPD8dFaBJ8WboBMG/wVtyuoJHR5t5ne9DShavsRG52oFblZHTv3w bgvkpVxTBdSRcB8Lgr9dduZAPM3I4+0XSIwXHNIi5+R1s8mNSnPdFDt3a b2Jaji/OLU5kDvrmO6f9TqNmIrpWv9TMegteiKbuCmKF/30XuHCemOV24 6mlHjNQCJkrYjwenOExfDHvIEWNTkolAJrSdIzqC6syb5nuq+mt9D8qJD apxyE3Wkiot/boYV9alb0B4l1AU827cGJWmrmXmrmkEeSLGMbHZo3swdJ w==; X-IronPort-AV: E=Sophos;i="5.54,386,1534780800"; d="scan'208";a="96610859" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 16 Oct 2018 06:45:47 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP; 15 Oct 2018 15:30:22 -0700 Received: from c02v91rdhtd5.sdcorp.global.sandisk.com (HELO [10.111.73.114]) ([10.111.73.114]) by uls-op-cesaip01.wdc.com with ESMTP; 15 Oct 2018 15:45:47 -0700 Subject: Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller. To: Thierry Reding , Wesley Terpstra Cc: palmer@sifive.com, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linus.walleij@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, hch@infradead.org References: <1539111085-25502-1-git-send-email-atish.patra@wdc.com> <1539111085-25502-2-git-send-email-atish.patra@wdc.com> <20181010135109.GE21134@ulmo> From: Atish Patra Message-ID: Date: Mon, 15 Oct 2018 15:45:46 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181010135109.GE21134@ulmo> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/18 6:51 AM, Thierry Reding wrote: > On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote: > [...] >> +- interrupts: one interrupt per PWM channel (currently unused in the driver) > > This should probably say what the interrupt is used for. And once you > have that, remove the comment about it being unused in the driver. DT > is OS agnostic, so "driver" is very unspecific and your claim may > actually be false. > > Thierry > As per my understanding, they are generated by hardware but no usage of pwm interrupts as of now. I am not sure if removing the entire entry is a good idea. What would be the best way to represent that information ? May be this ? +-interrupts: one interrupt per PWM channel. No usage in HiFive Unleashed SoC. Regards, Atish