Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     linux-kernel@vger.kernel.org, kernel@collabora.com,
        Andrzej Hajda <a.hajda@samsung.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Archit Taneja <architt@codeaurora.org>,
        zain wang <wzz@rock-chips.com>,
        dri-devel@lists.freedesktop.org, Lin Huang <hl@rock-chips.com>,
        Douglas Anderson <dianders@chromium.org>,
        David Airlie <airlied@linux.ie>,
        Sean Paul <seanpaul@chromium.org>,
        Jeffy Chen <jeffy.chen@rock-chips.com>
Subject: Re: [PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch
Date:   Tue, 16 Oct 2018 02:11:28 +0300
Message-ID: <3089039.JAYFEciPKB@avalon>
Organization: Ideas on Board Oy
In-Reply-To: <20181013111844.22183-1-enric.balletbo@collabora.com>
References: <20181013111844.22183-1-enric.balletbo@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Enric,

Thank you for the patch.

On Saturday, 13 October 2018 14:18:44 EEST Enric Balletbo i Serra wrote:
> This patch avoids that building the bridge/analogix source code with
> smatch triggers complaints about inconsistent indenting.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> 
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index
> d68986cea132..75e2649d7515 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1219,12 +1219,12 @@ static int analogix_dp_bridge_attach(struct
> drm_bridge *bridge) * plat_data->attch return, that's why we record the
> connector
>  	 * point after plat attached.
>  	 */
> -	 if (dp->plat_data->attach) {
> -		 ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
> -		 if (ret) {
> -			 DRM_ERROR("Failed at platform attch func\n");
> -			 return ret;
> -		 }
> +	if (dp->plat_data->attach) {
> +		ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
> +		if (ret) {
> +			DRM_ERROR("Failed at platform attch func\n");
> +			return ret;
> +		}
>  	}

This looks good to me. While at it, could you s/attch/attach/ ? With that 
fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  	if (dp->plat_data->panel) {

-- 
Regards,

Laurent Pinchart