Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <f9ef58fa27419258de32c26d3a80c9e086522221.camel@perches.com>
Subject: Re: [PATCH] staging: add nrf24 driver
From:   Joe Perches <joe@perches.com>
To:     Marcin Ciupak <marcin.s.ciupak@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Date:   Mon, 15 Oct 2018 17:06:04 -0700
In-Reply-To: <20181015231743.k3roxxjwt66lc3lx@metis.ciupak.eu>
References: <20181015231743.k3roxxjwt66lc3lx@metis.ciupak.eu>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2018-10-16 at 01:17 +0200, Marcin Ciupak wrote:
> This patch adds driver for Nordic Semiconductor nRF24L01+ radio module.

[]
> diff --git a/drivers/staging/nrf24/nrf24_hal.c b/drivers/staging/nrf24/nrf24_hal.c

[]
> +static ssize_t nrf24_read_reg(struct spi_device *spi, u8 addr)
> +{
> +	ssize_t ret;
> +
> +	ret = spi_w8r8(spi, addr);
> +
> +	if (ret < 0)
> +		dev_dbg(&spi->dev, "%s: read 0x%X FAILED", __func__, addr);

Please add terminating newlines to all logging formats

		dev_dbg(&spi->dev, "%s: read 0x%X FAILED\n", __func__, addr);

etc...