Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4641048imm; Mon, 15 Oct 2018 19:41:38 -0700 (PDT) X-Google-Smtp-Source: ACcGV61HzYmjr0Fwz9elhKBiQA9KmYbGxrOEzvffsWXuYipVqCndk2M0iDtwxM3gt8mQde6ZxYzX X-Received: by 2002:a65:5a89:: with SMTP id c9-v6mr17960287pgt.216.1539657698494; Mon, 15 Oct 2018 19:41:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539657698; cv=none; d=google.com; s=arc-20160816; b=U9teV1Dkr/pqZB3OsQLIUhHuXKymiH7/sE4EpyLSfNO0xGyG8TMRfZ9bvrpWTPawwK xtHkBtsLddloHuJ/HotcYTHLADXeB/geVw5uLAUtuOu6xuSeWh5YyBxNucPcmKwhItg9 4Bg3PlocuOgaf7/857uVsh/0zEVmMaVEdmQsb9yC8OgXarRBxT+wbbCBIKN6kUMAwq6R Mz8lmKrkG+aXO3DUrEjHCYX1ldF5eqgZBzvZDVBal57RNb1wxhhDQ9LY2s01ZO48+ZKn hAzz4xDd4T3VSzcF+iNusmDxtA+hSOrG0XeEVi8a2hFROrHp+dbc8VbkM3eX7Ta4VLvs HTUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=Y8f+zX4OUAoqVg/3NA0TrDwr4Zjok9K4JF3715XNZDg=; b=M8ZxHRm0O5LcSnYuMYabjiJHpajPgbXqDrdMvSoJPTb+NKdJSInarPeYHj0npoi9SJ KVIAYX3iOxH2j2+MyW62jw79JBBTqcaok5L3xHs8a2dchrKLmnjsiYQHQ1ZhmBtjPHli JB/VqH7eSJ7+MBXEq9SCoM/6tz5oSGqmiF8Cew6CeCo+0aDyLRwi9Rw3yTLqb19a+aAj 96gGiXOx56sk6RBtEGa/A1vG3XgMiD7vLbp3RBkI93ogWKZ6ybm5zMzHGXJTNfY4bYdO 6s0xLl1ewqiV6fwosL1fd5tm23JygNGLmDMYLXlUWsept+3Bjd0K38cLaaD14ZkgILDt FRqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Pz2XI+1O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 194-v6si13187461pfy.164.2018.10.15.19.41.23; Mon, 15 Oct 2018 19:41:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Pz2XI+1O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727146AbeJPK1Y (ORCPT + 99 others); Tue, 16 Oct 2018 06:27:24 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35619 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbeJPK1X (ORCPT ); Tue, 16 Oct 2018 06:27:23 -0400 Received: by mail-pg1-f196.google.com with SMTP id v133-v6so10083722pgb.2; Mon, 15 Oct 2018 19:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Y8f+zX4OUAoqVg/3NA0TrDwr4Zjok9K4JF3715XNZDg=; b=Pz2XI+1ObqUZo1ImYBBq3zxgz48Xj61KFjDE8Byrv/fwDR3xsoNnKThcXWQ7CVJelA /zoexFsTfJsm4xS7+UPjlEqibbPlFZNm7i0uVfZQQVvbpgvIhAcoCENWsQ7V9W4Swrxd W7l549iqzGALxPUDBWQ3EH27cX467WAUPOHSSPaAqGw44o+7qo23a44cdcdr6CYIhd08 4b8Xr/AIskYHMU5neqoxKBK1qj4Ab5sQsijSqgVOfbQEKD62oxPSZSpqLqs0raJ52zay pTey4Iu1LmYkZe+QctnvuNNlCW+C5nBYTGAEDM3HDqemNmynH0evHZIpaXWFfGjoEZ8l ffew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Y8f+zX4OUAoqVg/3NA0TrDwr4Zjok9K4JF3715XNZDg=; b=PgTyOk44qAUPDjM/Z42h4QySTjFmtx0tBZZKxh0j1OLsjf3AljIeRc/TdEdg2WcQoE Bt49vFNdmqiic9GsvCu1gIv5/ZZVcm9KjzxEH64YSw8ykl44OOioM2HjCjB69z9i3u4+ 6VKwqkGNQzunVTrXYTcmjnRGS/DXYqcZiPvF7ZbFsoouxKdKmZvRndgA8wBE51FplgOg CpS/GHUDfDVZV7U2sbXMqiieyV9gQRblCAbd0NWAQTcn8nhS00iObBL43SvrxGHNDTye Mwl5VlO5mpay9rxuYgEE0ZGgxdvN3rRwOBea0nFl27c9jO0OBrBVU6cs7CHO6ZH+0aWj gyTg== X-Gm-Message-State: ABuFfohAnjw8w+rvyrqgq0qKK33sQh8g0tZ6HnEgC09SmEVlY1couSqA +q+w3v42tNjG2SOkz3r8wcgeWa6g X-Received: by 2002:a63:7d43:: with SMTP id m3-v6mr18490443pgn.341.1539657558952; Mon, 15 Oct 2018 19:39:18 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id u79-v6sm18620287pfd.117.2018.10.15.19.39.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 15 Oct 2018 19:39:18 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH v4 06/18] of: overlay: do not duplicate properties from overlay for new nodes Date: Mon, 15 Oct 2018 19:37:26 -0700 Message-Id: <1539657458-24401-7-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1539657458-24401-1-git-send-email-frowand.list@gmail.com> References: <1539657458-24401-1-git-send-email-frowand.list@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand When allocating a new node, add_changeset_node() was duplicating the properties from the respective node in the overlay instead of allocating a node with no properties. When this patch is applied the errors reported by the devictree unittest from patch "of: overlay: add tests to validate kfrees from overlay removal" will no longer occur. These error messages are of the form: "OF: ERROR: ..." and the unittest results will change from: ### dt-test ### end of unittest - 203 passed, 7 failed to ### dt-test ### end of unittest - 210 passed, 0 failed Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 94740f4ee34c..7fcf4a812d06 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -393,7 +393,7 @@ static int add_changeset_node(struct overlay_changeset *ovcs, break; if (!tchild) { - tchild = __of_node_dup(node, node_kbasename); + tchild = __of_node_dup(NULL, node_kbasename); if (!tchild) return -ENOMEM; -- Frank Rowand